From 664d53258de31362475b43658add0ebcf95be168 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Wed, 13 Jul 2011 12:38:50 +1000 Subject: [PATCH] super-intel: fix buffer overflow in detail-platform. The serial number is not necessarily nul terminated, so we need to be sure to only use the allowed number of chars. Signed-off-by: NeilBrown Reported-by: Arvin Schnell --- super-intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/super-intel.c b/super-intel.c index 2ef2b3c6..5ea3b368 100644 --- a/super-intel.c +++ b/super-intel.c @@ -1518,9 +1518,9 @@ static int ahci_enumerate_ports(const char *hba_path, int port_count, int host_b fd2devname(fd, buf); printf(" Port%d : %s", port, buf); if (imsm_read_serial(fd, NULL, (__u8 *) buf) == 0) - printf(" (%s)\n", buf); + printf(" (%.*s)\n", MAX_RAID_SERIAL_LEN, buf); else - printf("()\n"); + printf(" ()\n"); } close(fd); free(path); -- 2.39.2