]> git.ipfire.org Git - thirdparty/qemu.git/commit - hw/virtio/virtio.c
aio: remove aio_disable_external() API
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 16 May 2023 19:02:38 +0000 (15:02 -0400)
committerKevin Wolf <kwolf@redhat.com>
Tue, 30 May 2023 15:37:26 +0000 (17:37 +0200)
commit60f782b6b78211c125970768be726c9f380dbd61
tree44c131946293943ddf967271ac5ff52450af6b07
parent03d7162a21e60d87cfa39a8d078c784487fa5f30
aio: remove aio_disable_external() API

All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.

Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().

The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().

Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:

  @@
  expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
  @@
  - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
  + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)

  @@
  expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
  @@
  - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
  + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)

Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
36 files changed:
block.c
block/blkio.c
block/curl.c
block/export/fuse.c
block/export/vduse-blk.c
block/io.c
block/io_uring.c
block/iscsi.c
block/linux-aio.c
block/nfs.c
block/nvme.c
block/ssh.c
block/win32-aio.c
hw/i386/kvm/xen_xenstore.c
hw/virtio/virtio.c
hw/xen/xen-bus.c
include/block/aio.h
io/channel-command.c
io/channel-file.c
io/channel-socket.c
migration/rdma.c
tests/unit/meson.build
tests/unit/test-aio.c
tests/unit/test-bdrv-drain.c
tests/unit/test-fdmon-epoll.c [deleted file]
tests/unit/test-nested-aio-poll.c
util/aio-posix.c
util/aio-posix.h
util/aio-win32.c
util/async.c
util/fdmon-epoll.c
util/fdmon-io_uring.c
util/fdmon-poll.c
util/main-loop.c
util/qemu-coroutine-io.c
util/vhost-user-server.c