]> git.ipfire.org Git - thirdparty/squid.git/commit - src/Transients.cc
Cleanup: fix most 'unused parameter' warnings
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 1 Jan 2015 08:57:18 +0000 (00:57 -0800)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 1 Jan 2015 08:57:18 +0000 (00:57 -0800)
commitced8def38409d2e3f76af4428a823678e46d24eb
tree90f6d6876b1a0d05fb1a71218957c334b875fee4
parent836a7ffc27f7934243c8f54aaf95f157d99b1898
Cleanup: fix most 'unused parameter' warnings

... and several bugs hidden by lack of this check:

* url_rewrite_timeout parser/dumper using wrong cf.data.pre
  parameter definition.

* url_rewrite_timeout parser/dumper using wrong object for
  state data.
  Global a Config object instead of parameter object.
  Preventing future use of multiple Config objects. There is
  more to be done as the Timeout value itself is not stored
  as part of the object apparently detailing the timeout.

* request_header_add directive dump() omitting directive
  name in mgr:config output.

* dead code as HTCP packet handlers for NOP, MON, SET

* mime icons download operation incorrectly initialized.
  was using the 'view' access parameter to set download
  access permission.

* peerCountHandleIcpReply() assertions testing validity
  after pointers already used. This would lead to segfault
  on errors, now leading to assertion logging.

Only the default built code was checked and updated at this
time. There are 62 known warnings still appearing due to
parameters being only used inside conditional code, possibly
more issues in code not enabled in this build and certainly
a lot more in the stubs and unit tests which were not checked.
133 files changed:
helpers/basic_auth/RADIUS/basic_radius_auth.cc
helpers/basic_auth/SASL/basic_sasl_auth.cc
helpers/basic_auth/SMB_LM/valid.cc
helpers/basic_auth/getpwnam/basic_getpwnam_auth.cc
helpers/external_acl/kerberos_ldap_group/support_ldap.cc
helpers/external_acl/kerberos_ldap_group/support_sasl.cc
helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.cc
lib/ntlmauth/ntlmauth.cc
src/BodyPipe.cc
src/DiskIO/AIO/AIODiskFile.cc
src/DiskIO/AIO/AIODiskIOStrategy.cc
src/DiskIO/Blocking/BlockingFile.cc
src/DiskIO/DiskDaemon/DiskdFile.cc
src/DiskIO/DiskDaemon/diskd.cc
src/DiskIO/DiskFile.h
src/DiskIO/DiskIOStrategy.h
src/DiskIO/DiskThreads/CommIO.cc
src/DiskIO/DiskThreads/DiskThreadsDiskFile.cc
src/DiskIO/IpcIo/IpcIoFile.cc
src/DiskIO/Mmapped/MmappedFile.cc
src/FwdState.cc
src/HttpHdrCc.cc
src/HttpHdrSc.cc
src/HttpHeader.cc
src/HttpRequest.cc
src/MemBuf.h
src/MemStore.cc
src/SBufStatsAction.cc
src/SquidConfig.h
src/StatHist.cc
src/Store.h
src/StoreIOState.cc
src/StoreMeta.cc
src/SwapDir.cc
src/Transients.cc
src/WinSvc.h
src/acl/Acl.cc
src/acl/DestinationDomain.cc
src/acl/Ip.cc
src/acl/Random.cc
src/acl/SourceDomain.cc
src/acl/Time.cc
src/adaptation/Initiator.cc
src/adaptation/ServiceGroups.h
src/adaptation/icap/ModXact.cc
src/adaptation/icap/Xaction.cc
src/adaptation/icap/Xaction.h
src/auth/Config.cc
src/auth/User.cc
src/auth/UserRequest.cc
src/auth/basic/Config.cc
src/auth/basic/UserRequest.cc
src/auth/digest/Config.cc
src/auth/digest/UserRequest.cc
src/auth/negotiate/Config.cc
src/auth/negotiate/UserRequest.cc
src/auth/ntlm/Config.cc
src/auth/ntlm/UserRequest.cc
src/base/AsyncCbdataCalls.h
src/base/AsyncJob.cc
src/cache_cf.cc
src/cbdata.cc
src/cf.data.depend
src/cf.data.pre
src/client_db.cc
src/client_side.cc
src/clients/FtpClient.cc
src/comm/ConnOpener.cc
src/comm/TcpAcceptor.cc
src/disk.cc
src/dns_internal.cc
src/errorpage.cc
src/eui/Eui64.cc
src/event.cc
src/fd.cc
src/fqdncache.cc
src/fs/rock/RockIoState.cc
src/fs/rock/RockStoreFileSystem.cc
src/fs/rock/RockSwapDir.cc
src/fs/ufs/RebuildState.cc
src/fs/ufs/UFSStoreState.cc
src/fs/ufs/UFSStrategy.cc
src/fs/ufs/UFSSwapDir.cc
src/gopher.cc
src/helper.cc
src/htcp.cc
src/http.cc
src/http/StatusLine.cc
src/icp_v2.cc
src/ident/Ident.cc
src/ip/Intercept.cc
src/ip/QosConfig.cc
src/ipc/Queue.cc
src/ipcache.cc
src/log/ModDaemon.cc
src/log/ModStdio.cc
src/log/ModSyslog.cc
src/log/ModUdp.cc
src/log/TcpLogger.cc
src/main.cc
src/mem/Pool.h
src/mem/PoolChunked.cc
src/mem/PoolMalloc.cc
src/mem/old_api.cc
src/mgr/Action.cc
src/mgr/Action.h
src/mgr/BasicActions.cc
src/mgr/Forwarder.cc
src/mgr/StoreToCommWriter.cc
src/mime.cc
src/multicast.cc
src/neighbors.cc
src/pconn.cc
src/send-announce.cc
src/servers/FtpServer.cc
src/snmp_core.cc
src/stat.cc
src/store.cc
src/store_client.cc
src/store_dir.cc
src/store_rebuild.cc
src/store_swapin.cc
src/tests/stub_debug.cc
src/tools.cc
src/tunnel.cc
src/unlinkd_daemon.cc
src/urn.cc
src/wccp.cc
src/wccp2.cc
src/whois.cc
tools/cachemgr.cc
tools/purge/socket.cc
tools/squidclient/squidclient.cc