]> git.ipfire.org Git - thirdparty/squid.git/commit - src/adaptation/icap/ModXact.cc
Supply ALE with HttpReply before checking http_reply_access (#398)
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Tue, 10 Sep 2019 05:36:25 +0000 (05:36 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Tue, 10 Sep 2019 05:36:28 +0000 (05:36 +0000)
commit49f57088f725f0823afa2bedfcef6a1b210eb0d8
tree83b4581f79e6e12dce5a721c7eb4ac4f5366bc17
parentdaf80700130b6f98256b75c511916d1a79b23597
Supply ALE with HttpReply before checking http_reply_access (#398)

Before this fix, Squid warned "ALE missing HttpReply object",
because ALE::reply was initialized too late. This problem affected
both HTTP and FTP code paths.

To avoid these problems, ALE::reply is initialized early with the
available (received) response.

Also:

* Fixed logging control (1xx) responses in case these responses
  are final. Before this fix, '-' was logged.

* All reply headers ('<h') were logged with a single CR separator,
  instead of CRLF.

* Supply ALE for send_hit ACL. cb36505 already covered many (but not
  all) similar cases.
16 files changed:
src/AccessLogEntry.cc
src/AccessLogEntry.h
src/acl/FilledChecklist.cc
src/adaptation/icap/ModXact.cc
src/adaptation/icap/icap_log.cc
src/client_side.cc
src/client_side_reply.cc
src/client_side_request.cc
src/clients/Client.cc
src/format/Format.cc
src/http.cc
src/log/FormatHttpdCombined.cc
src/log/FormatHttpdCommon.cc
src/log/FormatSquidNative.cc
src/servers/FtpServer.cc
src/servers/Http1Server.cc