]> git.ipfire.org Git - thirdparty/squid.git/commit - src/adaptation/icap/ModXact.cc
Polish: Drop redundant HttpMsgPointerT template
authorAmos Jeffries <squid3@treenet.co.nz>
Tue, 12 Feb 2013 11:34:35 +0000 (00:34 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Tue, 12 Feb 2013 11:34:35 +0000 (00:34 +1300)
commitb248c2a378826c9c027192b5db4fabd984fd7b13
treeddfc5ef36673bff7f426a9e0cc926e27b296fe3f
parent4e752abd23ef4b9ac4d8610bb1c66338bfd34bd5
Polish: Drop redundant HttpMsgPointerT template

Despite the object and API changes being rather extensive
there are no logic changes in this patch.

The HttpMsgPointerT template was used to ref-count HttpMsg
objects and its children. It provided an API identical to
the RefCount API plus a few extensions for handling
polymorphism cast operations in the background.

This patch:

* update HttpMsg class hierarchy to use Lock API directly
 removing the _lock() and _unlock() virtual functions.

* update HttpControlMsg to use a HttpReply::Pointer directly
 since this type is available to that class a re-definition
 using HttpMsg* casting was not needed.

* update HTTPMSGLOCK() macro not to return a HttpMsg*
 The API polymorphism extensions provided by
 HttpMsgPointerT<> were only necessary to handle the
 HttpMsg* object casting this macro made a requirement.
 Once that assignment casting is removed the entire
 API extensions are no longer used.
42 files changed:
src/HttpControlMsg.h
src/HttpMsg.cc
src/HttpMsg.h
src/HttpReply.cc
src/HttpReply.h
src/HttpRequest.h
src/MemObject.cc
src/Notes.cc
src/Server.cc
src/acl/Asn.cc
src/acl/FilledChecklist.cc
src/adaptation/AccessCheck.cc
src/adaptation/Answer.h
src/adaptation/Iterator.cc
src/adaptation/Message.cc
src/adaptation/ServiceFilter.cc
src/adaptation/icap/InOut.h
src/adaptation/icap/Launcher.cc
src/adaptation/icap/ModXact.cc
src/adaptation/icap/OptXact.cc
src/adaptation/icap/ServiceRep.cc
src/adaptation/icap/Xaction.cc
src/client_side.cc
src/client_side_reply.cc
src/client_side_request.cc
src/errorpage.cc
src/errorpage.h
src/forward.cc
src/http.cc
src/icp_v2.cc
src/mime.cc
src/neighbors.cc
src/peer_digest.cc
src/peer_select.cc
src/ssl/ErrorDetail.cc
src/ssl/ErrorDetailManager.cc
src/ssl/ErrorDetailManager.h
src/ssl/ServerBump.cc
src/store_digest.cc
src/tests/stub_errorpage.cc
src/tunnel.cc
src/urn.cc