]> git.ipfire.org Git - thirdparty/squid.git/commit - src/adaptation/icap/ModXact.cc
Propagate details of ICAP errors happened after adapted HTTP header creation.
authorAlex Rousskov <rousskov@measurement-factory.com>
Wed, 23 Mar 2011 00:18:28 +0000 (18:18 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Wed, 23 Mar 2011 00:18:28 +0000 (18:18 -0600)
commite9fa54936418dd6246f4fc941e232d37218f6efc
tree910c01cf03c8c0ab5dde4b497223cec42c828de0
parent1545d2d134c542a19ec4fe2a5a3381d8f12b9320
Propagate details of ICAP errors happened after adapted HTTP header creation.

We used to update the virgin HTTP request with error details even after REQMOD
resulted in creation of a new/adapted HTTP request object. When the client
side replaced the old/virgin request headers with the new adapted request
object, the error details were lost and %err_detail was not logged to the
transaction log.

This is one more place where a Master Transaction object (with a shared error
detail field) should be extracted from the HttpRequest and persist throughout
the HTTP transaction lifetime.
src/adaptation/icap/ModXact.cc