]> git.ipfire.org Git - thirdparty/squid.git/commit
Bug 5344: mgr:config segfaults without logformat (#1680)
authorAlex Rousskov <rousskov@measurement-factory.com>
Fri, 16 Feb 2024 04:03:40 +0000 (04:03 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Fri, 16 Feb 2024 07:34:32 +0000 (07:34 +0000)
commit0129396e16573b92e7e0c81c46653f5d488968e6
treee77b8b83af5788685478ef4abc42bb11b7623459
parentca919500647218fae924905a5c3f4184492417b0
Bug 5344: mgr:config segfaults without logformat (#1680)

Since 2011 commit 38e16f9, Log::LogConfig::dumpFormats() dereferenced a
nil `logformats` pointer while reporting a non-existent logformat
configuration (e.g., squid.conf.default): `logformats->dump(e, name)`.

In most environments, that code "worked" because the corresponding
Format::Format::dump() method happens to do nothing if "this" is nil.
However, in some environments, Squid segfaulted.
src/log/Config.h