]> git.ipfire.org Git - thirdparty/squid.git/commit
Fixed Transient reader locking broken by 4310f8b (#161) M-staged-PR161
authorAlex Rousskov <rousskov@measurement-factory.com>
Thu, 12 Apr 2018 22:12:39 +0000 (22:12 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Thu, 12 Apr 2018 22:12:43 +0000 (22:12 +0000)
commit8253d451bad3c74742b0791fb2b874ca7c564e1b
treea589d465c192f92f685a571c1a13483095d137a8
parent819be28411d53ebb9f1c6c17fa5979b9b9568277
Fixed Transient reader locking broken by 4310f8b (#161)

The closeForWriting() call comment is correct -- we must keep the lock,
but the optional argument was accidentally lost (when undoing the failed
attempt to remove all long-term transient locks in the feature branch).

Also polished stale comments (which led to the above bug discovery!).

Also polished addEntry() aspects that I have missed in 4310f8b.
src/MemStore.cc
src/Transients.cc
src/fs/rock/RockRebuild.cc
src/fs/rock/RockSwapDir.cc
src/ipc/MemMap.cc
src/ipc/MemMap.h
src/ipc/StoreMap.cc
src/ipc/StoreMap.h