]> git.ipfire.org Git - thirdparty/systemd.git/commit - meson.build
Move various files that don't need to be in basic/ to shared/
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 19 Nov 2018 10:12:28 +0000 (11:12 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 20 Nov 2018 06:27:37 +0000 (07:27 +0100)
commitd284b82b3edcfa610c72e66444ff969396be1e3b
tree4ce3640f82d04ba57b84c849425979b1f6149617
parent278939be7a8eb07c696b3601cb63522d252b7291
Move various files that don't need to be in basic/ to shared/

This doesn't have much effect on the final build, because we link libbasic.a
into libsystemd-shared.so, so in the end, all the object built from basic/
end up in libsystemd-shared. And when the static library is linked into binaries,
any objects that are included in it but are not used are trimmed. Hence, the
size of output artifacts doesn't change:

$ du -sb /var/tmp/inst*
54181861 /var/tmp/inst1    (old)
54207441 /var/tmp/inst1s   (old split-usr)
54182477 /var/tmp/inst2    (new)
54208041 /var/tmp/inst2s   (new split-usr)

(The negligible change in size is because libsystemd-shared.so is bigger
by a few hundred bytes. I guess it's because symbols are named differently
or something like that.)

The effect is on the build process, in particular partial builds. This change
effectively moves the requirements on some build steps toward the leaves of the
dependency tree. Two effects:
- when building items that do not depend on libsystemd-shared, we
  build less stuff for libbasic.a (which wouldn't be used anyway,
  so it's a net win).
- when building items that do depend on libshared, we reduce libbasic.a as a
  synchronization point, possibly allowing better parallelism.

Method:
1. copy list of .h files from src/basic/meson.build to /tmp/basic
2. $ for i in $(grep '.h$' /tmp/basic); do echo $i; git --no-pager grep "include \"$i\"" src/basic/ 'src/lib*' 'src/nss-*' 'src/journal/sd-journal.c' |grep -v "${i%.h}.c";echo ;done | less
49 files changed:
meson.build
src/basic/meson.build
src/shared/barrier.c [moved from src/basic/barrier.c with 100% similarity]
src/shared/barrier.h [moved from src/basic/barrier.h with 100% similarity]
src/shared/bitmap.c [moved from src/basic/bitmap.c with 100% similarity]
src/shared/bitmap.h [moved from src/basic/bitmap.h with 100% similarity]
src/shared/blkid-util.h [moved from src/basic/blkid-util.h with 100% similarity]
src/shared/bpf-program.c [moved from src/basic/bpf-program.c with 100% similarity]
src/shared/bpf-program.h [moved from src/basic/bpf-program.h with 100% similarity]
src/shared/calendarspec.c [moved from src/basic/calendarspec.c with 100% similarity]
src/shared/calendarspec.h [moved from src/basic/calendarspec.h with 100% similarity]
src/shared/clock-util.c [moved from src/basic/clock-util.c with 100% similarity]
src/shared/clock-util.h [moved from src/basic/clock-util.h with 100% similarity]
src/shared/cpu-set-util.c [moved from src/basic/cpu-set-util.c with 100% similarity]
src/shared/cpu-set-util.h [moved from src/basic/cpu-set-util.h with 100% similarity]
src/shared/crypt-util.c [moved from src/basic/crypt-util.c with 100% similarity]
src/shared/crypt-util.h [moved from src/basic/crypt-util.h with 100% similarity]
src/shared/exec-util.c [moved from src/basic/exec-util.c with 100% similarity]
src/shared/exec-util.h [moved from src/basic/exec-util.h with 100% similarity]
src/shared/exit-status.c [moved from src/basic/exit-status.c with 100% similarity]
src/shared/exit-status.h [moved from src/basic/exit-status.h with 100% similarity]
src/shared/fileio-label.c [moved from src/basic/fileio-label.c with 100% similarity]
src/shared/fileio-label.h [moved from src/basic/fileio-label.h with 100% similarity]
src/shared/format-table.c [moved from src/basic/format-table.c with 100% similarity]
src/shared/format-table.h [moved from src/basic/format-table.h with 100% similarity]
src/shared/journal-importer.c [moved from src/basic/journal-importer.c with 100% similarity]
src/shared/journal-importer.h [moved from src/basic/journal-importer.h with 100% similarity]
src/shared/json-internal.h [moved from src/basic/json-internal.h with 100% similarity]
src/shared/json.c [moved from src/basic/json.c with 100% similarity]
src/shared/json.h [moved from src/basic/json.h with 100% similarity]
src/shared/lockfile-util.c [moved from src/basic/lockfile-util.c with 100% similarity]
src/shared/lockfile-util.h [moved from src/basic/lockfile-util.h with 100% similarity]
src/shared/meson.build
src/shared/os-util.c [moved from src/basic/os-util.c with 100% similarity]
src/shared/os-util.h [moved from src/basic/os-util.h with 100% similarity]
src/shared/reboot-util.c [moved from src/basic/reboot-util.c with 100% similarity]
src/shared/reboot-util.h [moved from src/basic/reboot-util.h with 100% similarity]
src/shared/rlimit-util.c [moved from src/basic/rlimit-util.c with 100% similarity]
src/shared/rlimit-util.h [moved from src/basic/rlimit-util.h with 100% similarity]
src/shared/securebits-util.c [moved from src/basic/securebits-util.c with 100% similarity]
src/shared/securebits-util.h [moved from src/basic/securebits-util.h with 100% similarity]
src/shared/socket-protocol-list.c [moved from src/basic/socket-protocol-list.c with 100% similarity]
src/shared/socket-protocol-list.h [moved from src/basic/socket-protocol-list.h with 100% similarity]
src/shared/verbs.c [moved from src/basic/verbs.c with 100% similarity]
src/shared/verbs.h [moved from src/basic/verbs.h with 100% similarity]
src/shared/web-util.c [moved from src/basic/web-util.c with 100% similarity]
src/shared/web-util.h [moved from src/basic/web-util.h with 100% similarity]
src/shared/xml.c [moved from src/basic/xml.c with 100% similarity]
src/shared/xml.h [moved from src/basic/xml.h with 100% similarity]