]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/core/scope.c
core: remember first unit failure, not last unit failure
authorLennart Poettering <lennart@poettering.net>
Thu, 4 Aug 2016 19:14:27 +0000 (21:14 +0200)
committerLennart Poettering <lennart@poettering.net>
Thu, 4 Aug 2016 21:08:05 +0000 (23:08 +0200)
commita0fef983ab200db4e2b151beb06c9cf8fef6c5ab
treef9043614053b8df8735f1d6494c291605e0f5d21
parentd47f681b285b1dfb7ce68200205bfe8b835657a2
core: remember first unit failure, not last unit failure

Previously, the result value of a unit was overriden with each failure that
took place, so that the result always reported the last failure that took
place.

With this commit this is changed, so that the first failure taking place is
stored instead. This should normally not matter much as multiple failures are
sufficiently uncommon. However, it improves one behaviour: if we send SIGABRT
to a service due to a watchdog timeout, then this currently would be reported
as "coredump" failure, rather than the "watchodg" failure it really is. Hence,
in order to report information about the type of the failure, and not about
the effect of it, let's change this from all unit type to store the first, not
the last failure.

This addresses the issue pointed out here:

https://github.com/systemd/systemd/pull/3818#discussion_r73433520
src/core/automount.c
src/core/busname.c
src/core/mount.c
src/core/path.c
src/core/scope.c
src/core/service.c
src/core/socket.c
src/core/swap.c
src/core/timer.c