]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/home/user-record-util.c
Drop the text argument from assert_not_reached()
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 27 Jul 2021 10:27:28 +0000 (12:27 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 3 Aug 2021 08:05:10 +0000 (10:05 +0200)
commit04499a70fbff3f6b798028473f5c9234a53eaa2d
treeec7a851e163ee20ba5211c16a86f1c251543e0a7
parentc7cfde640d2b32ff1eb893d1fcd291c25cd421e7
Drop the text argument from assert_not_reached()

In general we almost never hit those asserts in production code, so users see
them very rarely, if ever. But either way, we just need something that users
can pass to the developers.

We have quite a few of those asserts, and some have fairly nice messages, but
many are like "WTF?" or "???" or "unexpected something". The error that is
printed includes the file location, and function name. In almost all functions
there's at most one assert, so the function name alone is enough to identify
the failure for a developer. So we don't get much extra from the message, and
we might just as well drop them.

Dropping them makes our code a tiny bit smaller, and most importantly, improves
development experience by making it easy to insert such an assert in the code
without thinking how to phrase the argument.
222 files changed:
src/ac-power/ac-power.c
src/activate/activate.c
src/analyze/analyze.c
src/ask-password/ask-password.c
src/backlight/backlight.c
src/basic/architecture.c
src/basic/hashmap.c
src/basic/in-addr-util.c
src/basic/log.c
src/basic/log.h
src/basic/macro.h
src/basic/path-lookup.c
src/basic/socket-util.h
src/basic/stdio-util.h
src/binfmt/binfmt.c
src/boot/bless-boot.c
src/boot/boot-check-no-failures.c
src/boot/bootctl.c
src/busctl/busctl-introspect.c
src/busctl/busctl.c
src/cgls/cgls.c
src/cgtop/cgtop.c
src/core/dbus-socket.c
src/core/dynamic-user.c
src/core/emergency-action.c
src/core/execute.c
src/core/job.c
src/core/main.c
src/core/mount.c
src/core/namespace.c
src/core/scope.c
src/core/service.c
src/core/socket.c
src/core/swap.c
src/core/timer.c
src/core/unit.c
src/coredump/coredumpctl.c
src/creds/creds.c
src/cryptenroll/cryptenroll-wipe.c
src/cryptenroll/cryptenroll.c
src/delta/delta.c
src/detect-virt/detect-virt.c
src/dissect/dissect.c
src/escape/escape.c
src/firstboot/firstboot.c
src/home/homectl.c
src/home/homed-home.c
src/home/homed-manager.c
src/home/homework-directory.c
src/home/homework.c
src/home/user-record-util.c
src/hostname/hostnamectl.c
src/hwdb/hwdb.c
src/id128/id128.c
src/import/export.c
src/import/import-compress.c
src/import/import-fs.c
src/import/import.c
src/import/importd.c
src/import/pull-job.c
src/import/pull-raw.c
src/import/pull-tar.c
src/import/pull.c
src/journal-remote/journal-gatewayd.c
src/journal-remote/journal-remote-main.c
src/journal-remote/journal-remote.c
src/journal-remote/journal-upload-journal.c
src/journal-remote/journal-upload.c
src/journal/cat.c
src/journal/journalctl.c
src/journal/journald-stream.c
src/libsystemd-network/sd-dhcp-client.c
src/libsystemd-network/sd-ipv4acd.c
src/libsystemd-network/sd-ipv4ll.c
src/libsystemd-network/test-acd.c
src/libsystemd-network/test-dhcp-client.c
src/libsystemd-network/test-dhcp6-client.c
src/libsystemd-network/test-ipv4ll-manual.c
src/libsystemd/sd-bus/bus-dump.c
src/libsystemd/sd-bus/bus-gvariant.c
src/libsystemd/sd-bus/bus-match.c
src/libsystemd/sd-bus/bus-message.c
src/libsystemd/sd-bus/bus-slot.c
src/libsystemd/sd-bus/sd-bus.c
src/libsystemd/sd-bus/test-bus-benchmark.c
src/libsystemd/sd-bus/test-bus-signature.c
src/libsystemd/sd-device/sd-device.c
src/libsystemd/sd-event/sd-event.c
src/libsystemd/sd-event/test-event.c
src/libsystemd/sd-journal/sd-journal.c
src/libsystemd/sd-journal/test-compress-benchmark.c
src/libsystemd/sd-netlink/netlink-message.c
src/libsystemd/sd-netlink/netlink-slot.c
src/libsystemd/sd-netlink/rtnl-message.c
src/libsystemd/sd-resolve/sd-resolve.c
src/libsystemd/sd-resolve/test-resolve.c
src/libudev/test-libudev.c
src/locale/keymap-util.c
src/locale/localectl.c
src/login/inhibit.c
src/login/loginctl.c
src/login/logind-dbus.c
src/login/user-runtime-dir.c
src/machine-id-setup/machine-id-setup-main.c
src/machine/machinectl.c
src/modules-load/modules-load.c
src/mount/mount-tool.c
src/network/generator/main.c
src/network/netdev/fou-tunnel.c
src/network/netdev/netdev.c
src/network/netdev/tunnel.c
src/network/networkctl.c
src/network/networkd-address.c
src/network/networkd-bridge-mdb.c
src/network/networkd-dhcp-server.c
src/network/networkd-dhcp4.c
src/network/networkd-ipv4acd.c
src/network/networkd-link.c
src/network/networkd-ndisc.c
src/network/networkd-neighbor.c
src/network/networkd-nexthop.c
src/network/networkd-queue.c
src/network/networkd-route.c
src/network/networkd-routing-policy-rule.c
src/network/networkd-setlink.c
src/network/networkd-sriov.c
src/network/tc/codel.c
src/network/tc/ets.c
src/network/tc/fifo.c
src/network/tc/fq-codel.c
src/network/tc/fq.c
src/network/tc/gred.c
src/network/tc/htb.c
src/network/tc/tbf.c
src/network/tc/tc.c
src/network/wait-online/wait-online.c
src/notify/notify.c
src/nspawn/nspawn-mount.c
src/nspawn/nspawn-stub-pid1.c
src/nspawn/nspawn.c
src/oom/oomctl.c
src/oom/oomd.c
src/partition/growfs.c
src/partition/repart.c
src/path/path.c
src/portable/portable.c
src/portable/portablectl.c
src/resolve/resolvconf-compat.c
src/resolve/resolvectl.c
src/resolve/resolved-bus.c
src/resolve/resolved-conf.c
src/resolve/resolved-dns-dnssec.c
src/resolve/resolved-dns-packet.h
src/resolve/resolved-dns-scope.c
src/resolve/resolved-dns-search-domain.c
src/resolve/resolved-dns-server.c
src/resolve/resolved-dns-stub.c
src/resolve/resolved-dns-transaction.c
src/resolve/resolved-varlink.c
src/run/run.c
src/shared/acl-util.c
src/shared/bus-util.c
src/shared/condition.c
src/shared/format-table.c
src/shared/install.c
src/shared/journal-importer.c
src/shared/json.c
src/shared/local-addresses.c
src/shared/logs-show.c
src/shared/service-util.c
src/shared/socket-netlink.c
src/shared/tests.c
src/shared/userdb.c
src/shared/varlink.c
src/shared/xml.c
src/shutdown/shutdown.c
src/sleep/sleep.c
src/socket-proxy/socket-proxyd.c
src/sysctl/sysctl.c
src/sysext/sysext.c
src/systemctl/systemctl-add-dependency.c
src/systemctl/systemctl-clean-or-freeze.c
src/systemctl/systemctl-compat-halt.c
src/systemctl/systemctl-compat-runlevel.c
src/systemctl/systemctl-compat-shutdown.c
src/systemctl/systemctl-compat-telinit.c
src/systemctl/systemctl-daemon-reload.c
src/systemctl/systemctl-enable.c
src/systemctl/systemctl-util.c
src/systemctl/systemctl.c
src/sysusers/sysusers.c
src/test/test-bitmap.c
src/test/test-chase-symlinks.c
src/test/test-install-root.c
src/test/test-path-util.c
src/test/test-proc-cmdline.c
src/test/test-strv.c
src/test/test-util.c
src/timedate/timedatectl.c
src/timesync/timesyncd-server.c
src/tmpfiles/test-offline-passwd.c
src/tmpfiles/tmpfiles.c
src/tty-ask-password-agent/tty-ask-password-agent.c
src/udev/cdrom_id/cdrom_id.c
src/udev/dmi_memory_id/dmi_memory_id.c
src/udev/net/link-config.c
src/udev/scsi_id/scsi_id.c
src/udev/test-udev-event.c
src/udev/udev-event.c
src/udev/udev-rules.c
src/udev/udevadm-control.c
src/udev/udevadm-hwdb.c
src/udev/udevadm-info.c
src/udev/udevadm-monitor.c
src/udev/udevadm-settle.c
src/udev/udevadm-test-builtin.c
src/udev/udevadm-test.c
src/udev/udevadm-trigger.c
src/udev/udevadm.c
src/udev/udevd.c
src/udev/v4l_id/v4l_id.c
src/userdb/userdbctl.c