]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/network/networkd-network.c
network/dhcp: disable RapidCommit= by default when AllowList=/DenyList= is specified 30128/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 21 Nov 2023 20:17:58 +0000 (05:17 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 21 Nov 2023 20:24:18 +0000 (05:24 +0900)
commitcf289b1415026bac43b39f1c8d8a95005ea57ed3
tree9906c5b872b6b868895ada2f162d15c730262be8
parent24bb67ed12e8c94086cb2c0cd61cf7738cfca7cb
network/dhcp: disable RapidCommit= by default when AllowList=/DenyList= is specified

AllowList= and DenyList= filter only DHCPOFFER messages. So, if
RapidCommit= is enabled, then networkd unconditionally accepts a rapid
ACK message even if its sender is filtered out by the lists.

As AllowList=/DenyList= implemented earlier than RapidCommit=, so
enabling RapidCommit= unconditionally by default may break existing
setups that use AllowList=/DenyList=.

Let's disable RapidCommit= by default when AllowList=/DenyList= is
enabled. Still the setting can be enabled by setting explicitly even
AllowList=/DenyList= is also specified.
man/systemd.network.xml
src/network/networkd-dhcp4.c
src/network/networkd-network-gperf.gperf
src/network/networkd-network.c
src/network/networkd-network.h