]> git.ipfire.org Git - thirdparty/systemd.git/commit
core: store timestamps of unit load attempts
authorLuca Boccassi <luca.boccassi@microsoft.com>
Tue, 16 Jun 2020 17:46:55 +0000 (18:46 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 30 Jun 2020 14:50:00 +0000 (16:50 +0200)
commit7233e91af000b539c1724996758528af6d6dcc36
treea62b8ffc410cf0c3afc2a979077b745f3592d134
parentf93dd4b9402bb71fbe6a1ccb6763a1bc46c4177c
core: store timestamps of unit load attempts

When the system is under heavy load, it can happen that the unit cache
is refreshed for an unrelated reason (in the test I simulate this by
attempting to start a non-existing unit). The new unit is found and
accounted for in the cache, but it's ignored since we are loading
something else.
When we actually look for it, by attempting to start it, the cache is
up to date so no refresh happens, and starting fails although we have
it loaded in the cache.

When the unit state is set to UNIT_NOT_FOUND, mark the timestamp in
u->fragment_loadtime. Then when attempting to load again we can check
both if the cache itself needs a refresh, OR if it was refreshed AFTER
the last failed attempt that resulted in the state being
UNIT_NOT_FOUND.

Update the test so that this issue reproduces more often.
src/core/manager.c
src/core/unit.c
src/core/unit.h
test/TEST-48-START-STOP-NO-RELOAD/blacklist-ubuntu-ci [deleted file]
test/units/testsuite-48.sh