]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_scrub_all: fix argument passing when invoking xfs_scrub manually
authorDarrick J. Wong <djwong@kernel.org>
Fri, 12 Jan 2024 02:07:06 +0000 (18:07 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Fri, 12 Jan 2024 02:08:47 +0000 (18:08 -0800)
commit27df677a7b31c51c4595d2ae9078927b790d94b9
tree7a931a185d77399d083262f6d652b9bb4eab0c9e
parent3d37d8bf535fd6a8ab241a86433b449152746e6a
xfs_scrub_all: fix argument passing when invoking xfs_scrub manually

Currently, xfs_scrub_all will try to invoke xfs_scrub with argv[1] being
"-n -x".  This of course is recognized by C getopt as a weird looking
string, not two individual arguments, and causes the child process to
exit with complaints about CLI usage.

What we really want is to split the string into a proper array and then
add them to the xfs_scrub command line.  The code here isn't strictly
correct, but as @scrub_args@ is controlled by us in the Makefile, it'll
do for now.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
scrub/xfs_scrub_all.in