CLEANUP: tcpcheck: Remove useless test on the xprt used for healthchecks

The xprt used to perform a healthcheck is always defined and cannot be NULL.
So there is no reason to test it. It could lead to wrong assumptions later
in the code.

This patch should fix a Coverity report from #3213.

diff --git a/src/tcpcheck.c b/src/tcpcheck.c
index 28cdd94f2629e4381f94eefbe0700061d76c9f74..f307c814ba7c89e354b21e26a1c92f82814464cb 100644 (file)
--- a/src/tcpcheck.c
+++ b/src/tcpcheck.c
@@ -1462,7 +1462,7 @@ enum tcpcheck_eval_ret tcpcheck_eval_connect(struct check *check, struct tcpchec
                : ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) ? check->xprt : xprt_get(XPRT_RAW)));
 
 #ifdef USE_OPENSSL
-       if (xprt && xprt->get_ssl_sock_ctx) {
+       if (xprt->get_ssl_sock_ctx) {
                if (connect->sni)
                        sni = ist(connect->sni);
                else if ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) && s && s->check.sni)