]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: quic: try to clarify quic_conn CIDs fields direction
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 12 Nov 2025 15:58:46 +0000 (16:58 +0100)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Mon, 17 Nov 2025 09:11:04 +0000 (10:11 +0100)
quic_conn has two fields named <dcid> and <scid>. It may cause confusion
as it is not obvious how these fields are related to the connection
direction. Try to improve this by extending the documentation of these
two fields.

include/haproxy/quic_conn-t.h

index 9fe7b69f720a88bfa0d16ad353f5d979036d04d7..84c9b68f792848e965f92268f20089738a3826b4 100644 (file)
@@ -292,9 +292,13 @@ struct qcc_app_ops;
         size_t max_udp_payload;                        \
         /* First DCID used by client on its Initial packet. */                 \
         struct quic_cid odcid;                                                 \
-        /* DCID of our endpoint - not updated when a new DCID is used */       \
+        /* Peer chosen CID, used as dest for packets sent from our endpoint    \
+         * - not updated when a new DCID is used                               \
+         */                                                                    \
         struct quic_cid dcid;                                                  \
-        /* first SCID of our endpoint - not updated when a new SCID is used */ \
+        /* Local CID used to dispatch received datagrams to this endpoint      \
+         * - not updated when a new SCID is used                               \
+         */                                                                    \
         struct quic_cid scid;                                                  \
         /* tree of quic_connection_id - used to match a received packet DCID   \
          * with a connection                                                   \