]>
Commit | Line | Data |
---|---|---|
adcc42e6 JH |
1 | Here are some guidelines for people who want to contribute their code |
2 | to this software. | |
31408251 | 3 | |
d0c26f0f RR |
4 | (0) Decide what to base your work on. |
5 | ||
6 | In general, always base your work on the oldest branch that your | |
7 | change is relevant to. | |
8 | ||
9 | - A bugfix should be based on 'maint' in general. If the bug is not | |
10 | present in 'maint', base it on 'master'. For a bug that's not yet | |
11 | in 'master', find the topic that introduces the regression, and | |
12 | base your work on the tip of the topic. | |
13 | ||
14 | - A new feature should be based on 'master' in general. If the new | |
15 | feature depends on a topic that is in 'pu', but not in 'master', | |
16 | base your work on the tip of that topic. | |
17 | ||
18 | - Corrections and enhancements to a topic not yet in 'master' should | |
19 | be based on the tip of that topic. If the topic has not been merged | |
20 | to 'next', it's alright to add a note to squash minor corrections | |
21 | into the series. | |
22 | ||
23 | - In the exceptional case that a new feature depends on several topics | |
24 | not in 'master', start working on 'next' or 'pu' privately and send | |
25 | out patches for discussion. Before the final merge, you may have to | |
26 | wait until some of the dependent topics graduate to 'master', and | |
27 | rebase your work. | |
28 | ||
e6da8ee8 JH |
29 | - Some parts of the system have dedicated maintainers with their own |
30 | repositories (see the section "Subsystems" below). Changes to | |
31 | these parts should be based on their trees. | |
32 | ||
d0c26f0f RR |
33 | To find the tip of a topic branch, run "git log --first-parent |
34 | master..pu" and look for the merge commit. The second parent of this | |
35 | commit is the tip of the topic branch. | |
31408251 JH |
36 | |
37 | (1) Make separate commits for logically separate changes. | |
38 | ||
39 | Unless your patch is really trivial, you should not be sending | |
40 | out a patch that was generated between your working tree and | |
41 | your commit head. Instead, always make a commit with complete | |
42 | commit message and generate a series of patches from your | |
43 | repository. It is a good discipline. | |
44 | ||
d0f7dcbf JH |
45 | Give an explanation for the change(s) that is detailed enough so |
46 | that people can judge if it is good thing to do, without reading | |
47 | the actual patch text to determine how well the code does what | |
48 | the explanation promises to do. | |
31408251 | 49 | |
45d2b286 | 50 | If your description starts to get too long, that's a sign that you |
31408251 | 51 | probably need to split up your commit to finer grained pieces. |
47afed5d SV |
52 | That being said, patches which plainly describe the things that |
53 | help reviewers check the patch, and future maintainers understand | |
54 | the code, are the most beautiful patches. Descriptions that summarise | |
55 | the point in the subject well, and describe the motivation for the | |
56 | change, the approach taken by the change, and if relevant how this | |
d0f7dcbf JH |
57 | differs substantially from the prior version, are all good things |
58 | to have. | |
31408251 | 59 | |
54cc5d29 JH |
60 | Make sure that you have tests for the bug you are fixing. See |
61 | t/README for guidance. | |
7d5bf87b JH |
62 | |
63 | When adding a new feature, make sure that you have new tests to show | |
0e5d028a LS |
64 | the feature triggers the new behavior when it should, and to show the |
65 | feature does not trigger when it shouldn't. After any code change, make | |
66 | sure that the entire test suite passes. | |
67 | ||
68 | If you have an account at GitHub (and you can get one for free to work | |
69 | on open source projects), you can use their Travis CI integration to | |
70 | test your changes on Linux, Mac (and hopefully soon Windows). See | |
71 | GitHub-Travis CI hints section for details. | |
72 | ||
73 | Do not forget to update the documentation to describe the updated | |
74 | behavior and make sure that the resulting documentation set formats | |
75 | well. It is currently a liberal mixture of US and UK English norms for | |
76 | spelling and grammar, which is somewhat unfortunate. A huge patch that | |
77 | touches the files all over the place only to correct the inconsistency | |
78 | is not welcome, though. Potential clashes with other changes that can | |
79 | result from such a patch are not worth it. We prefer to gradually | |
80 | reconcile the inconsistencies in favor of US English, with small and | |
81 | easily digestible patches, as a side effect of doing some other real | |
82 | work in the vicinity (e.g. rewriting a paragraph for clarity, while | |
83 | turning en_UK spelling to en_US). Obvious typographical fixes are much | |
84 | more welcomed ("teh -> "the"), preferably submitted as independent | |
85 | patches separate from other documentation changes. | |
42e0fae9 MB |
86 | |
87 | Oh, another thing. We are picky about whitespaces. Make sure your | |
45d2b286 | 88 | changes do not trigger errors with the sample pre-commit hook shipped |
16507fcf BL |
89 | in templates/hooks--pre-commit. To help ensure this does not happen, |
90 | run git diff --check on your changes before you commit. | |
31408251 | 91 | |
31408251 | 92 | |
7d5bf87b JH |
93 | (2) Describe your changes well. |
94 | ||
95 | The first line of the commit message should be a short description (50 | |
96 | characters is the soft limit, see DISCUSSION in git-commit(1)), and | |
97 | should skip the full stop. It is also conventional in most cases to | |
98 | prefix the first line with "area: " where the area is a filename or | |
99 | identifier for the general area of the code being modified, e.g. | |
100 | ||
101 | . archive: ustar header checksum is computed unsigned | |
102 | . git-cherry-pick.txt: clarify the use of revision range notation | |
103 | ||
104 | If in doubt which identifier to use, run "git log --no-merges" on the | |
105 | files you are modifying to see the current conventions. | |
106 | ||
107 | The body should provide a meaningful commit message, which: | |
108 | ||
109 | . explains the problem the change tries to solve, iow, what is wrong | |
110 | with the current code without the change. | |
111 | ||
112 | . justifies the way the change solves the problem, iow, why the | |
113 | result with the change is better. | |
114 | ||
115 | . alternate solutions considered but discarded, if any. | |
116 | ||
117 | Describe your changes in imperative mood, e.g. "make xyzzy do frotz" | |
118 | instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy | |
119 | to do frotz", as if you are giving orders to the codebase to change | |
120 | its behaviour. Try to make sure your explanation can be understood | |
121 | without external resources. Instead of giving a URL to a mailing list | |
122 | archive, summarize the relevant points of the discussion. | |
123 | ||
175d38ca | 124 | If you want to reference a previous commit in the history of a stable |
4369523b BB |
125 | branch, use the format "abbreviated sha1 (subject, date)", |
126 | with the subject enclosed in a pair of double-quotes, like this: | |
127 | ||
128 | Commit f86a374 ("pack-bitmap.c: fix a memleak", 2015-03-30) | |
129 | noticed that ... | |
130 | ||
131 | The "Copy commit summary" command of gitk can be used to obtain this | |
132 | format. | |
175d38ca | 133 | |
7d5bf87b | 134 | |
2de9b711 | 135 | (3) Generate your patch using Git tools out of your commits. |
45d2b286 | 136 | |
2de9b711 | 137 | Git based diff tools generate unidiff which is the preferred format. |
45d2b286 | 138 | |
31408251 JH |
139 | You do not have to be afraid to use -M option to "git diff" or |
140 | "git format-patch", if your patch involves file renames. The | |
141 | receiving end can handle them just fine. | |
142 | ||
7d5bf87b JH |
143 | Please make sure your patch does not add commented out debugging code, |
144 | or include any extra files which do not relate to what your patch | |
145 | is trying to achieve. Make sure to review | |
31408251 JH |
146 | your patch after generating it, to ensure accuracy. Before |
147 | sending out, please make sure it cleanly applies to the "master" | |
45d2b286 JH |
148 | branch head. If you are preparing a work based on "next" branch, |
149 | that is fine, but please mark it as such. | |
31408251 JH |
150 | |
151 | ||
7d5bf87b | 152 | (4) Sending your patches. |
31408251 | 153 | |
b25c4699 JH |
154 | Learn to use format-patch and send-email if possible. These commands |
155 | are optimized for the workflow of sending patches, avoiding many ways | |
156 | your existing e-mail client that is optimized for "multipart/*" mime | |
157 | type e-mails to corrupt and render your patches unusable. | |
158 | ||
2de9b711 | 159 | People on the Git mailing list need to be able to read and |
31408251 JH |
160 | comment on the changes you are submitting. It is important for |
161 | a developer to be able to "quote" your changes, using standard | |
162 | e-mail tools, so that they may comment on specific portions of | |
eaa6c987 RS |
163 | your code. For this reason, each patch should be submitted |
164 | "inline" in a separate message. | |
165 | ||
166 | Multiple related patches should be grouped into their own e-mail | |
167 | thread to help readers find all parts of the series. To that end, | |
168 | send them as replies to either an additional "cover letter" message | |
169 | (see below), the first patch, or the respective preceding patch. | |
170 | ||
171 | If your log message (including your name on the | |
7d5bf87b JH |
172 | Signed-off-by line) is not writable in ASCII, make sure that |
173 | you send off a message in the correct encoding. | |
174 | ||
175 | WARNING: Be wary of your MUAs word-wrap | |
45d2b286 JH |
176 | corrupting your patch. Do not cut-n-paste your patch; you can |
177 | lose tabs that way if you are not careful. | |
31408251 | 178 | |
45d2b286 | 179 | It is a common convention to prefix your subject line with |
31408251 | 180 | [PATCH]. This lets people easily distinguish patches from other |
4e891acf JH |
181 | e-mail discussions. Use of additional markers after PATCH and |
182 | the closing bracket to mark the nature of the patch is also | |
183 | encouraged. E.g. [PATCH/RFC] is often used when the patch is | |
184 | not ready to be applied but it is for discussion, [PATCH v2], | |
185 | [PATCH v3] etc. are often seen when you are sending an update to | |
186 | what you have previously sent. | |
31408251 JH |
187 | |
188 | "git format-patch" command follows the best current practice to | |
189 | format the body of an e-mail message. At the beginning of the | |
190 | patch should come your commit message, ending with the | |
191 | Signed-off-by: lines, and a line that consists of three dashes, | |
192 | followed by the diffstat information and the patch itself. If | |
193 | you are forwarding a patch from somebody else, optionally, at | |
194 | the beginning of the e-mail message just before the commit | |
195 | message starts, you can put a "From: " line to name that person. | |
196 | ||
197 | You often want to add additional explanation about the patch, | |
198 | other than the commit message itself. Place such "cover letter" | |
86010993 ES |
199 | material between the three-dash line and the diffstat. For |
200 | patches requiring multiple iterations of review and discussion, | |
201 | an explanation of changes between each iteration can be kept in | |
202 | Git-notes and inserted automatically following the three-dash | |
203 | line via `git format-patch --notes`. | |
31408251 JH |
204 | |
205 | Do not attach the patch as a MIME attachment, compressed or not. | |
e30b217b JH |
206 | Do not let your e-mail client send quoted-printable. Do not let |
207 | your e-mail client send format=flowed which would destroy | |
208 | whitespaces in your patches. Many | |
31408251 JH |
209 | popular e-mail applications will not always transmit a MIME |
210 | attachment as plain text, making it impossible to comment on | |
211 | your code. A MIME attachment also takes a bit more time to | |
212 | process. This does not decrease the likelihood of your | |
213 | MIME-attached change being accepted, but it makes it more likely | |
214 | that it will be postponed. | |
215 | ||
216 | Exception: If your mailer is mangling patches then someone may ask | |
9847f7e0 | 217 | you to re-send them using MIME, that is OK. |
31408251 | 218 | |
9847f7e0 JH |
219 | Do not PGP sign your patch, at least for now. Most likely, your |
220 | maintainer or other people on the list would not have your PGP | |
221 | key and would not bother obtaining it anyway. Your patch is not | |
222 | judged by who you are; a good patch from an unknown origin has a | |
223 | far better chance of being accepted than a patch from a known, | |
224 | respected origin that is done poorly or does incorrect things. | |
225 | ||
226 | If you really really really really want to do a PGP signed | |
227 | patch, format it as "multipart/signed", not a text/plain message | |
228 | that starts with '-----BEGIN PGP SIGNED MESSAGE-----'. That is | |
229 | not a text/plain, it's something else. | |
230 | ||
7d5bf87b | 231 | Send your patch with "To:" set to the mailing list, with "cc:" listing |
d0c26f0f RR |
232 | people who are involved in the area you are touching (the output from |
233 | "git blame $path" and "git shortlog --no-merges $path" would help to | |
7d5bf87b | 234 | identify them), to solicit comments and reviews. |
04d24455 | 235 | |
7d5bf87b | 236 | After the list reached a consensus that it is a good idea to apply the |
92a865e7 JH |
237 | patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the |
238 | list [*2*] for inclusion. | |
31408251 | 239 | |
7d5bf87b JH |
240 | Do not forget to add trailers such as "Acked-by:", "Reviewed-by:" and |
241 | "Tested-by:" lines as necessary to credit people who helped your | |
242 | patch. | |
04d24455 | 243 | |
92a865e7 JH |
244 | [Addresses] |
245 | *1* The current maintainer: gitster@pobox.com | |
246 | *2* The mailing list: git@vger.kernel.org | |
247 | ||
31408251 | 248 | |
7d5bf87b | 249 | (5) Sign your work |
31408251 JH |
250 | |
251 | To improve tracking of who did what, we've borrowed the | |
252 | "sign-off" procedure from the Linux kernel project on patches | |
48a8c26c | 253 | that are being emailed around. Although core Git is a lot |
31408251 JH |
254 | smaller project it is a good discipline to follow it. |
255 | ||
256 | The sign-off is a simple line at the end of the explanation for | |
257 | the patch, which certifies that you wrote it or otherwise have | |
258 | the right to pass it on as a open-source patch. The rules are | |
259 | pretty simple: if you can certify the below: | |
260 | ||
261 | Developer's Certificate of Origin 1.1 | |
262 | ||
263 | By making a contribution to this project, I certify that: | |
264 | ||
265 | (a) The contribution was created in whole or in part by me and I | |
266 | have the right to submit it under the open source license | |
267 | indicated in the file; or | |
268 | ||
269 | (b) The contribution is based upon previous work that, to the best | |
270 | of my knowledge, is covered under an appropriate open source | |
271 | license and I have the right under that license to submit that | |
272 | work with modifications, whether created in whole or in part | |
273 | by me, under the same open source license (unless I am | |
274 | permitted to submit under a different license), as indicated | |
275 | in the file; or | |
276 | ||
277 | (c) The contribution was provided directly to me by some other | |
278 | person who certified (a), (b) or (c) and I have not modified | |
279 | it. | |
280 | ||
c376d968 SB |
281 | (d) I understand and agree that this project and the contribution |
282 | are public and that a record of the contribution (including all | |
283 | personal information I submit with it, including my sign-off) is | |
284 | maintained indefinitely and may be redistributed consistent with | |
285 | this project or the open source license(s) involved. | |
31408251 JH |
286 | |
287 | then you just add a line saying | |
288 | ||
c376d968 | 289 | Signed-off-by: Random J Developer <random@developer.example.org> |
31408251 | 290 | |
2de9b711 | 291 | This line can be automatically added by Git if you run the git-commit |
69945602 PC |
292 | command with the -s option. |
293 | ||
c11c3b56 JH |
294 | Notice that you can place your own Signed-off-by: line when |
295 | forwarding somebody else's patch with the above rules for | |
296 | D-C-O. Indeed you are encouraged to do so. Do not forget to | |
297 | place an in-body "From: " line at the beginning to properly attribute | |
298 | the change to its true author (see (2) above). | |
299 | ||
67275247 MV |
300 | Also notice that a real name is used in the Signed-off-by: line. Please |
301 | don't hide your real name. | |
302 | ||
95b7a41a RR |
303 | If you like, you can put extra tags at the end: |
304 | ||
0353a0c4 | 305 | 1. "Reported-by:" is used to credit someone who found the bug that |
95b7a41a RR |
306 | the patch attempts to fix. |
307 | 2. "Acked-by:" says that the person who is more familiar with the area | |
308 | the patch attempts to modify liked the patch. | |
309 | 3. "Reviewed-by:", unlike the other tags, can only be offered by the | |
310 | reviewer and means that she is completely satisfied that the patch | |
311 | is ready for application. It is usually offered only after a | |
312 | detailed review. | |
313 | 4. "Tested-by:" is used to indicate that the person applied the patch | |
314 | and found it to have the desired effect. | |
315 | ||
316 | You can also create your own tag or use one that's in common usage | |
317 | such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". | |
9740d289 | 318 | |
e6da8ee8 JH |
319 | ------------------------------------------------ |
320 | Subsystems with dedicated maintainers | |
321 | ||
322 | Some parts of the system have dedicated maintainers with their own | |
323 | repositories. | |
324 | ||
325 | - git-gui/ comes from git-gui project, maintained by Pat Thoyts: | |
326 | ||
327 | git://repo.or.cz/git-gui.git | |
328 | ||
329 | - gitk-git/ comes from Paul Mackerras's gitk project: | |
330 | ||
331 | git://ozlabs.org/~paulus/gitk | |
332 | ||
333 | - po/ comes from the localization coordinator, Jiang Xin: | |
334 | ||
335 | https://github.com/git-l10n/git-po/ | |
336 | ||
337 | Patches to these parts should be based on their trees. | |
338 | ||
a941fb4a JH |
339 | ------------------------------------------------ |
340 | An ideal patch flow | |
341 | ||
342 | Here is an ideal patch flow for this project the current maintainer | |
343 | suggests to the contributors: | |
344 | ||
345 | (0) You come up with an itch. You code it up. | |
346 | ||
347 | (1) Send it to the list and cc people who may need to know about | |
348 | the change. | |
349 | ||
350 | The people who may need to know are the ones whose code you | |
351 | are butchering. These people happen to be the ones who are | |
352 | most likely to be knowledgeable enough to help you, but | |
353 | they have no obligation to help you (i.e. you ask for help, | |
354 | don't demand). "git log -p -- $area_you_are_modifying" would | |
355 | help you find out who they are. | |
356 | ||
357 | (2) You get comments and suggestions for improvements. You may | |
358 | even get them in a "on top of your change" patch form. | |
359 | ||
360 | (3) Polish, refine, and re-send to the list and the people who | |
361 | spend their time to improve your patch. Go back to step (2). | |
362 | ||
363 | (4) The list forms consensus that the last round of your patch is | |
faa8fac1 | 364 | good. Send it to the maintainer and cc the list. |
a941fb4a JH |
365 | |
366 | (5) A topic branch is created with the patch and is merged to 'next', | |
367 | and cooked further and eventually graduates to 'master'. | |
368 | ||
369 | In any time between the (2)-(3) cycle, the maintainer may pick it up | |
370 | from the list and queue it to 'pu', in order to make it easier for | |
371 | people play with it without having to pick up and apply the patch to | |
372 | their trees themselves. | |
373 | ||
63cb8215 MM |
374 | ------------------------------------------------ |
375 | Know the status of your patch after submission | |
376 | ||
377 | * You can use Git itself to find out when your patch is merged in | |
378 | master. 'git pull --rebase' will automatically skip already-applied | |
379 | patches, and will let you know. This works only if you rebase on top | |
380 | of the branch in which your patch has been merged (i.e. it will not | |
381 | tell you if your patch is merged in pu if you rebase on top of | |
382 | master). | |
383 | ||
2de9b711 | 384 | * Read the Git mailing list, the maintainer regularly posts messages |
63cb8215 MM |
385 | entitled "What's cooking in git.git" and "What's in git.git" giving |
386 | the status of various proposed changes. | |
387 | ||
0e5d028a LS |
388 | -------------------------------------------------- |
389 | GitHub-Travis CI hints | |
390 | ||
391 | With an account at GitHub (you can get one for free to work on open | |
392 | source projects), you can use Travis CI to test your changes on Linux, | |
393 | Mac (and hopefully soon Windows). You can find a successful example | |
394 | test build here: https://travis-ci.org/git/git/builds/120473209 | |
395 | ||
396 | Follow these steps for the initial setup: | |
397 | ||
398 | (1) Fork https://github.com/git/git to your GitHub account. | |
399 | You can find detailed instructions how to fork here: | |
400 | https://help.github.com/articles/fork-a-repo/ | |
401 | ||
402 | (2) Open the Travis CI website: https://travis-ci.org | |
403 | ||
404 | (3) Press the "Sign in with GitHub" button. | |
405 | ||
406 | (4) Grant Travis CI permissions to access your GitHub account. | |
407 | You can find more information about the required permissions here: | |
408 | https://docs.travis-ci.com/user/github-oauth-scopes | |
409 | ||
410 | (5) Open your Travis CI profile page: https://travis-ci.org/profile | |
411 | ||
412 | (6) Enable Travis CI builds for your Git fork. | |
413 | ||
414 | After the initial setup, Travis CI will run whenever you push new changes | |
415 | to your fork of Git on GitHub. You can monitor the test state of all your | |
416 | branches here: https://travis-ci.org/<Your GitHub handle>/git/branches | |
417 | ||
418 | If a branch did not pass all test cases then it is marked with a red | |
419 | cross. In that case you can click on the failing Travis CI job and | |
420 | scroll all the way down in the log. Find the line "<-- Click here to see | |
421 | detailed test output!" and click on the triangle next to the log line | |
422 | number to expand the detailed test output. Here is such a failing | |
423 | example: https://travis-ci.org/git/git/jobs/122676187 | |
424 | ||
425 | Fix the problem and push your fix to your Git fork. This will trigger | |
426 | a new Travis CI build to ensure all tests pass. | |
427 | ||
428 | ||
9740d289 JH |
429 | ------------------------------------------------ |
430 | MUA specific hints | |
431 | ||
432 | Some of patches I receive or pick up from the list share common | |
433 | patterns of breakage. Please make sure your MUA is set up | |
57756161 JN |
434 | properly not to corrupt whitespaces. |
435 | ||
436 | See the DISCUSSION section of git-format-patch(1) for hints on | |
437 | checking your patch by mailing it to yourself and applying with | |
438 | git-am(1). | |
439 | ||
440 | While you are at it, check the resulting commit log message from | |
441 | a trial run of applying the patch. If what is in the resulting | |
442 | commit is not exactly what you would want to see, it is very | |
443 | likely that your maintainer would end up hand editing the log | |
444 | message when he applies your patch. Things like "Hi, this is my | |
445 | first patch.\n", if you really want to put in the patch e-mail, | |
446 | should come after the three-dash line that signals the end of the | |
447 | commit message. | |
9847f7e0 | 448 | |
9740d289 JH |
449 | |
450 | Pine | |
451 | ---- | |
452 | ||
453 | (Johannes Schindelin) | |
454 | ||
455 | I don't know how many people still use pine, but for those poor | |
456 | souls it may be good to mention that the quell-flowed-text is | |
457 | needed for recent versions. | |
458 | ||
459 | ... the "no-strip-whitespace-before-send" option, too. AFAIK it | |
460 | was introduced in 4.60. | |
461 | ||
462 | (Linus Torvalds) | |
463 | ||
464 | And 4.58 needs at least this. | |
465 | ||
466 | --- | |
467 | diff-tree 8326dd8350be64ac7fc805f6563a1d61ad10d32c (from e886a61f76edf5410573e92e38ce22974f9c40f1) | |
468 | Author: Linus Torvalds <torvalds@g5.osdl.org> | |
469 | Date: Mon Aug 15 17:23:51 2005 -0700 | |
470 | ||
471 | Fix pine whitespace-corruption bug | |
472 | ||
473 | There's no excuse for unconditionally removing whitespace from | |
474 | the pico buffers on close. | |
475 | ||
476 | diff --git a/pico/pico.c b/pico/pico.c | |
477 | --- a/pico/pico.c | |
478 | +++ b/pico/pico.c | |
479 | @@ -219,7 +219,9 @@ PICO *pm; | |
a6080a0a JH |
480 | switch(pico_all_done){ /* prepare for/handle final events */ |
481 | case COMP_EXIT : /* already confirmed */ | |
482 | packheader(); | |
9740d289 | 483 | +#if 0 |
a6080a0a | 484 | stripwhitespace(); |
9740d289 | 485 | +#endif |
a6080a0a JH |
486 | c |= COMP_EXIT; |
487 | break; | |
488 | ||
9740d289 | 489 | |
1eb446fa JH |
490 | (Daniel Barkalow) |
491 | ||
492 | > A patch to SubmittingPatches, MUA specific help section for | |
493 | > users of Pine 4.63 would be very much appreciated. | |
494 | ||
495 | Ah, it looks like a recent version changed the default behavior to do the | |
496 | right thing, and inverted the sense of the configuration option. (Either | |
497 | that or Gentoo did it.) So you need to set the | |
498 | "no-strip-whitespace-before-send" option, unless the option you have is | |
499 | "strip-whitespace-before-send", in which case you should avoid checking | |
500 | it. | |
501 | ||
9740d289 | 502 | |
36c10e6d JN |
503 | Thunderbird, KMail, GMail |
504 | ------------------------- | |
9740d289 | 505 | |
dc53151f | 506 | See the MUA-SPECIFIC HINTS section of git-format-patch(1). |
e30b217b | 507 | |
e30b217b JH |
508 | Gnus |
509 | ---- | |
510 | ||
511 | '|' in the *Summary* buffer can be used to pipe the current | |
512 | message to an external program, and this is a handy way to drive | |
513 | "git am". However, if the message is MIME encoded, what is | |
514 | piped into the program is the representation you see in your | |
515 | *Article* buffer after unwrapping MIME. This is often not what | |
516 | you would want for two reasons. It tends to screw up non ASCII | |
517 | characters (most notably in people's names), and also | |
518 | whitespaces (fatal in patches). Running 'C-u g' to display the | |
519 | message in raw form before using '|' to run the pipe can work | |
520 | this problem around. |