]>
Commit | Line | Data |
---|---|---|
a2ad79ce | 1 | #include "cache.h" |
b2141fc1 | 2 | #include "config.h" |
a2ad79ce CC |
3 | #include "commit.h" |
4 | #include "diff.h" | |
5 | #include "revision.h" | |
1bf072e3 CC |
6 | #include "refs.h" |
7 | #include "list-objects.h" | |
3b437b0d | 8 | #include "quote.h" |
4eb5b646 | 9 | #include "sha1-lookup.h" |
ef24c7ca | 10 | #include "run-command.h" |
e22278c0 | 11 | #include "log-tree.h" |
a2ad79ce | 12 | #include "bisect.h" |
902bb364 | 13 | #include "sha1-array.h" |
8a534b61 | 14 | #include "argv-array.h" |
6212b1aa | 15 | |
910650d2 | 16 | static struct oid_array good_revs; |
17 | static struct oid_array skipped_revs; | |
1bf072e3 | 18 | |
3c5ff995 | 19 | static struct object_id *current_bad_oid; |
ef24c7ca | 20 | |
ef24c7ca CC |
21 | static const char *argv_checkout[] = {"checkout", "-q", NULL, "--", NULL}; |
22 | static const char *argv_show_branch[] = {"show-branch", NULL, NULL}; | |
23 | ||
43f9d9f3 AD |
24 | static const char *term_bad; |
25 | static const char *term_good; | |
26 | ||
208acbfb | 27 | /* Remember to update object flag allocation in object.h */ |
a2ad79ce CC |
28 | #define COUNTED (1u<<16) |
29 | ||
30 | /* | |
31 | * This is a truly stupid algorithm, but it's only | |
32 | * used for bisection, and we just don't care enough. | |
33 | * | |
34 | * We care just barely enough to avoid recursing for | |
35 | * non-merge entries. | |
36 | */ | |
37 | static int count_distance(struct commit_list *entry) | |
38 | { | |
39 | int nr = 0; | |
40 | ||
41 | while (entry) { | |
42 | struct commit *commit = entry->item; | |
43 | struct commit_list *p; | |
44 | ||
45 | if (commit->object.flags & (UNINTERESTING | COUNTED)) | |
46 | break; | |
47 | if (!(commit->object.flags & TREESAME)) | |
48 | nr++; | |
49 | commit->object.flags |= COUNTED; | |
50 | p = commit->parents; | |
51 | entry = p; | |
52 | if (p) { | |
53 | p = p->next; | |
54 | while (p) { | |
55 | nr += count_distance(p); | |
56 | p = p->next; | |
57 | } | |
58 | } | |
59 | } | |
60 | ||
61 | return nr; | |
62 | } | |
63 | ||
64 | static void clear_distance(struct commit_list *list) | |
65 | { | |
66 | while (list) { | |
67 | struct commit *commit = list->item; | |
68 | commit->object.flags &= ~COUNTED; | |
69 | list = list->next; | |
70 | } | |
71 | } | |
72 | ||
73 | #define DEBUG_BISECT 0 | |
74 | ||
75 | static inline int weight(struct commit_list *elem) | |
76 | { | |
77 | return *((int*)(elem->item->util)); | |
78 | } | |
79 | ||
80 | static inline void weight_set(struct commit_list *elem, int weight) | |
81 | { | |
82 | *((int*)(elem->item->util)) = weight; | |
83 | } | |
84 | ||
85 | static int count_interesting_parents(struct commit *commit) | |
86 | { | |
87 | struct commit_list *p; | |
88 | int count; | |
89 | ||
90 | for (count = 0, p = commit->parents; p; p = p->next) { | |
91 | if (p->item->object.flags & UNINTERESTING) | |
92 | continue; | |
93 | count++; | |
94 | } | |
95 | return count; | |
96 | } | |
97 | ||
98 | static inline int halfway(struct commit_list *p, int nr) | |
99 | { | |
100 | /* | |
101 | * Don't short-cut something we are not going to return! | |
102 | */ | |
103 | if (p->item->object.flags & TREESAME) | |
104 | return 0; | |
105 | if (DEBUG_BISECT) | |
106 | return 0; | |
107 | /* | |
108 | * 2 and 3 are halfway of 5. | |
109 | * 3 is halfway of 6 but 2 and 4 are not. | |
110 | */ | |
111 | switch (2 * weight(p) - nr) { | |
112 | case -1: case 0: case 1: | |
113 | return 1; | |
114 | default: | |
115 | return 0; | |
116 | } | |
117 | } | |
118 | ||
119 | #if !DEBUG_BISECT | |
120 | #define show_list(a,b,c,d) do { ; } while (0) | |
121 | #else | |
122 | static void show_list(const char *debug, int counted, int nr, | |
123 | struct commit_list *list) | |
124 | { | |
125 | struct commit_list *p; | |
126 | ||
127 | fprintf(stderr, "%s (%d/%d)\n", debug, counted, nr); | |
128 | ||
129 | for (p = list; p; p = p->next) { | |
130 | struct commit_list *pp; | |
131 | struct commit *commit = p->item; | |
132 | unsigned flags = commit->object.flags; | |
133 | enum object_type type; | |
134 | unsigned long size; | |
135 | char *buf = read_sha1_file(commit->object.sha1, &type, &size); | |
56ff3794 CC |
136 | const char *subject_start; |
137 | int subject_len; | |
a2ad79ce CC |
138 | |
139 | fprintf(stderr, "%c%c%c ", | |
140 | (flags & TREESAME) ? ' ' : 'T', | |
141 | (flags & UNINTERESTING) ? 'U' : ' ', | |
142 | (flags & COUNTED) ? 'C' : ' '); | |
143 | if (commit->util) | |
144 | fprintf(stderr, "%3d", weight(p)); | |
145 | else | |
146 | fprintf(stderr, "---"); | |
147 | fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.sha1)); | |
148 | for (pp = commit->parents; pp; pp = pp->next) | |
149 | fprintf(stderr, " %.*s", 8, | |
150 | sha1_to_hex(pp->item->object.sha1)); | |
151 | ||
56ff3794 CC |
152 | subject_len = find_commit_subject(buf, &subject_start); |
153 | if (subject_len) | |
154 | fprintf(stderr, " %.*s", subject_len, subject_start); | |
a2ad79ce CC |
155 | fprintf(stderr, "\n"); |
156 | } | |
157 | } | |
158 | #endif /* DEBUG_BISECT */ | |
159 | ||
160 | static struct commit_list *best_bisection(struct commit_list *list, int nr) | |
161 | { | |
162 | struct commit_list *p, *best; | |
163 | int best_distance = -1; | |
164 | ||
165 | best = list; | |
166 | for (p = list; p; p = p->next) { | |
167 | int distance; | |
168 | unsigned flags = p->item->object.flags; | |
169 | ||
170 | if (flags & TREESAME) | |
171 | continue; | |
172 | distance = weight(p); | |
173 | if (nr - distance < distance) | |
174 | distance = nr - distance; | |
175 | if (distance > best_distance) { | |
176 | best = p; | |
177 | best_distance = distance; | |
178 | } | |
179 | } | |
180 | ||
181 | return best; | |
182 | } | |
183 | ||
184 | struct commit_dist { | |
185 | struct commit *commit; | |
186 | int distance; | |
187 | }; | |
188 | ||
189 | static int compare_commit_dist(const void *a_, const void *b_) | |
190 | { | |
191 | struct commit_dist *a, *b; | |
192 | ||
193 | a = (struct commit_dist *)a_; | |
194 | b = (struct commit_dist *)b_; | |
195 | if (a->distance != b->distance) | |
196 | return b->distance - a->distance; /* desc sort */ | |
f2fd0760 | 197 | return oidcmp(&a->commit->object.oid, &b->commit->object.oid); |
a2ad79ce CC |
198 | } |
199 | ||
200 | static struct commit_list *best_bisection_sorted(struct commit_list *list, int nr) | |
201 | { | |
202 | struct commit_list *p; | |
203 | struct commit_dist *array = xcalloc(nr, sizeof(*array)); | |
5b1ef2ce | 204 | struct strbuf buf = STRBUF_INIT; |
a2ad79ce CC |
205 | int cnt, i; |
206 | ||
207 | for (p = list, cnt = 0; p; p = p->next) { | |
208 | int distance; | |
209 | unsigned flags = p->item->object.flags; | |
210 | ||
211 | if (flags & TREESAME) | |
212 | continue; | |
213 | distance = weight(p); | |
214 | if (nr - distance < distance) | |
215 | distance = nr - distance; | |
216 | array[cnt].commit = p->item; | |
217 | array[cnt].distance = distance; | |
218 | cnt++; | |
219 | } | |
9ed0d8d6 | 220 | QSORT(array, cnt, compare_commit_dist); |
a2ad79ce | 221 | for (p = list, i = 0; i < cnt; i++) { |
a2ad79ce CC |
222 | struct object *obj = &(array[i].commit->object); |
223 | ||
5b1ef2ce JK |
224 | strbuf_reset(&buf); |
225 | strbuf_addf(&buf, "dist=%d", array[i].distance); | |
226 | add_name_decoration(DECORATION_NONE, buf.buf, obj); | |
662174d2 | 227 | |
a2ad79ce | 228 | p->item = array[i].commit; |
7c117184 MÅ |
229 | if (i < cnt - 1) |
230 | p = p->next; | |
a2ad79ce | 231 | } |
2e9fdc79 ÆAB |
232 | if (p) { |
233 | free_commit_list(p->next); | |
234 | p->next = NULL; | |
235 | } | |
5b1ef2ce | 236 | strbuf_release(&buf); |
a2ad79ce CC |
237 | free(array); |
238 | return list; | |
239 | } | |
240 | ||
241 | /* | |
242 | * zero or positive weight is the number of interesting commits it can | |
243 | * reach, including itself. Especially, weight = 0 means it does not | |
244 | * reach any tree-changing commits (e.g. just above uninteresting one | |
245 | * but traversal is with pathspec). | |
246 | * | |
247 | * weight = -1 means it has one parent and its distance is yet to | |
248 | * be computed. | |
249 | * | |
250 | * weight = -2 means it has more than one parent and its distance is | |
251 | * unknown. After running count_distance() first, they will get zero | |
252 | * or positive distance. | |
253 | */ | |
254 | static struct commit_list *do_find_bisection(struct commit_list *list, | |
255 | int nr, int *weights, | |
256 | int find_all) | |
257 | { | |
258 | int n, counted; | |
259 | struct commit_list *p; | |
260 | ||
261 | counted = 0; | |
262 | ||
263 | for (n = 0, p = list; p; p = p->next) { | |
264 | struct commit *commit = p->item; | |
265 | unsigned flags = commit->object.flags; | |
266 | ||
267 | p->item->util = &weights[n++]; | |
268 | switch (count_interesting_parents(commit)) { | |
269 | case 0: | |
270 | if (!(flags & TREESAME)) { | |
271 | weight_set(p, 1); | |
272 | counted++; | |
273 | show_list("bisection 2 count one", | |
274 | counted, nr, list); | |
275 | } | |
276 | /* | |
277 | * otherwise, it is known not to reach any | |
278 | * tree-changing commit and gets weight 0. | |
279 | */ | |
280 | break; | |
281 | case 1: | |
282 | weight_set(p, -1); | |
283 | break; | |
284 | default: | |
285 | weight_set(p, -2); | |
286 | break; | |
287 | } | |
288 | } | |
289 | ||
290 | show_list("bisection 2 initialize", counted, nr, list); | |
291 | ||
292 | /* | |
293 | * If you have only one parent in the resulting set | |
294 | * then you can reach one commit more than that parent | |
295 | * can reach. So we do not have to run the expensive | |
296 | * count_distance() for single strand of pearls. | |
297 | * | |
298 | * However, if you have more than one parents, you cannot | |
299 | * just add their distance and one for yourself, since | |
300 | * they usually reach the same ancestor and you would | |
301 | * end up counting them twice that way. | |
302 | * | |
303 | * So we will first count distance of merges the usual | |
304 | * way, and then fill the blanks using cheaper algorithm. | |
305 | */ | |
306 | for (p = list; p; p = p->next) { | |
307 | if (p->item->object.flags & UNINTERESTING) | |
308 | continue; | |
309 | if (weight(p) != -2) | |
310 | continue; | |
311 | weight_set(p, count_distance(p)); | |
312 | clear_distance(list); | |
313 | ||
314 | /* Does it happen to be at exactly half-way? */ | |
315 | if (!find_all && halfway(p, nr)) | |
316 | return p; | |
317 | counted++; | |
318 | } | |
319 | ||
320 | show_list("bisection 2 count_distance", counted, nr, list); | |
321 | ||
322 | while (counted < nr) { | |
323 | for (p = list; p; p = p->next) { | |
324 | struct commit_list *q; | |
325 | unsigned flags = p->item->object.flags; | |
326 | ||
327 | if (0 <= weight(p)) | |
328 | continue; | |
329 | for (q = p->item->parents; q; q = q->next) { | |
330 | if (q->item->object.flags & UNINTERESTING) | |
331 | continue; | |
332 | if (0 <= weight(q)) | |
333 | break; | |
334 | } | |
335 | if (!q) | |
336 | continue; | |
337 | ||
338 | /* | |
339 | * weight for p is unknown but q is known. | |
340 | * add one for p itself if p is to be counted, | |
341 | * otherwise inherit it from q directly. | |
342 | */ | |
343 | if (!(flags & TREESAME)) { | |
344 | weight_set(p, weight(q)+1); | |
345 | counted++; | |
346 | show_list("bisection 2 count one", | |
347 | counted, nr, list); | |
348 | } | |
349 | else | |
350 | weight_set(p, weight(q)); | |
351 | ||
352 | /* Does it happen to be at exactly half-way? */ | |
353 | if (!find_all && halfway(p, nr)) | |
354 | return p; | |
355 | } | |
356 | } | |
357 | ||
358 | show_list("bisection 2 counted all", counted, nr, list); | |
359 | ||
360 | if (!find_all) | |
361 | return best_bisection(list, nr); | |
362 | else | |
363 | return best_bisection_sorted(list, nr); | |
364 | } | |
365 | ||
24d707f6 MÅ |
366 | void find_bisection(struct commit_list **commit_list, int *reaches, |
367 | int *all, int find_all) | |
a2ad79ce CC |
368 | { |
369 | int nr, on_list; | |
24d707f6 | 370 | struct commit_list *list, *p, *best, *next, *last; |
a2ad79ce CC |
371 | int *weights; |
372 | ||
24d707f6 | 373 | show_list("bisection 2 entry", 0, 0, *commit_list); |
a2ad79ce CC |
374 | |
375 | /* | |
376 | * Count the number of total and tree-changing items on the | |
377 | * list, while reversing the list. | |
378 | */ | |
24d707f6 | 379 | for (nr = on_list = 0, last = NULL, p = *commit_list; |
a2ad79ce CC |
380 | p; |
381 | p = next) { | |
382 | unsigned flags = p->item->object.flags; | |
383 | ||
384 | next = p->next; | |
fc5c40bb MÅ |
385 | if (flags & UNINTERESTING) { |
386 | free(p); | |
a2ad79ce | 387 | continue; |
fc5c40bb | 388 | } |
a2ad79ce CC |
389 | p->next = last; |
390 | last = p; | |
391 | if (!(flags & TREESAME)) | |
392 | nr++; | |
393 | on_list++; | |
394 | } | |
395 | list = last; | |
396 | show_list("bisection 2 sorted", 0, nr, list); | |
397 | ||
398 | *all = nr; | |
399 | weights = xcalloc(on_list, sizeof(*weights)); | |
400 | ||
401 | /* Do the real work of finding bisection commit. */ | |
402 | best = do_find_bisection(list, nr, weights, find_all); | |
403 | if (best) { | |
f4e45cb3 MÅ |
404 | if (!find_all) { |
405 | list->item = best->item; | |
406 | free_commit_list(list->next); | |
407 | best = list; | |
a2ad79ce | 408 | best->next = NULL; |
f4e45cb3 | 409 | } |
a2ad79ce CC |
410 | *reaches = weight(best); |
411 | } | |
412 | free(weights); | |
24d707f6 | 413 | *commit_list = best; |
a2ad79ce CC |
414 | } |
415 | ||
eed25148 | 416 | static int register_ref(const char *refname, const struct object_id *oid, |
1bf072e3 CC |
417 | int flags, void *cb_data) |
418 | { | |
43f9d9f3 AD |
419 | struct strbuf good_prefix = STRBUF_INIT; |
420 | strbuf_addstr(&good_prefix, term_good); | |
421 | strbuf_addstr(&good_prefix, "-"); | |
422 | ||
423 | if (!strcmp(refname, term_bad)) { | |
3c5ff995 | 424 | current_bad_oid = xmalloc(sizeof(*current_bad_oid)); |
eed25148 | 425 | oidcpy(current_bad_oid, oid); |
43f9d9f3 | 426 | } else if (starts_with(refname, good_prefix.buf)) { |
910650d2 | 427 | oid_array_append(&good_revs, oid); |
59556548 | 428 | } else if (starts_with(refname, "skip-")) { |
910650d2 | 429 | oid_array_append(&skipped_revs, oid); |
1bf072e3 CC |
430 | } |
431 | ||
43f9d9f3 AD |
432 | strbuf_release(&good_prefix); |
433 | ||
1bf072e3 CC |
434 | return 0; |
435 | } | |
436 | ||
437 | static int read_bisect_refs(void) | |
438 | { | |
eed25148 | 439 | return for_each_ref_in("refs/bisect/", register_ref, NULL); |
1bf072e3 CC |
440 | } |
441 | ||
f932729c JK |
442 | static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES") |
443 | static GIT_PATH_FUNC(git_path_bisect_expected_rev, "BISECT_EXPECTED_REV") | |
fb71a329 PB |
444 | static GIT_PATH_FUNC(git_path_bisect_ancestors_ok, "BISECT_ANCESTORS_OK") |
445 | static GIT_PATH_FUNC(git_path_bisect_run, "BISECT_RUN") | |
446 | static GIT_PATH_FUNC(git_path_bisect_start, "BISECT_START") | |
447 | static GIT_PATH_FUNC(git_path_bisect_log, "BISECT_LOG") | |
f5d284f6 | 448 | static GIT_PATH_FUNC(git_path_bisect_terms, "BISECT_TERMS") |
fb71a329 | 449 | static GIT_PATH_FUNC(git_path_head_name, "head-name") |
f932729c | 450 | |
2af202be | 451 | static void read_bisect_paths(struct argv_array *array) |
3b437b0d CC |
452 | { |
453 | struct strbuf str = STRBUF_INIT; | |
f932729c | 454 | const char *filename = git_path_bisect_names(); |
23a9e071 | 455 | FILE *fp = xfopen(filename, "r"); |
3b437b0d | 456 | |
8f309aeb | 457 | while (strbuf_getline_lf(&str, fp) != EOF) { |
3b437b0d | 458 | strbuf_trim(&str); |
8a534b61 | 459 | if (sq_dequote_to_argv_array(str.buf, array)) |
14dc4899 | 460 | die(_("Badly quoted content in file '%s': %s"), |
8a534b61 | 461 | filename, str.buf); |
3b437b0d CC |
462 | } |
463 | ||
464 | strbuf_release(&str); | |
465 | fclose(fp); | |
466 | } | |
467 | ||
910650d2 | 468 | static char *join_sha1_array_hex(struct oid_array *array, char delim) |
c0537662 CC |
469 | { |
470 | struct strbuf joined_hexs = STRBUF_INIT; | |
471 | int i; | |
472 | ||
902bb364 | 473 | for (i = 0; i < array->nr; i++) { |
ee3051bd | 474 | strbuf_addstr(&joined_hexs, oid_to_hex(array->oid + i)); |
902bb364 | 475 | if (i + 1 < array->nr) |
c0537662 CC |
476 | strbuf_addch(&joined_hexs, delim); |
477 | } | |
478 | ||
479 | return strbuf_detach(&joined_hexs, NULL); | |
480 | } | |
481 | ||
9af3589e CC |
482 | /* |
483 | * In this function, passing a not NULL skipped_first is very special. | |
484 | * It means that we want to know if the first commit in the list is | |
485 | * skipped because we will want to test a commit away from it if it is | |
486 | * indeed skipped. | |
487 | * So if the first commit is skipped, we cannot take the shortcut to | |
488 | * just "return list" when we find the first non skipped commit, we | |
489 | * have to return a fully filtered list. | |
490 | * | |
491 | * We use (*skipped_first == -1) to mean "it has been found that the | |
492 | * first commit is not skipped". In this case *skipped_first is set back | |
493 | * to 0 just before the function returns. | |
494 | */ | |
95188648 CC |
495 | struct commit_list *filter_skipped(struct commit_list *list, |
496 | struct commit_list **tried, | |
9af3589e CC |
497 | int show_all, |
498 | int *count, | |
499 | int *skipped_first) | |
95188648 CC |
500 | { |
501 | struct commit_list *filtered = NULL, **f = &filtered; | |
502 | ||
503 | *tried = NULL; | |
504 | ||
9af3589e CC |
505 | if (skipped_first) |
506 | *skipped_first = 0; | |
507 | if (count) | |
508 | *count = 0; | |
509 | ||
902bb364 | 510 | if (!skipped_revs.nr) |
95188648 CC |
511 | return list; |
512 | ||
95188648 CC |
513 | while (list) { |
514 | struct commit_list *next = list->next; | |
515 | list->next = NULL; | |
910650d2 | 516 | if (0 <= oid_array_lookup(&skipped_revs, &list->item->object.oid)) { |
9af3589e CC |
517 | if (skipped_first && !*skipped_first) |
518 | *skipped_first = 1; | |
95188648 CC |
519 | /* Move current to tried list */ |
520 | *tried = list; | |
521 | tried = &list->next; | |
522 | } else { | |
9af3589e CC |
523 | if (!show_all) { |
524 | if (!skipped_first || !*skipped_first) | |
525 | return list; | |
526 | } else if (skipped_first && !*skipped_first) { | |
527 | /* This means we know it's not skipped */ | |
528 | *skipped_first = -1; | |
529 | } | |
95188648 CC |
530 | /* Move current to filtered list */ |
531 | *f = list; | |
532 | f = &list->next; | |
9af3589e CC |
533 | if (count) |
534 | (*count)++; | |
95188648 CC |
535 | } |
536 | list = next; | |
537 | } | |
538 | ||
9af3589e CC |
539 | if (skipped_first && *skipped_first == -1) |
540 | *skipped_first = 0; | |
541 | ||
95188648 CC |
542 | return filtered; |
543 | } | |
1bf072e3 | 544 | |
ebc9529f CC |
545 | #define PRN_MODULO 32768 |
546 | ||
547 | /* | |
548 | * This is a pseudo random number generator based on "man 3 rand". | |
549 | * It is not used properly because the seed is the argument and it | |
550 | * is increased by one between each call, but that should not matter | |
551 | * for this application. | |
552 | */ | |
7b96d888 | 553 | static unsigned get_prn(unsigned count) { |
ebc9529f | 554 | count = count * 1103515245 + 12345; |
7b96d888 | 555 | return (count/65536) % PRN_MODULO; |
ebc9529f CC |
556 | } |
557 | ||
558 | /* | |
559 | * Custom integer square root from | |
5e68729f | 560 | * https://en.wikipedia.org/wiki/Integer_square_root |
ebc9529f CC |
561 | */ |
562 | static int sqrti(int val) | |
563 | { | |
564 | float d, x = val; | |
565 | ||
566 | if (val == 0) | |
567 | return 0; | |
568 | ||
569 | do { | |
570 | float y = (x + (float)val / x) / 2; | |
571 | d = (y > x) ? y - x : x - y; | |
572 | x = y; | |
573 | } while (d >= 0.5); | |
574 | ||
575 | return (int)x; | |
576 | } | |
577 | ||
578 | static struct commit_list *skip_away(struct commit_list *list, int count) | |
62d0b0da | 579 | { |
62d0b0da | 580 | struct commit_list *cur, *previous; |
ebc9529f CC |
581 | int prn, index, i; |
582 | ||
583 | prn = get_prn(count); | |
584 | index = (count * prn / PRN_MODULO) * sqrti(prn) / sqrti(PRN_MODULO); | |
62d0b0da CC |
585 | |
586 | cur = list; | |
587 | previous = NULL; | |
62d0b0da CC |
588 | |
589 | for (i = 0; cur; cur = cur->next, i++) { | |
590 | if (i == index) { | |
f2fd0760 | 591 | if (oidcmp(&cur->item->object.oid, current_bad_oid)) |
62d0b0da CC |
592 | return cur; |
593 | if (previous) | |
594 | return previous; | |
595 | return list; | |
596 | } | |
597 | previous = cur; | |
598 | } | |
599 | ||
600 | return list; | |
601 | } | |
602 | ||
603 | static struct commit_list *managed_skipped(struct commit_list *list, | |
604 | struct commit_list **tried) | |
605 | { | |
606 | int count, skipped_first; | |
62d0b0da CC |
607 | |
608 | *tried = NULL; | |
609 | ||
902bb364 | 610 | if (!skipped_revs.nr) |
62d0b0da CC |
611 | return list; |
612 | ||
613 | list = filter_skipped(list, tried, 0, &count, &skipped_first); | |
614 | ||
615 | if (!skipped_first) | |
616 | return list; | |
617 | ||
ebc9529f | 618 | return skip_away(list, count); |
62d0b0da CC |
619 | } |
620 | ||
a22347c6 CC |
621 | static void bisect_rev_setup(struct rev_info *revs, const char *prefix, |
622 | const char *bad_format, const char *good_format, | |
623 | int read_paths) | |
1bf072e3 | 624 | { |
8a534b61 | 625 | struct argv_array rev_argv = ARGV_ARRAY_INIT; |
fad2d31d CC |
626 | int i; |
627 | ||
3b437b0d CC |
628 | init_revisions(revs, prefix); |
629 | revs->abbrev = 0; | |
630 | revs->commit_format = CMIT_FMT_UNSPECIFIED; | |
1bf072e3 | 631 | |
1c953a1f | 632 | /* rev_argv.argv[0] will be ignored by setup_revisions */ |
8a534b61 | 633 | argv_array_push(&rev_argv, "bisect_rev_setup"); |
3c5ff995 | 634 | argv_array_pushf(&rev_argv, bad_format, oid_to_hex(current_bad_oid)); |
902bb364 | 635 | for (i = 0; i < good_revs.nr; i++) |
8a534b61 | 636 | argv_array_pushf(&rev_argv, good_format, |
ee3051bd | 637 | oid_to_hex(good_revs.oid + i)); |
8a534b61 | 638 | argv_array_push(&rev_argv, "--"); |
a22347c6 CC |
639 | if (read_paths) |
640 | read_bisect_paths(&rev_argv); | |
3b437b0d | 641 | |
8a534b61 JK |
642 | setup_revisions(rev_argv.argc, rev_argv.argv, revs, NULL); |
643 | /* XXX leak rev_argv, as "revs" may still be pointing to it */ | |
3b437b0d CC |
644 | } |
645 | ||
a22347c6 | 646 | static void bisect_common(struct rev_info *revs) |
2ace9727 | 647 | { |
2ace9727 CC |
648 | if (prepare_revision_walk(revs)) |
649 | die("revision walk setup failed"); | |
650 | if (revs->tree_objects) | |
e76a5fb4 | 651 | mark_edges_uninteresting(revs, NULL); |
2ace9727 CC |
652 | } |
653 | ||
ef24c7ca | 654 | static void exit_if_skipped_commits(struct commit_list *tried, |
3c5ff995 | 655 | const struct object_id *bad) |
ef24c7ca CC |
656 | { |
657 | if (!tried) | |
658 | return; | |
659 | ||
660 | printf("There are only 'skip'ped commits left to test.\n" | |
43f9d9f3 | 661 | "The first %s commit could be any of:\n", term_bad); |
54307ea7 JH |
662 | |
663 | for ( ; tried; tried = tried->next) | |
664 | printf("%s\n", oid_to_hex(&tried->item->object.oid)); | |
665 | ||
ef24c7ca | 666 | if (bad) |
3c5ff995 | 667 | printf("%s\n", oid_to_hex(bad)); |
14dc4899 | 668 | printf(_("We cannot bisect more!\n")); |
ef24c7ca CC |
669 | exit(2); |
670 | } | |
671 | ||
3c5ff995 | 672 | static int is_expected_rev(const struct object_id *oid) |
c0537662 | 673 | { |
f932729c | 674 | const char *filename = git_path_bisect_expected_rev(); |
c0537662 CC |
675 | struct stat st; |
676 | struct strbuf str = STRBUF_INIT; | |
677 | FILE *fp; | |
678 | int res = 0; | |
679 | ||
680 | if (stat(filename, &st) || !S_ISREG(st.st_mode)) | |
681 | return 0; | |
682 | ||
e9d983f1 | 683 | fp = fopen_or_warn(filename, "r"); |
c0537662 CC |
684 | if (!fp) |
685 | return 0; | |
686 | ||
8f309aeb | 687 | if (strbuf_getline_lf(&str, fp) != EOF) |
3c5ff995 | 688 | res = !strcmp(str.buf, oid_to_hex(oid)); |
c0537662 CC |
689 | |
690 | strbuf_release(&str); | |
691 | fclose(fp); | |
692 | ||
693 | return res; | |
694 | } | |
695 | ||
4be0deec | 696 | static int bisect_checkout(const struct object_id *bisect_rev, int no_checkout) |
ef24c7ca | 697 | { |
dc01505f | 698 | char bisect_rev_hex[GIT_MAX_HEXSZ + 1]; |
ef24c7ca | 699 | |
4be0deec | 700 | memcpy(bisect_rev_hex, oid_to_hex(bisect_rev), GIT_SHA1_HEXSZ + 1); |
ae077771 | 701 | update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0, UPDATE_REFS_DIE_ON_ERR); |
ef24c7ca CC |
702 | |
703 | argv_checkout[2] = bisect_rev_hex; | |
fee92fc1 | 704 | if (no_checkout) { |
ae077771 | 705 | update_ref(NULL, "BISECT_HEAD", bisect_rev, NULL, 0, |
706 | UPDATE_REFS_DIE_ON_ERR); | |
fee92fc1 | 707 | } else { |
4824d1b8 | 708 | int res; |
fee92fc1 JS |
709 | res = run_command_v_opt(argv_checkout, RUN_GIT_CMD); |
710 | if (res) | |
711 | exit(res); | |
712 | } | |
ef24c7ca CC |
713 | |
714 | argv_show_branch[1] = bisect_rev_hex; | |
715 | return run_command_v_opt(argv_show_branch, RUN_GIT_CMD); | |
716 | } | |
717 | ||
ee3051bd | 718 | static struct commit *get_commit_reference(const struct object_id *oid) |
c0537662 | 719 | { |
bc83266a | 720 | struct commit *r = lookup_commit_reference(oid); |
c0537662 | 721 | if (!r) |
ee3051bd | 722 | die(_("Not a valid commit name %s"), oid_to_hex(oid)); |
c0537662 CC |
723 | return r; |
724 | } | |
725 | ||
726 | static struct commit **get_bad_and_good_commits(int *rev_nr) | |
727 | { | |
b32fa95f | 728 | struct commit **rev; |
c0537662 CC |
729 | int i, n = 0; |
730 | ||
b32fa95f | 731 | ALLOC_ARRAY(rev, 1 + good_revs.nr); |
ee3051bd | 732 | rev[n++] = get_commit_reference(current_bad_oid); |
902bb364 | 733 | for (i = 0; i < good_revs.nr; i++) |
ee3051bd | 734 | rev[n++] = get_commit_reference(good_revs.oid + i); |
c0537662 CC |
735 | *rev_nr = n; |
736 | ||
737 | return rev; | |
738 | } | |
739 | ||
740 | static void handle_bad_merge_base(void) | |
741 | { | |
3c5ff995 | 742 | if (is_expected_rev(current_bad_oid)) { |
743 | char *bad_hex = oid_to_hex(current_bad_oid); | |
c0537662 | 744 | char *good_hex = join_sha1_array_hex(&good_revs, ' '); |
43f9d9f3 | 745 | if (!strcmp(term_bad, "bad") && !strcmp(term_good, "good")) { |
14dc4899 | 746 | fprintf(stderr, _("The merge base %s is bad.\n" |
43f9d9f3 | 747 | "This means the bug has been fixed " |
14dc4899 | 748 | "between %s and [%s].\n"), |
43f9d9f3 | 749 | bad_hex, bad_hex, good_hex); |
21e5cfd8 | 750 | } else if (!strcmp(term_bad, "new") && !strcmp(term_good, "old")) { |
14dc4899 | 751 | fprintf(stderr, _("The merge base %s is new.\n" |
21e5cfd8 | 752 | "The property has changed " |
14dc4899 | 753 | "between %s and [%s].\n"), |
21e5cfd8 | 754 | bad_hex, bad_hex, good_hex); |
43f9d9f3 | 755 | } else { |
14dc4899 | 756 | fprintf(stderr, _("The merge base %s is %s.\n" |
43f9d9f3 | 757 | "This means the first '%s' commit is " |
14dc4899 | 758 | "between %s and [%s].\n"), |
43f9d9f3 AD |
759 | bad_hex, term_bad, term_good, bad_hex, good_hex); |
760 | } | |
c0537662 CC |
761 | exit(3); |
762 | } | |
763 | ||
3f407b76 | 764 | fprintf(stderr, _("Some %s revs are not ancestors of the %s rev.\n" |
c0537662 | 765 | "git bisect cannot work properly in this case.\n" |
14dc4899 | 766 | "Maybe you mistook %s and %s revs?\n"), |
43f9d9f3 | 767 | term_good, term_bad, term_good, term_bad); |
c0537662 CC |
768 | exit(1); |
769 | } | |
770 | ||
4ce3621a | 771 | static void handle_skipped_merge_base(const struct object_id *mb) |
c0537662 | 772 | { |
4ce3621a | 773 | char *mb_hex = oid_to_hex(mb); |
c368dde9 | 774 | char *bad_hex = oid_to_hex(current_bad_oid); |
c0537662 CC |
775 | char *good_hex = join_sha1_array_hex(&good_revs, ' '); |
776 | ||
14dc4899 | 777 | warning(_("the merge base between %s and [%s] " |
c0537662 | 778 | "must be skipped.\n" |
43f9d9f3 | 779 | "So we cannot be sure the first %s commit is " |
c0537662 | 780 | "between %s and %s.\n" |
14dc4899 | 781 | "We continue anyway."), |
43f9d9f3 | 782 | bad_hex, good_hex, term_bad, mb_hex, bad_hex); |
c0537662 CC |
783 | free(good_hex); |
784 | } | |
785 | ||
786 | /* | |
21e5cfd8 | 787 | * "check_merge_bases" checks that merge bases are not "bad" (or "new"). |
c0537662 | 788 | * |
21e5cfd8 | 789 | * - If one is "bad" (or "new"), it means the user assumed something wrong |
c0537662 | 790 | * and we must exit with a non 0 error code. |
21e5cfd8 | 791 | * - If one is "good" (or "old"), that's good, we have nothing to do. |
c0537662 CC |
792 | * - If one is "skipped", we can't know but we should warn. |
793 | * - If we don't know, we should check it out and ask the user to test. | |
794 | */ | |
fee92fc1 | 795 | static void check_merge_bases(int no_checkout) |
c0537662 CC |
796 | { |
797 | struct commit_list *result; | |
798 | int rev_nr; | |
799 | struct commit **rev = get_bad_and_good_commits(&rev_nr); | |
800 | ||
2ce406cc | 801 | result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1); |
c0537662 CC |
802 | |
803 | for (; result; result = result->next) { | |
4ce3621a | 804 | const struct object_id *mb = &result->item->object.oid; |
805 | if (!oidcmp(mb, current_bad_oid)) { | |
c0537662 | 806 | handle_bad_merge_base(); |
910650d2 | 807 | } else if (0 <= oid_array_lookup(&good_revs, mb)) { |
c0537662 | 808 | continue; |
910650d2 | 809 | } else if (0 <= oid_array_lookup(&skipped_revs, mb)) { |
c0537662 CC |
810 | handle_skipped_merge_base(mb); |
811 | } else { | |
14dc4899 | 812 | printf(_("Bisecting: a merge base must be tested\n")); |
4be0deec | 813 | exit(bisect_checkout(mb, no_checkout)); |
c0537662 CC |
814 | } |
815 | } | |
816 | ||
817 | free(rev); | |
818 | free_commit_list(result); | |
819 | } | |
820 | ||
2d938fc7 | 821 | static int check_ancestors(const char *prefix) |
d937d4ac | 822 | { |
2d938fc7 CC |
823 | struct rev_info revs; |
824 | struct object_array pending_copy; | |
86a0a408 | 825 | int res; |
d937d4ac | 826 | |
2d938fc7 | 827 | bisect_rev_setup(&revs, prefix, "^%s", "%s", 0); |
d937d4ac | 828 | |
2d938fc7 | 829 | /* Save pending objects, so they can be cleaned up later. */ |
353f5657 RS |
830 | pending_copy = revs.pending; |
831 | revs.leak_pending = 1; | |
2d938fc7 | 832 | |
353f5657 RS |
833 | /* |
834 | * bisect_common calls prepare_revision_walk right away, which | |
835 | * (together with .leak_pending = 1) makes us the sole owner of | |
836 | * the list of pending objects. | |
837 | */ | |
2d938fc7 CC |
838 | bisect_common(&revs); |
839 | res = (revs.commits != NULL); | |
840 | ||
841 | /* Clean up objects used, as they will be reused. */ | |
86a0a408 | 842 | clear_commit_marks_for_object_array(&pending_copy, ALL_REV_FLAGS); |
b2ccdf7f MÅ |
843 | |
844 | object_array_clear(&pending_copy); | |
d937d4ac | 845 | |
2d938fc7 | 846 | return res; |
d937d4ac CC |
847 | } |
848 | ||
849 | /* | |
850 | * "check_good_are_ancestors_of_bad" checks that all "good" revs are | |
851 | * ancestor of the "bad" rev. | |
852 | * | |
853 | * If that's not the case, we need to check the merge bases. | |
854 | * If a merge base must be tested by the user, its source code will be | |
855 | * checked out to be tested by the user and we will exit. | |
856 | */ | |
fee92fc1 | 857 | static void check_good_are_ancestors_of_bad(const char *prefix, int no_checkout) |
d937d4ac | 858 | { |
d292bfaf | 859 | char *filename = git_pathdup("BISECT_ANCESTORS_OK"); |
d937d4ac CC |
860 | struct stat st; |
861 | int fd; | |
862 | ||
3c5ff995 | 863 | if (!current_bad_oid) |
14dc4899 | 864 | die(_("a %s revision is needed"), term_bad); |
d937d4ac CC |
865 | |
866 | /* Check if file BISECT_ANCESTORS_OK exists. */ | |
867 | if (!stat(filename, &st) && S_ISREG(st.st_mode)) | |
144e7090 | 868 | goto done; |
d937d4ac CC |
869 | |
870 | /* Bisecting with no good rev is ok. */ | |
902bb364 | 871 | if (good_revs.nr == 0) |
144e7090 | 872 | goto done; |
d937d4ac | 873 | |
2d938fc7 CC |
874 | /* Check if all good revs are ancestor of the bad rev. */ |
875 | if (check_ancestors(prefix)) | |
fee92fc1 | 876 | check_merge_bases(no_checkout); |
d937d4ac CC |
877 | |
878 | /* Create file BISECT_ANCESTORS_OK. */ | |
879 | fd = open(filename, O_CREAT | O_TRUNC | O_WRONLY, 0600); | |
880 | if (fd < 0) | |
14dc4899 | 881 | warning_errno(_("could not create file '%s'"), |
23e7a312 | 882 | filename); |
d937d4ac CC |
883 | else |
884 | close(fd); | |
144e7090 MH |
885 | done: |
886 | free(filename); | |
d937d4ac CC |
887 | } |
888 | ||
e22278c0 CC |
889 | /* |
890 | * This does "git diff-tree --pretty COMMIT" without one fork+exec. | |
891 | */ | |
892 | static void show_diff_tree(const char *prefix, struct commit *commit) | |
893 | { | |
894 | struct rev_info opt; | |
895 | ||
896 | /* diff-tree init */ | |
897 | init_revisions(&opt, prefix); | |
898 | git_config(git_diff_basic_config, NULL); /* no "diff" UI options */ | |
899 | opt.abbrev = 0; | |
900 | opt.diff = 1; | |
901 | ||
902 | /* This is what "--pretty" does */ | |
903 | opt.verbose_header = 1; | |
904 | opt.use_terminator = 0; | |
905 | opt.commit_format = CMIT_FMT_DEFAULT; | |
906 | ||
907 | /* diff-tree init */ | |
908 | if (!opt.diffopt.output_format) | |
909 | opt.diffopt.output_format = DIFF_FORMAT_RAW; | |
910 | ||
43ec5509 | 911 | setup_revisions(0, NULL, &opt, NULL); |
e22278c0 CC |
912 | log_tree_commit(&opt, commit); |
913 | } | |
914 | ||
cb46d630 AD |
915 | /* |
916 | * The terms used for this bisect session are stored in BISECT_TERMS. | |
917 | * We read them and store them to adapt the messages accordingly. | |
918 | * Default is bad/good. | |
919 | */ | |
920 | void read_bisect_terms(const char **read_bad, const char **read_good) | |
921 | { | |
922 | struct strbuf str = STRBUF_INIT; | |
f5d284f6 | 923 | const char *filename = git_path_bisect_terms(); |
cb46d630 AD |
924 | FILE *fp = fopen(filename, "r"); |
925 | ||
926 | if (!fp) { | |
927 | if (errno == ENOENT) { | |
928 | *read_bad = "bad"; | |
929 | *read_good = "good"; | |
930 | return; | |
931 | } else { | |
14dc4899 | 932 | die_errno(_("could not read file '%s'"), filename); |
cb46d630 AD |
933 | } |
934 | } else { | |
8f309aeb | 935 | strbuf_getline_lf(&str, fp); |
cb46d630 | 936 | *read_bad = strbuf_detach(&str, NULL); |
8f309aeb | 937 | strbuf_getline_lf(&str, fp); |
cb46d630 AD |
938 | *read_good = strbuf_detach(&str, NULL); |
939 | } | |
940 | strbuf_release(&str); | |
941 | fclose(fp); | |
942 | } | |
943 | ||
ef24c7ca CC |
944 | /* |
945 | * We use the convention that exiting with an exit code 10 means that | |
946 | * the bisection process finished successfully. | |
947 | * In this case the calling shell script should exit 0. | |
fee92fc1 JS |
948 | * |
949 | * If no_checkout is non-zero, the bisection process does not | |
950 | * checkout the trial commit but instead simply updates BISECT_HEAD. | |
ef24c7ca | 951 | */ |
fee92fc1 | 952 | int bisect_next_all(const char *prefix, int no_checkout) |
ef24c7ca CC |
953 | { |
954 | struct rev_info revs; | |
955 | struct commit_list *tried; | |
6329bade | 956 | int reaches = 0, all = 0, nr, steps; |
4be0deec | 957 | struct object_id *bisect_rev; |
2cfa8357 | 958 | char *steps_msg; |
ef24c7ca | 959 | |
cb46d630 | 960 | read_bisect_terms(&term_bad, &term_good); |
2b020695 | 961 | if (read_bisect_refs()) |
14dc4899 | 962 | die(_("reading bisect refs failed")); |
2b020695 | 963 | |
fee92fc1 | 964 | check_good_are_ancestors_of_bad(prefix, no_checkout); |
0871984d | 965 | |
a22347c6 CC |
966 | bisect_rev_setup(&revs, prefix, "%s", "^%s", 1); |
967 | revs.limited = 1; | |
2b020695 | 968 | |
a22347c6 | 969 | bisect_common(&revs); |
ef24c7ca | 970 | |
24d707f6 | 971 | find_bisection(&revs.commits, &reaches, &all, !!skipped_revs.nr); |
62d0b0da | 972 | revs.commits = managed_skipped(revs.commits, &tried); |
ef24c7ca CC |
973 | |
974 | if (!revs.commits) { | |
975 | /* | |
976 | * We should exit here only if the "bad" | |
977 | * commit is also a "skip" commit. | |
978 | */ | |
979 | exit_if_skipped_commits(tried, NULL); | |
980 | ||
14dc4899 | 981 | printf(_("%s was both %s and %s\n"), |
43f9d9f3 AD |
982 | oid_to_hex(current_bad_oid), |
983 | term_good, | |
984 | term_bad); | |
ef24c7ca CC |
985 | exit(1); |
986 | } | |
987 | ||
8f69f72f | 988 | if (!all) { |
14dc4899 VA |
989 | fprintf(stderr, _("No testable commit found.\n" |
990 | "Maybe you started with bad path parameters?\n")); | |
8f69f72f CC |
991 | exit(4); |
992 | } | |
993 | ||
4be0deec | 994 | bisect_rev = &revs.commits->item->object.oid; |
ef24c7ca | 995 | |
4be0deec | 996 | if (!oidcmp(bisect_rev, current_bad_oid)) { |
3c5ff995 | 997 | exit_if_skipped_commits(tried, current_bad_oid); |
4be0deec | 998 | printf("%s is the first %s commit\n", oid_to_hex(bisect_rev), |
43f9d9f3 | 999 | term_bad); |
e22278c0 | 1000 | show_diff_tree(prefix, revs.commits->item); |
ef24c7ca CC |
1001 | /* This means the bisection process succeeded. */ |
1002 | exit(10); | |
1003 | } | |
1004 | ||
1005 | nr = all - reaches - 1; | |
6329bade | 1006 | steps = estimate_bisect_steps(all); |
2cfa8357 MM |
1007 | |
1008 | steps_msg = xstrfmt(Q_("(roughly %d step)", "(roughly %d steps)", | |
1009 | steps), steps); | |
66f5f6dc ÆAB |
1010 | /* |
1011 | * TRANSLATORS: the last %s will be replaced with "(roughly %d | |
1012 | * steps)" translation. | |
1013 | */ | |
14dc4899 VA |
1014 | printf(Q_("Bisecting: %d revision left to test after this %s\n", |
1015 | "Bisecting: %d revisions left to test after this %s\n", | |
1016 | nr), nr, steps_msg); | |
2cfa8357 | 1017 | free(steps_msg); |
ef24c7ca | 1018 | |
f3a97718 | 1019 | return bisect_checkout(bisect_rev, no_checkout); |
ef24c7ca CC |
1020 | } |
1021 | ||
c43cb386 NTND |
1022 | static inline int log2i(int n) |
1023 | { | |
1024 | int log2 = 0; | |
1025 | ||
1026 | for (; n > 1; n >>= 1) | |
1027 | log2++; | |
1028 | ||
1029 | return log2; | |
1030 | } | |
1031 | ||
1032 | static inline int exp2i(int n) | |
1033 | { | |
1034 | return 1 << n; | |
1035 | } | |
1036 | ||
1037 | /* | |
1038 | * Estimate the number of bisect steps left (after the current step) | |
1039 | * | |
1040 | * For any x between 0 included and 2^n excluded, the probability for | |
1041 | * n - 1 steps left looks like: | |
1042 | * | |
1043 | * P(2^n + x) == (2^n - x) / (2^n + x) | |
1044 | * | |
1045 | * and P(2^n + x) < 0.5 means 2^n < 3x | |
1046 | */ | |
1047 | int estimate_bisect_steps(int all) | |
1048 | { | |
1049 | int n, x, e; | |
1050 | ||
1051 | if (all < 3) | |
1052 | return 0; | |
1053 | ||
1054 | n = log2i(all); | |
1055 | e = exp2i(n); | |
1056 | x = all - e; | |
1057 | ||
1058 | return (e < 3 * x) ? n : n - 1; | |
1059 | } | |
fb71a329 PB |
1060 | |
1061 | static int mark_for_removal(const char *refname, const struct object_id *oid, | |
1062 | int flag, void *cb_data) | |
1063 | { | |
1064 | struct string_list *refs = cb_data; | |
1065 | char *ref = xstrfmt("refs/bisect%s", refname); | |
1066 | string_list_append(refs, ref); | |
1067 | return 0; | |
1068 | } | |
1069 | ||
1070 | int bisect_clean_state(void) | |
1071 | { | |
1072 | int result = 0; | |
1073 | ||
1074 | /* There may be some refs packed during bisection */ | |
1075 | struct string_list refs_for_removal = STRING_LIST_INIT_NODUP; | |
1076 | for_each_ref_in("refs/bisect", mark_for_removal, (void *) &refs_for_removal); | |
1077 | string_list_append(&refs_for_removal, xstrdup("BISECT_HEAD")); | |
a9722297 | 1078 | result = delete_refs("bisect: remove", &refs_for_removal, REF_NO_DEREF); |
fb71a329 PB |
1079 | refs_for_removal.strdup_strings = 1; |
1080 | string_list_clear(&refs_for_removal, 0); | |
1081 | unlink_or_warn(git_path_bisect_expected_rev()); | |
1082 | unlink_or_warn(git_path_bisect_ancestors_ok()); | |
1083 | unlink_or_warn(git_path_bisect_log()); | |
1084 | unlink_or_warn(git_path_bisect_names()); | |
1085 | unlink_or_warn(git_path_bisect_run()); | |
1086 | unlink_or_warn(git_path_bisect_terms()); | |
1087 | /* Cleanup head-name if it got left by an old version of git-bisect */ | |
1088 | unlink_or_warn(git_path_head_name()); | |
1089 | /* | |
1090 | * Cleanup BISECT_START last to support the --no-checkout option | |
1091 | * introduced in the commit 4796e823a. | |
1092 | */ | |
1093 | unlink_or_warn(git_path_bisect_start()); | |
1094 | ||
1095 | return result; | |
1096 | } |