]> git.ipfire.org Git - thirdparty/git.git/blame - builtin-send-pack.c
start_command(), if .in/.out > 0, closes file descriptors, not the callers
[thirdparty/git.git] / builtin-send-pack.c
CommitLineData
61221472 1#include "cache.h"
2a9c3fe8 2#include "commit.h"
37fde874 3#include "tag.h"
584c6cc9 4#include "refs.h"
f3a3214e 5#include "pkt-line.h"
38b1c662 6#include "run-command.h"
6b62816c 7#include "remote.h"
96249c04 8#include "send-pack.h"
61221472 9
2a245013 10static const char send_pack_usage[] =
28b9d6e5 11"git-send-pack [--all | --mirror] [--dry-run] [--force] [--receive-pack=<git-receive-pack>] [--verbose] [--thin] [<host>:]<directory> [<ref>...]\n"
18bd8821 12" --all and explicit <ref> specification are mutually exclusive.";
96249c04
DB
13
14static struct send_pack_args args = {
15 /* .receivepack = */ "git-receive-pack",
16};
61221472 17
c727fe2a 18/*
0ae5f98c 19 * Make a pack stream and spit it out into file descriptor fd
c727fe2a 20 */
0ae5f98c 21static int pack_objects(int fd, struct ref *refs)
c727fe2a 22{
38b1c662
SP
23 /*
24 * The child becomes pack-objects --revs; we feed
25 * the revision parameters to it via its stdin and
26 * let its stdout go back to the other end.
27 */
96249c04 28 const char *argv[] = {
38b1c662
SP
29 "pack-objects",
30 "--all-progress",
31 "--revs",
32 "--stdout",
33 NULL,
34 NULL,
35 };
36 struct child_process po;
c727fe2a 37
96249c04
DB
38 if (args.use_thin_pack)
39 argv[4] = "--thin";
38b1c662 40 memset(&po, 0, sizeof(po));
96249c04 41 po.argv = argv;
38b1c662
SP
42 po.in = -1;
43 po.out = fd;
44 po.git_cmd = 1;
45 if (start_command(&po))
46 die("git-pack-objects failed (%s)", strerror(errno));
c727fe2a 47
0ae5f98c
JH
48 /*
49 * We feed the pack-objects we just spawned with revision
50 * parameters by writing to the pipe.
c727fe2a 51 */
c727fe2a
AW
52 while (refs) {
53 char buf[42];
54
55 if (!is_null_sha1(refs->old_sha1) &&
56 has_sha1_file(refs->old_sha1)) {
57 memcpy(buf + 1, sha1_to_hex(refs->old_sha1), 40);
58 buf[0] = '^';
59 buf[41] = '\n';
38b1c662 60 if (!write_or_whine(po.in, buf, 42,
825cee7b
AW
61 "send-pack: send refs"))
62 break;
c727fe2a
AW
63 }
64 if (!is_null_sha1(refs->new_sha1)) {
65 memcpy(buf, sha1_to_hex(refs->new_sha1), 40);
66 buf[40] = '\n';
38b1c662 67 if (!write_or_whine(po.in, buf, 41,
825cee7b
AW
68 "send-pack: send refs"))
69 break;
c727fe2a
AW
70 }
71 refs = refs->next;
72 }
c727fe2a 73
e72ae288 74 close(po.in);
38b1c662
SP
75 if (finish_command(&po))
76 return error("pack-objects died with strange error");
77 return 0;
94fdb7aa 78}
e4b5c7ff 79
51b0fca0
JH
80static void unmark_and_free(struct commit_list *list, unsigned int mark)
81{
82 while (list) {
83 struct commit_list *temp = list;
84 temp->item->object.flags &= ~mark;
85 list = temp->next;
86 free(temp);
87 }
88}
89
37fde874
JH
90static int ref_newer(const unsigned char *new_sha1,
91 const unsigned char *old_sha1)
584c6cc9 92{
37fde874
JH
93 struct object *o;
94 struct commit *old, *new;
51b0fca0
JH
95 struct commit_list *list, *used;
96 int found = 0;
2a9c3fe8 97
37fde874
JH
98 /* Both new and old must be commit-ish and new is descendant of
99 * old. Otherwise we require --force.
100 */
9534f40b 101 o = deref_tag(parse_object(old_sha1), NULL, 0);
1974632c 102 if (!o || o->type != OBJ_COMMIT)
584c6cc9 103 return 0;
37fde874
JH
104 old = (struct commit *) o;
105
9534f40b 106 o = deref_tag(parse_object(new_sha1), NULL, 0);
1974632c 107 if (!o || o->type != OBJ_COMMIT)
2a9c3fe8 108 return 0;
37fde874
JH
109 new = (struct commit *) o;
110
2a9c3fe8
LT
111 if (parse_commit(new) < 0)
112 return 0;
51b0fca0
JH
113
114 used = list = NULL;
2a9c3fe8 115 commit_list_insert(new, &list);
bdf25142
LT
116 while (list) {
117 new = pop_most_recent_commit(&list, 1);
51b0fca0
JH
118 commit_list_insert(new, &used);
119 if (new == old) {
120 found = 1;
121 break;
122 }
2a9c3fe8 123 }
51b0fca0
JH
124 unmark_and_free(list, 1);
125 unmark_and_free(used, 1);
126 return found;
584c6cc9
LT
127}
128
f88395ac
JH
129static struct ref *local_refs, **local_tail;
130static struct ref *remote_refs, **remote_tail;
584c6cc9 131
8da19775 132static int one_local_ref(const char *refname, const unsigned char *sha1, int flag, void *cb_data)
584c6cc9
LT
133{
134 struct ref *ref;
f88395ac
JH
135 int len = strlen(refname) + 1;
136 ref = xcalloc(1, sizeof(*ref) + len);
e702496e 137 hashcpy(ref->new_sha1, sha1);
584c6cc9 138 memcpy(ref->name, refname, len);
f88395ac
JH
139 *local_tail = ref;
140 local_tail = &ref->next;
584c6cc9
LT
141 return 0;
142}
143
f88395ac
JH
144static void get_local_heads(void)
145{
146 local_tail = &local_refs;
cb5d709f 147 for_each_ref(one_local_ref, NULL);
f88395ac
JH
148}
149
ca74c458
JK
150static int receive_status(int in, struct ref *refs)
151{
152 struct ref *hint;
cfee10a7
JH
153 char line[1000];
154 int ret = 0;
155 int len = packet_read_line(in, line, sizeof(line));
2a0fe89a
JK
156 if (len < 10 || memcmp(line, "unpack ", 7))
157 return error("did not receive remote status");
cfee10a7 158 if (memcmp(line, "unpack ok\n", 10)) {
2a0fe89a
JK
159 char *p = line + strlen(line) - 1;
160 if (*p == '\n')
161 *p = '\0';
162 error("unpack failed: %s", line + 7);
cfee10a7
JH
163 ret = -1;
164 }
ca74c458 165 hint = NULL;
cfee10a7 166 while (1) {
2a0fe89a
JK
167 char *refname;
168 char *msg;
cfee10a7
JH
169 len = packet_read_line(in, line, sizeof(line));
170 if (!len)
171 break;
172 if (len < 3 ||
2a0fe89a 173 (memcmp(line, "ok ", 3) && memcmp(line, "ng ", 3))) {
cfee10a7
JH
174 fprintf(stderr, "protocol error: %s\n", line);
175 ret = -1;
176 break;
177 }
2a0fe89a
JK
178
179 line[strlen(line)-1] = '\0';
180 refname = line + 3;
181 msg = strchr(refname, ' ');
182 if (msg)
183 *msg++ = '\0';
184
185 /* first try searching at our hint, falling back to all refs */
ca74c458 186 if (hint)
2a0fe89a 187 hint = find_ref_by_name(hint, refname);
ca74c458 188 if (!hint)
2a0fe89a
JK
189 hint = find_ref_by_name(refs, refname);
190 if (!hint) {
191 warning("remote reported status on unknown ref: %s",
192 refname);
193 continue;
194 }
195 if (hint->status != REF_STATUS_EXPECTING_REPORT) {
196 warning("remote reported status on unexpected ref: %s",
197 refname);
198 continue;
199 }
200
201 if (line[0] == 'o' && line[1] == 'k')
202 hint->status = REF_STATUS_OK;
203 else {
204 hint->status = REF_STATUS_REMOTE_REJECT;
205 ret = -1;
206 }
207 if (msg)
208 hint->remote_status = xstrdup(msg);
209 /* start our next search from the next ref */
210 hint = hint->next;
cfee10a7
JH
211 }
212 return ret;
213}
214
334f4831
JK
215static void update_tracking_ref(struct remote *remote, struct ref *ref)
216{
217 struct refspec rs;
334f4831 218
1f0e2a1a 219 if (ref->status != REF_STATUS_OK)
334f4831
JK
220 return;
221
1f0e2a1a
JK
222 rs.src = ref->name;
223 rs.dst = NULL;
334f4831
JK
224
225 if (!remote_find_tracking(remote, &rs)) {
b50fa2bd
JK
226 if (args.verbose)
227 fprintf(stderr, "updating local tracking ref '%s'\n", rs.dst);
1f0e2a1a 228 if (ref->deletion) {
334f4831
JK
229 if (delete_ref(rs.dst, NULL))
230 error("Failed to delete");
231 } else
232 update_ref("update by push", rs.dst,
233 ref->new_sha1, NULL, 0, 0);
234 free(rs.dst);
235 }
236}
237
8736a848 238static const char *prettify_ref(const struct ref *ref)
f7673490 239{
8736a848 240 const char *name = ref->name;
f7673490
JK
241 return name + (
242 !prefixcmp(name, "refs/heads/") ? 11 :
243 !prefixcmp(name, "refs/tags/") ? 10 :
244 !prefixcmp(name, "refs/remotes/") ? 13 :
245 0);
246}
247
248#define SUMMARY_WIDTH (2 * DEFAULT_ABBREV + 3)
249
8736a848
JK
250static void print_ref_status(char flag, const char *summary, struct ref *to, struct ref *from, const char *msg)
251{
252 fprintf(stderr, " %c %-*s ", flag, SUMMARY_WIDTH, summary);
253 if (from)
254 fprintf(stderr, "%s -> %s", prettify_ref(from), prettify_ref(to));
255 else
256 fputs(prettify_ref(to), stderr);
257 if (msg) {
258 fputs(" (", stderr);
259 fputs(msg, stderr);
260 fputc(')', stderr);
261 }
262 fputc('\n', stderr);
263}
264
265static const char *status_abbrev(unsigned char sha1[20])
266{
267 const char *abbrev;
268 abbrev = find_unique_abbrev(sha1, DEFAULT_ABBREV);
269 return abbrev ? abbrev : sha1_to_hex(sha1);
270}
271
272static void print_ok_ref_status(struct ref *ref)
273{
274 if (ref->deletion)
275 print_ref_status('-', "[deleted]", ref, NULL, NULL);
276 else if (is_null_sha1(ref->old_sha1))
277 print_ref_status('*',
278 (!prefixcmp(ref->name, "refs/tags/") ? "[new tag]" :
279 "[new branch]"),
280 ref, ref->peer_ref, NULL);
281 else {
282 char quickref[84];
283 char type;
284 const char *msg;
285
286 strcpy(quickref, status_abbrev(ref->old_sha1));
287 if (ref->nonfastforward) {
288 strcat(quickref, "...");
289 type = '+';
290 msg = "forced update";
291 } else {
292 strcat(quickref, "..");
293 type = ' ';
294 msg = NULL;
295 }
296 strcat(quickref, status_abbrev(ref->new_sha1));
297
298 print_ref_status(type, quickref, ref, ref->peer_ref, msg);
299 }
300}
301
07f50715
JK
302static int print_one_push_status(struct ref *ref, const char *dest, int count)
303{
304 if (!count)
305 fprintf(stderr, "To %s\n", dest);
306
307 switch(ref->status) {
308 case REF_STATUS_NONE:
309 print_ref_status('X', "[no match]", ref, NULL, NULL);
310 break;
311 case REF_STATUS_REJECT_NODELETE:
312 print_ref_status('!', "[rejected]", ref, NULL,
313 "remote does not support deleting refs");
314 break;
315 case REF_STATUS_UPTODATE:
316 print_ref_status('=', "[up to date]", ref,
317 ref->peer_ref, NULL);
318 break;
319 case REF_STATUS_REJECT_NONFASTFORWARD:
320 print_ref_status('!', "[rejected]", ref, ref->peer_ref,
321 "non-fast forward");
322 break;
323 case REF_STATUS_REMOTE_REJECT:
324 print_ref_status('!', "[remote rejected]", ref,
325 ref->deletion ? NULL : ref->peer_ref,
326 ref->remote_status);
327 break;
328 case REF_STATUS_EXPECTING_REPORT:
329 print_ref_status('!', "[remote failure]", ref,
330 ref->deletion ? NULL : ref->peer_ref,
331 "remote failed to report status");
332 break;
333 case REF_STATUS_OK:
334 print_ok_ref_status(ref);
335 break;
336 }
337
338 return 1;
339}
340
8736a848
JK
341static void print_push_status(const char *dest, struct ref *refs)
342{
343 struct ref *ref;
07f50715 344 int n = 0;
8736a848 345
07f50715
JK
346 if (args.verbose) {
347 for (ref = refs; ref; ref = ref->next)
348 if (ref->status == REF_STATUS_UPTODATE)
349 n += print_one_push_status(ref, dest, n);
350 }
8736a848 351
07f50715
JK
352 for (ref = refs; ref; ref = ref->next)
353 if (ref->status == REF_STATUS_OK)
354 n += print_one_push_status(ref, dest, n);
8736a848 355
07f50715
JK
356 for (ref = refs; ref; ref = ref->next) {
357 if (ref->status != REF_STATUS_NONE &&
358 ref->status != REF_STATUS_UPTODATE &&
359 ref->status != REF_STATUS_OK)
360 n += print_one_push_status(ref, dest, n);
8736a848
JK
361 }
362}
363
73fa0b44
JK
364static int refs_pushed(struct ref *ref)
365{
366 for (; ref; ref = ref->next) {
367 switch(ref->status) {
368 case REF_STATUS_NONE:
369 case REF_STATUS_UPTODATE:
370 break;
371 default:
372 return 1;
373 }
374 }
375 return 0;
376}
377
f7673490 378static int do_send_pack(int in, int out, struct remote *remote, const char *dest, int nr_refspec, const char **refspec)
61221472 379{
7f8e9828 380 struct ref *ref;
584c6cc9 381 int new_refs;
cfee10a7 382 int ask_for_status_report = 0;
d4f694ba 383 int allow_deleting_refs = 0;
cfee10a7 384 int expect_status_report = 0;
28b9d6e5 385 int flags = MATCH_REFS_NONE;
ca74c458 386 int ret;
28b9d6e5
AW
387
388 if (args.send_all)
389 flags |= MATCH_REFS_ALL;
390 if (args.send_mirror)
391 flags |= MATCH_REFS_MIRROR;
7f8e9828 392
f88395ac 393 /* No funny business with the matcher */
2718ff09 394 remote_tail = get_remote_heads(in, &remote_refs, 0, NULL, REF_NORMAL);
f88395ac 395 get_local_heads();
584c6cc9 396
cfee10a7
JH
397 /* Does the other end support the reporting? */
398 if (server_supports("report-status"))
399 ask_for_status_report = 1;
d4f694ba
JH
400 if (server_supports("delete-refs"))
401 allow_deleting_refs = 1;
cfee10a7 402
f88395ac
JH
403 /* match them up */
404 if (!remote_tail)
405 remote_tail = &remote_refs;
406 if (match_refs(local_refs, remote_refs, &remote_tail,
c20181e3
JS
407 nr_refspec, refspec, flags)) {
408 close(out);
f88395ac 409 return -1;
c20181e3 410 }
4c353e89
DB
411
412 if (!remote_refs) {
7e23b06d
AC
413 fprintf(stderr, "No refs in common and none specified; doing nothing.\n"
414 "Perhaps you should specify a branch such as 'master'.\n");
c20181e3 415 close(out);
4c353e89
DB
416 return 0;
417 }
418
584c6cc9 419 /*
f88395ac 420 * Finally, tell the other end!
584c6cc9 421 */
f88395ac
JH
422 new_refs = 0;
423 for (ref = remote_refs; ref; ref = ref->next) {
28b9d6e5 424 const unsigned char *new_sha1;
d4f694ba 425
28b9d6e5
AW
426 if (!ref->peer_ref) {
427 if (!args.send_mirror)
428 continue;
429 new_sha1 = null_sha1;
430 }
431 else
432 new_sha1 = ref->peer_ref->new_sha1;
d4f694ba 433
28b9d6e5 434
8736a848
JK
435 ref->deletion = is_null_sha1(new_sha1);
436 if (ref->deletion && !allow_deleting_refs) {
437 ref->status = REF_STATUS_REJECT_NODELETE;
d4f694ba
JH
438 continue;
439 }
8736a848 440 if (!ref->deletion &&
28b9d6e5 441 !hashcmp(ref->old_sha1, new_sha1)) {
8736a848 442 ref->status = REF_STATUS_UPTODATE;
37fde874
JH
443 continue;
444 }
445
446 /* This part determines what can overwrite what.
447 * The rules are:
448 *
ff27adf3
JH
449 * (0) you can always use --force or +A:B notation to
450 * selectively force individual ref pairs.
37fde874
JH
451 *
452 * (1) if the old thing does not exist, it is OK.
453 *
454 * (2) if you do not have the old thing, you are not allowed
455 * to overwrite it; you would not know what you are losing
456 * otherwise.
457 *
458 * (3) if both new and old are commit-ish, and new is a
459 * descendant of old, it is OK.
d4f694ba
JH
460 *
461 * (4) regardless of all of the above, removing :B is
462 * always allowed.
37fde874
JH
463 */
464
8736a848
JK
465 ref->nonfastforward =
466 !ref->deletion &&
4b4ee90e 467 !is_null_sha1(ref->old_sha1) &&
8736a848
JK
468 (!has_sha1_file(ref->old_sha1)
469 || !ref_newer(new_sha1, ref->old_sha1));
470
471 if (ref->nonfastforward && !ref->force && !args.force_update) {
472 ref->status = REF_STATUS_REJECT_NONFASTFORWARD;
473 continue;
e4b5c7ff 474 }
8736a848 475
28b9d6e5 476 hashcpy(ref->new_sha1, new_sha1);
8736a848 477 if (!ref->deletion)
d4f694ba 478 new_refs++;
cfee10a7 479
96249c04 480 if (!args.dry_run) {
8736a848
JK
481 char *old_hex = sha1_to_hex(ref->old_sha1);
482 char *new_hex = sha1_to_hex(ref->new_sha1);
483
a63103ae
BE
484 if (ask_for_status_report) {
485 packet_write(out, "%s %s %s%c%s",
486 old_hex, new_hex, ref->name, 0,
487 "report-status");
488 ask_for_status_report = 0;
489 expect_status_report = 1;
490 }
491 else
492 packet_write(out, "%s %s %s",
493 old_hex, new_hex, ref->name);
cfee10a7 494 }
2a0fe89a
JK
495 ref->status = expect_status_report ?
496 REF_STATUS_EXPECTING_REPORT :
497 REF_STATUS_OK;
61221472 498 }
f88395ac 499
f3a3214e 500 packet_flush(out);
8736a848 501 if (new_refs && !args.dry_run) {
c20181e3 502 if (pack_objects(out, remote_refs) < 0)
8736a848 503 return -1;
8736a848 504 }
c20181e3
JS
505 else
506 close(out);
cfee10a7 507
2a0fe89a 508 if (expect_status_report)
ca74c458 509 ret = receive_status(in, remote_refs);
ca74c458
JK
510 else
511 ret = 0;
512
513 print_push_status(dest, remote_refs);
cfee10a7 514
8736a848 515 if (!args.dry_run && remote) {
334f4831 516 for (ref = remote_refs; ref; ref = ref->next)
1f0e2a1a 517 update_tracking_ref(remote, ref);
334f4831
JK
518 }
519
73fa0b44 520 if (!refs_pushed(remote_refs))
cfee10a7 521 fprintf(stderr, "Everything up-to-date\n");
ca74c458
JK
522 if (ret < 0)
523 return ret;
8736a848
JK
524 for (ref = remote_refs; ref; ref = ref->next) {
525 switch (ref->status) {
526 case REF_STATUS_NONE:
527 case REF_STATUS_UPTODATE:
528 case REF_STATUS_OK:
529 break;
530 default:
531 return -1;
532 }
533 }
534 return 0;
61221472
LT
535}
536
4577370e 537static void verify_remote_names(int nr_heads, const char **heads)
37adac76
JH
538{
539 int i;
540
541 for (i = 0; i < nr_heads; i++) {
542 const char *remote = strchr(heads[i], ':');
543
544 remote = remote ? (remote + 1) : heads[i];
545 switch (check_ref_format(remote)) {
546 case 0: /* ok */
257f3020
JH
547 case CHECK_REF_FORMAT_ONELEVEL:
548 /* ok but a single level -- that is fine for
549 * a match pattern.
550 */
551 case CHECK_REF_FORMAT_WILDCARD:
552 /* ok but ends with a pattern-match character */
37adac76
JH
553 continue;
554 }
555 die("remote part of refspec is not a valid name in %s",
556 heads[i]);
557 }
558}
f88395ac 559
96249c04 560int cmd_send_pack(int argc, const char **argv, const char *prefix)
61221472
LT
561{
562 int i, nr_heads = 0;
4577370e 563 const char **heads = NULL;
96249c04 564 const char *remote_name = NULL;
b516968f 565 struct remote *remote = NULL;
96249c04 566 const char *dest = NULL;
84a9b58c 567
61221472 568 argv++;
d089391c 569 for (i = 1; i < argc; i++, argv++) {
96249c04 570 const char *arg = *argv;
61221472
LT
571
572 if (*arg == '-') {
cc44c765 573 if (!prefixcmp(arg, "--receive-pack=")) {
96249c04 574 args.receivepack = arg + 15;
d23842fd
UKK
575 continue;
576 }
cc44c765 577 if (!prefixcmp(arg, "--exec=")) {
96249c04 578 args.receivepack = arg + 7;
61221472
LT
579 continue;
580 }
b516968f
DB
581 if (!prefixcmp(arg, "--remote=")) {
582 remote_name = arg + 9;
583 continue;
584 }
d089391c 585 if (!strcmp(arg, "--all")) {
96249c04 586 args.send_all = 1;
d089391c
LT
587 continue;
588 }
a63103ae 589 if (!strcmp(arg, "--dry-run")) {
96249c04 590 args.dry_run = 1;
a63103ae
BE
591 continue;
592 }
28b9d6e5
AW
593 if (!strcmp(arg, "--mirror")) {
594 args.send_mirror = 1;
595 continue;
596 }
2a9c3fe8 597 if (!strcmp(arg, "--force")) {
96249c04 598 args.force_update = 1;
2a9c3fe8
LT
599 continue;
600 }
41f93a2c 601 if (!strcmp(arg, "--verbose")) {
96249c04 602 args.verbose = 1;
41f93a2c
LT
603 continue;
604 }
2245be3e 605 if (!strcmp(arg, "--thin")) {
96249c04 606 args.use_thin_pack = 1;
2245be3e
JH
607 continue;
608 }
61221472
LT
609 usage(send_pack_usage);
610 }
d089391c
LT
611 if (!dest) {
612 dest = arg;
613 continue;
614 }
4577370e 615 heads = (const char **) argv;
d089391c 616 nr_heads = argc - i;
61221472
LT
617 break;
618 }
619 if (!dest)
620 usage(send_pack_usage);
28b9d6e5
AW
621 /*
622 * --all and --mirror are incompatible; neither makes sense
623 * with any refspecs.
624 */
625 if ((heads && (args.send_all || args.send_mirror)) ||
626 (args.send_all && args.send_mirror))
0bc3cdfc 627 usage(send_pack_usage);
37adac76 628
b516968f
DB
629 if (remote_name) {
630 remote = remote_get(remote_name);
28b91f8a 631 if (!remote_has_url(remote, dest)) {
b516968f
DB
632 die("Destination %s is not a uri for %s",
633 dest, remote_name);
634 }
635 }
636
96249c04
DB
637 return send_pack(&args, dest, remote, nr_heads, heads);
638}
639
640int send_pack(struct send_pack_args *my_args,
641 const char *dest, struct remote *remote,
642 int nr_heads, const char **heads)
643{
644 int fd[2], ret;
645 struct child_process *conn;
646
647 memcpy(&args, my_args, sizeof(args));
648
649 verify_remote_names(nr_heads, heads);
650
651 conn = git_connect(fd, dest, args.receivepack, args.verbose ? CONNECT_VERBOSE : 0);
f7673490 652 ret = do_send_pack(fd[0], fd[1], remote, dest, nr_heads, heads);
7f8e9828 653 close(fd[0]);
c20181e3 654 /* do_send_pack always closes fd[1] */
98158e9c 655 ret |= finish_connect(conn);
8a5dbef8 656 return !!ret;
61221472 657}