]>
Commit | Line | Data |
---|---|---|
c3e270f4 FB |
1 | --- |
2 | title: Coding Style | |
3 | --- | |
4 | ||
c1d3483d | 5 | # Coding Style |
82143987 | 6 | |
8c9289e7 LP |
7 | ## Formatting |
8 | ||
3b69b18f ZJS |
9 | - 8ch indent, no tabs, except for files in `man/` which are 2ch indent, and |
10 | still no tabs, and shell scripts, which are 4ch indent, and no tabs either. | |
82143987 | 11 | |
8c9289e7 LP |
12 | - We prefer `/* comments */` over `// comments` in code you commit, |
13 | please. This way `// comments` are left for developers to use for local, | |
14 | temporary commenting of code for debug purposes (i.e. uncommittable stuff), | |
15 | making such comments easily discernible from explanatory, documenting code | |
16 | comments (i.e. committable stuff). | |
82143987 FA |
17 | |
18 | - Don't break code lines too eagerly. We do **not** force line breaks at 80ch, | |
19 | all of today's screens should be much larger than that. But then again, don't | |
c90ee834 | 20 | overdo it, ~109ch should be enough really. The `.editorconfig`, `.vimrc` and |
82143987 | 21 | `.dir-locals.el` files contained in the repository will set this limit up for |
3b69b18f ZJS |
22 | you automatically, if you let them (as well as a few other things). Please |
23 | note that emacs loads `.dir-locals.el` automatically, but vim needs to be | |
24 | configured to load `.vimrc`, see that file for instructions. | |
82143987 | 25 | |
8c9289e7 LP |
26 | - Try to write this: |
27 | ||
28 | ```c | |
29 | void foo() { | |
30 | } | |
31 | ``` | |
32 | ||
33 | instead of this: | |
34 | ||
35 | ```c | |
36 | void foo() | |
37 | { | |
38 | } | |
39 | ``` | |
40 | ||
41 | - Single-line `if` blocks should not be enclosed in `{}`. Write this: | |
42 | ||
43 | ```c | |
44 | if (foobar) | |
45 | waldo(); | |
46 | ``` | |
47 | ||
48 | instead of this: | |
49 | ||
50 | ```c | |
51 | if (foobar) { | |
52 | waldo(); | |
53 | } | |
54 | ``` | |
55 | ||
56 | - Do not write `foo ()`, write `foo()`. | |
57 | ||
b4f12824 | 58 | ## Code Organization and Semantics |
8c9289e7 | 59 | |
78e5b4d7 LP |
60 | - Please name structures in `PascalCase` (with exceptions, such as public API |
61 | structs), variables and functions in `snake_case`. | |
82143987 | 62 | |
b4f12824 LP |
63 | - Avoid static variables, except for caches and very few other cases. Think |
64 | about thread-safety! While most of our code is never used in threaded | |
65 | environments, at least the library code should make sure it works correctly | |
66 | in them. Instead of doing a lot of locking for that, we tend to prefer using | |
67 | TLS to do per-thread caching (which only works for small, fixed-size cache | |
68 | objects), or we disable caching for any thread that is not the main | |
69 | thread. Use `is_main_thread()` to detect whether the calling thread is the | |
70 | main thread. | |
82143987 | 71 | |
82143987 | 72 | - Do not write functions that clobber call-by-reference variables on |
b4f12824 LP |
73 | failure. Use temporary variables for these cases and change the passed in |
74 | variables only on success. | |
82143987 | 75 | |
82143987 | 76 | - The order in which header files are included doesn't matter too |
b4f12824 LP |
77 | much. systemd-internal headers must not rely on an include order, so it is |
78 | safe to include them in any order possible. However, to not clutter global | |
79 | includes, and to make sure internal definitions will not affect global | |
80 | headers, please always include the headers of external components first | |
81 | (these are all headers enclosed in <>), followed by our own exported headers | |
82 | (usually everything that's prefixed by `sd-`), and then followed by internal | |
83 | headers. Furthermore, in all three groups, order all includes alphabetically | |
82143987 FA |
84 | so duplicate includes can easily be detected. |
85 | ||
b4f12824 LP |
86 | - Please avoid using global variables as much as you can. And if you do use |
87 | them make sure they are static at least, instead of exported. Especially in | |
88 | library-like code it is important to avoid global variables. Why are global | |
89 | variables bad? They usually hinder generic reusability of code (since they | |
90 | break in threaded programs, and usually would require locking there), and as | |
91 | the code using them has side-effects make programs non-transparent. That | |
92 | said, there are many cases where they explicitly make a lot of sense, and are | |
93 | OK to use. For example, the log level and target in `log.c` is stored in a | |
94 | global variable, and that's OK and probably expected by most. Also in many | |
95 | cases we cache data in global variables. If you add more caches like this, | |
96 | please be careful however, and think about threading. Only use static | |
97 | variables if you are sure that thread-safety doesn't matter in your | |
98 | case. Alternatively, consider using TLS, which is pretty easy to use with | |
99 | gcc's `thread_local` concept. It's also OK to store data that is inherently | |
100 | global in global variables, for example data parsed from command lines, see | |
82143987 FA |
101 | below. |
102 | ||
82143987 | 103 | - You might wonder what kind of common code belongs in `src/shared/` and what |
a527f70a ZJS |
104 | belongs in `src/basic/`. The split is like this: anything that is used to |
105 | implement the public shared object we provide (sd-bus, sd-login, sd-id128, | |
106 | nss-systemd, nss-mymachines, nss-resolve, nss-myhostname, pam_systemd), must | |
107 | be located in `src/basic` (those objects are not allowed to link to | |
b2454670 | 108 | libsystemd-shared.so). Conversely, anything which is shared between multiple |
a527f70a ZJS |
109 | components and does not need to be in `src/basic/`, should be in |
110 | `src/shared/`. | |
82143987 FA |
111 | |
112 | To summarize: | |
113 | ||
114 | `src/basic/` | |
115 | - may be used by all code in the tree | |
116 | - may not use any code outside of `src/basic/` | |
117 | ||
118 | `src/libsystemd/` | |
119 | - may be used by all code in the tree, except for code in `src/basic/` | |
120 | - may not use any code outside of `src/basic/`, `src/libsystemd/` | |
121 | ||
122 | `src/shared/` | |
a527f70a ZJS |
123 | - may be used by all code in the tree, except for code in `src/basic/`, |
124 | `src/libsystemd/`, `src/nss-*`, `src/login/pam_systemd.*`, and files under | |
125 | `src/journal/` that end up in `libjournal-client.a` convenience library. | |
82143987 FA |
126 | - may not use any code outside of `src/basic/`, `src/libsystemd/`, `src/shared/` |
127 | ||
128 | - Our focus is on the GNU libc (glibc), not any other libcs. If other libcs are | |
129 | incompatible with glibc it's on them. However, if there are equivalent POSIX | |
130 | and Linux/GNU-specific APIs, we generally prefer the POSIX APIs. If there | |
131 | aren't, we are happy to use GNU or Linux APIs, and expect non-GNU | |
132 | implementations of libc to catch up with glibc. | |
133 | ||
78e5b4d7 LP |
134 | ## Using C Constructs |
135 | ||
136 | - Preferably allocate local variables on the top of the block: | |
137 | ||
138 | ```c | |
139 | { | |
140 | int a, b; | |
141 | ||
142 | a = 5; | |
143 | b = a; | |
144 | } | |
145 | ``` | |
146 | ||
147 | - Do not mix function invocations with variable definitions in one line. Wrong: | |
148 | ||
149 | ```c | |
150 | { | |
151 | int a = foobar(); | |
152 | uint64_t x = 7; | |
153 | } | |
154 | ``` | |
155 | ||
156 | Right: | |
157 | ||
158 | ```c | |
159 | { | |
160 | int a; | |
161 | uint64_t x = 7; | |
162 | ||
163 | a = foobar(); | |
164 | } | |
165 | ``` | |
166 | ||
167 | - Use `goto` for cleaning up, and only use it for that. i.e. you may only jump | |
168 | to the end of a function, and little else. Never jump backwards! | |
169 | ||
170 | - To minimize strict aliasing violations, we prefer unions over casting. | |
171 | ||
172 | - Instead of using `memzero()`/`memset()` to initialize structs allocated on | |
173 | the stack, please try to use c99 structure initializers. It's short, prettier | |
174 | and actually even faster at execution. Hence: | |
175 | ||
176 | ```c | |
177 | struct foobar t = { | |
178 | .foo = 7, | |
179 | .bar = "bazz", | |
180 | }; | |
181 | ``` | |
182 | ||
183 | instead of: | |
184 | ||
185 | ```c | |
186 | struct foobar t; | |
187 | zero(t); | |
188 | t.foo = 7; | |
189 | t.bar = "bazz"; | |
190 | ``` | |
191 | ||
192 | - To implement an endless loop, use `for (;;)` rather than `while (1)`. The | |
193 | latter is a bit ugly anyway, since you probably really meant `while | |
194 | (true)`. To avoid the discussion what the right always-true expression for an | |
195 | infinite while loop is, our recommendation is to simply write it without any | |
196 | such expression by using `for (;;)`. | |
197 | ||
198 | - To determine the length of a constant string `"foo"`, don't bother with | |
199 | `sizeof("foo")-1`, please use `strlen()` instead (both gcc and clang optimize | |
200 | the call away for fixed strings). The only exception is when declaring an | |
201 | array. In that case use STRLEN, which evaluates to a static constant and | |
202 | doesn't force the compiler to create a VLA. | |
203 | ||
c159efe3 LP |
204 | ## Destructors |
205 | ||
206 | - The destructors always deregister the object from the next bigger object, not | |
207 | the other way around. | |
208 | ||
209 | - For robustness reasons, destructors should be able to destruct | |
210 | half-initialized objects, too. | |
211 | ||
212 | - When you define a destructor or `unref()` call for an object, please accept a | |
213 | `NULL` object and simply treat this as NOP. This is similar to how libc | |
214 | `free()` works, which accepts `NULL` pointers and becomes a NOP for them. By | |
215 | following this scheme a lot of `if` checks can be removed before invoking | |
216 | your destructor, which makes the code substantially more readable and robust. | |
217 | ||
218 | - Related to this: when you define a destructor or `unref()` call for an | |
219 | object, please make it return the same type it takes and always return `NULL` | |
220 | from it. This allows writing code like this: | |
221 | ||
222 | ```c | |
223 | p = foobar_unref(p); | |
224 | ``` | |
225 | ||
226 | which will always work regardless if `p` is initialized or not,x and | |
227 | guarantees that `p` is `NULL` afterwards, all in just one line. | |
228 | ||
b065e1f1 LP |
229 | ## Error Handling |
230 | ||
231 | - Error codes are returned as negative `Exxx`. e.g. `return -EINVAL`. There are | |
232 | some exceptions: for constructors, it is OK to return `NULL` on OOM. For | |
233 | lookup functions, `NULL` is fine too for "not found". | |
234 | ||
235 | Be strict with this. When you write a function that can fail due to more than | |
236 | one cause, it *really* should have an `int` as the return value for the error | |
237 | code. | |
238 | ||
239 | - Do not bother with error checking whether writing to stdout/stderr worked. | |
240 | ||
241 | - Do not log errors from "library" code, only do so from "main program" | |
242 | code. (With one exception: it is OK to log with DEBUG level from any code, | |
243 | with the exception of maybe inner loops). | |
244 | ||
245 | - In public API calls, you **must** validate all your input arguments for | |
246 | programming error with `assert_return()` and return a sensible return | |
247 | code. In all other calls, it is recommended to check for programming errors | |
248 | with a more brutal `assert()`. We are more forgiving to public users than for | |
249 | ourselves! Note that `assert()` and `assert_return()` really only should be | |
250 | used for detecting programming errors, not for runtime errors. `assert()` and | |
251 | `assert_return()` by usage of `_likely_()` inform the compiler that he should | |
252 | not expect these checks to fail, and they inform fellow programmers about the | |
253 | expected validity and range of parameters. | |
254 | ||
255 | - When you invoke certain calls like `unlink()`, or `mkdir_p()` and you know it | |
256 | is safe to ignore the error it might return (because a later call would | |
257 | detect the failure anyway, or because the error is in an error path and you | |
258 | thus couldn't do anything about it anyway), then make this clear by casting | |
259 | the invocation explicitly to `(void)`. Code checks like Coverity understand | |
260 | that, and will not complain about ignored error codes. Hence, please use | |
261 | this: | |
262 | ||
263 | ```c | |
264 | (void) unlink("/foo/bar/baz"); | |
265 | ``` | |
266 | ||
267 | instead of just this: | |
268 | ||
269 | ```c | |
270 | unlink("/foo/bar/baz"); | |
271 | ``` | |
272 | ||
273 | Don't cast function calls to `(void)` that return no error | |
274 | conditions. Specifically, the various `xyz_unref()` calls that return a | |
275 | `NULL` object shouldn't be cast to `(void)`, since not using the return value | |
276 | does not hide any errors. | |
277 | ||
278 | - When returning a return code from `main()`, please preferably use | |
279 | `EXIT_FAILURE` and `EXIT_SUCCESS` as defined by libc. | |
280 | ||
96f6cfbf LP |
281 | ## Logging |
282 | ||
283 | - For every function you add, think about whether it is a "logging" function or | |
284 | a "non-logging" function. "Logging" functions do logging on their own, | |
285 | "non-logging" function never log on their own and expect their callers to | |
286 | log. All functions in "library" code, i.e. in `src/shared/` and suchlike must | |
287 | be "non-logging". Every time a "logging" function calls a "non-logging" | |
288 | function, it should log about the resulting errors. If a "logging" function | |
289 | calls another "logging" function, then it should not generate log messages, | |
290 | so that log messages are not generated twice for the same errors. | |
291 | ||
292 | - If possible, do a combined log & return operation: | |
293 | ||
294 | ```c | |
295 | r = operation(...); | |
296 | if (r < 0) | |
297 | return log_(error|warning|notice|...)_errno(r, "Failed to ...: %m"); | |
298 | ``` | |
299 | ||
300 | If the error value is "synthetic", i.e. it was not received from | |
301 | the called function, use `SYNTHETIC_ERRNO` wrapper to tell the logging | |
302 | system to not log the errno value, but still return it: | |
303 | ||
304 | ```c | |
305 | n = read(..., s, sizeof s); | |
306 | if (n != sizeof s) | |
307 | return log_error_errno(SYNTHETIC_ERRNO(EIO), "Failed to read ..."); | |
308 | ``` | |
309 | ||
04858240 LP |
310 | ## Memory Allocation |
311 | ||
312 | - Always check OOM. There is no excuse. In program code, you can use | |
313 | `log_oom()` for then printing a short message, but not in "library" code. | |
314 | ||
315 | - Avoid fixed-size string buffers, unless you really know the maximum size and | |
316 | that maximum size is small. They are a source of errors, since they possibly | |
317 | result in truncated strings. It is often nicer to use dynamic memory, | |
318 | `alloca()` or VLAs. If you do allocate fixed-size strings on the stack, then | |
319 | it is probably only OK if you either use a maximum size such as `LINE_MAX`, | |
320 | or count in detail the maximum size a string can have. (`DECIMAL_STR_MAX` and | |
321 | `DECIMAL_STR_WIDTH` macros are your friends for this!) | |
322 | ||
323 | Or in other words, if you use `char buf[256]` then you are likely doing | |
324 | something wrong! | |
325 | ||
326 | - Make use of `_cleanup_free_` and friends. It makes your code much nicer to | |
327 | read (and shorter)! | |
328 | ||
329 | - Use `alloca()`, but never forget that it is not OK to invoke `alloca()` | |
330 | within a loop or within function call parameters. `alloca()` memory is | |
331 | released at the end of a function, and not at the end of a `{}` block. Thus, | |
332 | if you invoke it in a loop, you keep increasing the stack pointer without | |
333 | ever releasing memory again. (VLAs have better behavior in this case, so | |
334 | consider using them as an alternative.) Regarding not using `alloca()` | |
335 | within function parameters, see the BUGS section of the `alloca(3)` man page. | |
336 | ||
337 | - If you want to concatenate two or more strings, consider using `strjoina()` | |
338 | or `strjoin()` rather than `asprintf()`, as the latter is a lot slower. This | |
339 | matters particularly in inner loops (but note that `strjoina()` cannot be | |
340 | used there). | |
341 | ||
4467d393 LP |
342 | ## Runtime Behaviour |
343 | ||
344 | - Avoid leaving long-running child processes around, i.e. `fork()`s that are | |
345 | not followed quickly by an `execv()` in the child. Resource management is | |
346 | unclear in this case, and memory CoW will result in unexpected penalties in | |
347 | the parent much, much later on. | |
348 | ||
349 | - Don't block execution for arbitrary amounts of time using `usleep()` or a | |
350 | similar call, unless you really know what you do. Just "giving something some | |
351 | time", or so is a lazy excuse. Always wait for the proper event, instead of | |
352 | doing time-based poll loops. | |
353 | ||
354 | - Whenever installing a signal handler, make sure to set `SA_RESTART` for it, | |
355 | so that interrupted system calls are automatically restarted, and we minimize | |
356 | hassles with handling `EINTR` (in particular as `EINTR` handling is pretty | |
357 | broken on Linux). | |
358 | ||
359 | - When applying C-style unescaping as well as specifier expansion on the same | |
360 | string, always apply the C-style unescaping fist, followed by the specifier | |
361 | expansion. When doing the reverse, make sure to escape `%` in specifier-style | |
362 | first (i.e. `%` → `%%`), and then do C-style escaping where necessary. | |
363 | ||
364 | - Be exceptionally careful when formatting and parsing floating point | |
365 | numbers. Their syntax is locale dependent (i.e. `5.000` in en_US is generally | |
366 | understood as 5, while in de_DE as 5000.). | |
367 | ||
368 | - Make sure to enforce limits on every user controllable resource. If the user | |
369 | can allocate resources in your code, your code must enforce some form of | |
370 | limits after which it will refuse operation. It's fine if it is hard-coded | |
371 | (at least initially), but it needs to be there. This is particularly | |
372 | important for objects that unprivileged users may allocate, but also matters | |
373 | for everything else any user may allocated. | |
374 | ||
f42c1cd4 LP |
375 | ## Types |
376 | ||
377 | - Think about the types you use. If a value cannot sensibly be negative, do not | |
378 | use `int`, but use `unsigned`. | |
379 | ||
380 | - Use `char` only for actual characters. Use `uint8_t` or `int8_t` when you | |
381 | actually mean a byte-sized signed or unsigned integers. When referring to a | |
382 | generic byte, we generally prefer the unsigned variant `uint8_t`. Do not use | |
383 | types based on `short`. They *never* make sense. Use `int`, `long`, `long | |
384 | long`, all in unsigned and signed fashion, and the fixed-size types | |
385 | `uint8_t`, `uint16_t`, `uint32_t`, `uint64_t`, `int8_t`, `int16_t`, `int32_t` | |
386 | and so on, as well as `size_t`, but nothing else. Do not use kernel types | |
387 | like `u32` and so on, leave that to the kernel. | |
388 | ||
389 | - Stay uniform. For example, always use `usec_t` for time values. Do not mix | |
390 | `usec` and `msec`, and `usec` and whatnot. | |
391 | ||
392 | - Never use the `off_t` type, and particularly avoid it in public APIs. It's | |
393 | really weirdly defined, as it usually is 64-bit and we don't support it any | |
394 | other way, but it could in theory also be 32-bit. Which one it is depends on | |
395 | a compiler switch chosen by the compiled program, which hence corrupts APIs | |
396 | using it unless they can also follow the program's choice. Moreover, in | |
397 | systemd we should parse values the same way on all architectures and cannot | |
398 | expose `off_t` values over D-Bus. To avoid any confusion regarding conversion | |
399 | and ABIs, always use simply `uint64_t` directly. | |
400 | ||
401 | - Unless you allocate an array, `double` is always a better choice than | |
402 | `float`. Processors speak `double` natively anyway, so there is no speed | |
403 | benefit, and on calls like `printf()` `float`s get promoted to `double`s | |
404 | anyway, so there is no point. | |
405 | ||
406 | - Use the bool type for booleans, not integers. One exception: in public | |
407 | headers (i.e those in `src/systemd/sd-*.h`) use integers after all, as `bool` | |
408 | is C99 and in our public APIs we try to stick to C89 (with a few extension). | |
409 | ||
3b75e079 LP |
410 | ## Deadlocks |
411 | ||
412 | - Do not issue NSS requests (that includes user name and host name lookups) | |
413 | from PID 1 as this might trigger deadlocks when those lookups involve | |
414 | synchronously talking to services that we would need to start up. | |
415 | ||
416 | - Do not synchronously talk to any other service from PID 1, due to risk of | |
417 | deadlocks. | |
418 | ||
25553cd9 LP |
419 | ## File Descriptors |
420 | ||
421 | - When you allocate a file descriptor, it should be made `O_CLOEXEC` right from | |
422 | the beginning, as none of our files should leak to forked binaries by | |
423 | default. Hence, whenever you open a file, `O_CLOEXEC` must be specified, | |
424 | right from the beginning. This also applies to sockets. Effectively, this | |
425 | means that all invocations to: | |
426 | ||
427 | - `open()` must get `O_CLOEXEC` passed, | |
428 | - `socket()` and `socketpair()` must get `SOCK_CLOEXEC` passed, | |
429 | - `recvmsg()` must get `MSG_CMSG_CLOEXEC` set, | |
430 | - `F_DUPFD_CLOEXEC` should be used instead of `F_DUPFD`, and so on, | |
431 | - invocations of `fopen()` should take `e`. | |
432 | ||
433 | - It's a good idea to use `O_NONBLOCK` when opening 'foreign' regular files, | |
434 | i.e. file system objects that are supposed to be regular files whose paths | |
435 | where specified by the user and hence might actually refer to other types of | |
436 | file system objects. This is a good idea so that we don't end up blocking on | |
437 | 'strange' file nodes, for example if the user pointed us to a FIFO or device | |
438 | node which may block when opening. Moreover even for actual regular files | |
439 | `O_NONBLOCK` has a benefit: it bypasses any mandatory lock that might be in | |
440 | effect on the regular file. If in doubt consider turning off `O_NONBLOCK` | |
441 | again after opening. | |
442 | ||
996f119d LP |
443 | ## Command Line |
444 | ||
445 | - If you parse a command line, and want to store the parsed parameters in | |
446 | global variables, please consider prefixing their names with `arg_`. We have | |
447 | been following this naming rule in most of our tools, and we should continue | |
448 | to do so, as it makes it easy to identify command line parameter variables, | |
449 | and makes it clear why it is OK that they are global variables. | |
450 | ||
451 | - Command line option parsing: | |
452 | - Do not print full `help()` on error, be specific about the error. | |
453 | - Do not print messages to stdout on error. | |
454 | - Do not POSIX_ME_HARDER unless necessary, i.e. avoid `+` in option string. | |
455 | ||
56380761 LP |
456 | ## Exporting Symbols |
457 | ||
458 | - Variables and functions **must** be static, unless they have a prototype, and | |
459 | are supposed to be exported. | |
460 | ||
461 | - Public API calls (i.e. functions exported by our shared libraries) | |
462 | must be marked `_public_` and need to be prefixed with `sd_`. No | |
463 | other functions should be prefixed like that. | |
464 | ||
465 | - When exposing public C APIs, be careful what function parameters you make | |
466 | `const`. For example, a parameter taking a context object should probably not | |
467 | be `const`, even if you are writing an otherwise read-only accessor function | |
468 | for it. The reason is that making it `const` fixates the contract that your | |
469 | call won't alter the object ever, as part of the API. However, that's often | |
470 | quite a promise, given that this even prohibits object-internal caching or | |
471 | lazy initialization of object variables. Moreover, it's usually not too | |
472 | useful for client applications. Hence, please be careful and avoid `const` on | |
473 | object parameters, unless you are very sure `const` is appropriate. | |
474 | ||
971dfffa LP |
475 | ## Referencing Concepts |
476 | ||
82143987 FA |
477 | - When referring to a configuration file option in the documentation and such, |
478 | please always suffix it with `=`, to indicate that it is a configuration file | |
479 | setting. | |
480 | ||
481 | - When referring to a command line option in the documentation and such, please | |
482 | always prefix with `--` or `-` (as appropriate), to indicate that it is a | |
483 | command line option. | |
484 | ||
485 | - When referring to a file system path that is a directory, please always | |
486 | suffix it with `/`, to indicate that it is a directory, not a regular file | |
487 | (or other file system object). | |
488 | ||
2d0dce2a LP |
489 | ## Functions to Avoid |
490 | ||
491 | - Use `memzero()` or even better `zero()` instead of `memset(..., 0, ...)` | |
492 | ||
493 | - Please use `streq()` and `strneq()` instead of `strcmp()`, `strncmp()` where | |
494 | applicable (i.e. wherever you just care about equality/inequality, not about | |
495 | the sorting order). | |
496 | ||
497 | - Never use `strtol()`, `atoi()` and similar calls. Use `safe_atoli()`, | |
498 | `safe_atou32()` and suchlike instead. They are much nicer to use in most | |
499 | cases and correctly check for parsing errors. | |
500 | ||
501 | - `htonl()`/`ntohl()` and `htons()`/`ntohs()` are weird. Please use `htobe32()` | |
502 | and `htobe16()` instead, it's much more descriptive, and actually says what | |
503 | really is happening, after all `htonl()` and `htons()` don't operate on | |
504 | `long`s and `short`s as their name would suggest, but on `uint32_t` and | |
505 | `uint16_t`. Also, "network byte order" is just a weird name for "big endian", | |
506 | hence we might want to call it "big endian" right-away. | |
507 | ||
508 | - Please never use `dup()`. Use `fcntl(fd, F_DUPFD_CLOEXEC, 3)` instead. For | |
509 | two reason: first, you want `O_CLOEXEC` set on the new `fd` (see | |
510 | above). Second, `dup()` will happily duplicate your `fd` as 0, 1, 2, | |
511 | i.e. stdin, stdout, stderr, should those `fd`s be closed. Given the special | |
512 | semantics of those `fd`s, it's probably a good idea to avoid | |
513 | them. `F_DUPFD_CLOEXEC` with `3` as parameter avoids them. | |
514 | ||
82143987 FA |
515 | - Don't use `fgets()`, it's too hard to properly handle errors such as overly |
516 | long lines. Use `read_line()` instead, which is our own function that handles | |
517 | this much nicer. | |
2d0dce2a LP |
518 | |
519 | - Don't invoke `exit()`, ever. It is not replacement for proper error | |
520 | handling. Please escalate errors up your call chain, and use normal `return` | |
521 | to exit from the main function of a process. If you `fork()`ed off a child | |
522 | process, please use `_exit()` instead of `exit()`, so that the exit handlers | |
523 | are not run. | |
524 | ||
525 | - We never use the POSIX version of `basename()` (which glibc defines it in | |
526 | `libgen.h`), only the GNU version (which glibc defines in `string.h`). The | |
527 | only reason to include `libgen.h` is because `dirname()` is needed. Every | |
528 | time you need that please immediately undefine `basename()`, and add a | |
529 | comment about it, so that no code ever ends up using the POSIX version! | |
831781b9 LP |
530 | |
531 | # Committing to git | |
532 | ||
533 | - Commit message subject lines should be prefixed with an appropriate component | |
534 | name of some kind. For example "journal: ", "nspawn: " and so on. | |
535 | ||
536 | - Do not use "Signed-Off-By:" in your commit messages. That's a kernel thing we | |
537 | don't do in the systemd project. |