]> git.ipfire.org Git - thirdparty/kernel/linux.git/blame - fs/overlayfs/copy_up.c
ovl: verify index dir matches upper dir
[thirdparty/kernel/linux.git] / fs / overlayfs / copy_up.c
CommitLineData
e9be9d5e
MS
1/*
2 *
3 * Copyright (C) 2011 Novell Inc.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 */
9
fb5bb2c3 10#include <linux/module.h>
e9be9d5e
MS
11#include <linux/fs.h>
12#include <linux/slab.h>
13#include <linux/file.h>
14#include <linux/splice.h>
15#include <linux/xattr.h>
16#include <linux/security.h>
17#include <linux/uaccess.h>
174cd4b1 18#include <linux/sched/signal.h>
5b825c3a 19#include <linux/cred.h>
e9be9d5e 20#include <linux/namei.h>
fb5bb2c3
DH
21#include <linux/fdtable.h>
22#include <linux/ratelimit.h>
3a1e819b 23#include <linux/exportfs.h>
e9be9d5e 24#include "overlayfs.h"
d8514d8e 25#include "ovl_entry.h"
e9be9d5e
MS
26
27#define OVL_COPY_UP_CHUNK_SIZE (1 << 20)
28
fb5bb2c3
DH
29static bool __read_mostly ovl_check_copy_up;
30module_param_named(check_copy_up, ovl_check_copy_up, bool,
31 S_IWUSR | S_IRUGO);
32MODULE_PARM_DESC(ovl_check_copy_up,
33 "Warn on copy-up when causing process also has a R/O fd open");
34
35static int ovl_check_fd(const void *data, struct file *f, unsigned int fd)
36{
37 const struct dentry *dentry = data;
38
45063097 39 if (file_inode(f) == d_inode(dentry))
fb5bb2c3
DH
40 pr_warn_ratelimited("overlayfs: Warning: Copying up %pD, but open R/O on fd %u which will cease to be coherent [pid=%d %s]\n",
41 f, fd, current->pid, current->comm);
42 return 0;
43}
44
45/*
46 * Check the fds open by this process and warn if something like the following
47 * scenario is about to occur:
48 *
49 * fd1 = open("foo", O_RDONLY);
50 * fd2 = open("foo", O_RDWR);
51 */
52static void ovl_do_check_copy_up(struct dentry *dentry)
53{
54 if (ovl_check_copy_up)
55 iterate_fd(current->files, 0, ovl_check_fd, dentry);
56}
57
e9be9d5e
MS
58int ovl_copy_xattr(struct dentry *old, struct dentry *new)
59{
e4ad29fa
VC
60 ssize_t list_size, size, value_size = 0;
61 char *buf, *name, *value = NULL;
62 int uninitialized_var(error);
8b326c61 63 size_t slen;
e9be9d5e 64
5d6c3191
AG
65 if (!(old->d_inode->i_opflags & IOP_XATTR) ||
66 !(new->d_inode->i_opflags & IOP_XATTR))
e9be9d5e
MS
67 return 0;
68
69 list_size = vfs_listxattr(old, NULL, 0);
70 if (list_size <= 0) {
71 if (list_size == -EOPNOTSUPP)
72 return 0;
73 return list_size;
74 }
75
76 buf = kzalloc(list_size, GFP_KERNEL);
77 if (!buf)
78 return -ENOMEM;
79
e9be9d5e
MS
80 list_size = vfs_listxattr(old, buf, list_size);
81 if (list_size <= 0) {
82 error = list_size;
e4ad29fa 83 goto out;
e9be9d5e
MS
84 }
85
8b326c61
MS
86 for (name = buf; list_size; name += slen) {
87 slen = strnlen(name, list_size) + 1;
88
89 /* underlying fs providing us with an broken xattr list? */
90 if (WARN_ON(slen > list_size)) {
91 error = -EIO;
92 break;
93 }
94 list_size -= slen;
95
0956254a
MS
96 if (ovl_is_private_xattr(name))
97 continue;
e4ad29fa
VC
98retry:
99 size = vfs_getxattr(old, name, value, value_size);
100 if (size == -ERANGE)
101 size = vfs_getxattr(old, name, NULL, 0);
102
97daf8b9 103 if (size < 0) {
e9be9d5e 104 error = size;
e4ad29fa 105 break;
e9be9d5e 106 }
e4ad29fa
VC
107
108 if (size > value_size) {
109 void *new;
110
111 new = krealloc(value, size, GFP_KERNEL);
112 if (!new) {
113 error = -ENOMEM;
114 break;
115 }
116 value = new;
117 value_size = size;
118 goto retry;
119 }
120
121ab822
VG
121 error = security_inode_copy_up_xattr(name);
122 if (error < 0 && error != -EOPNOTSUPP)
123 break;
124 if (error == 1) {
125 error = 0;
126 continue; /* Discard */
127 }
e9be9d5e
MS
128 error = vfs_setxattr(new, name, value, size, 0);
129 if (error)
e4ad29fa 130 break;
e9be9d5e 131 }
e9be9d5e
MS
132 kfree(value);
133out:
134 kfree(buf);
135 return error;
136}
137
138static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
139{
140 struct file *old_file;
141 struct file *new_file;
142 loff_t old_pos = 0;
143 loff_t new_pos = 0;
144 int error = 0;
145
146 if (len == 0)
147 return 0;
148
0480334f 149 old_file = ovl_path_open(old, O_LARGEFILE | O_RDONLY);
e9be9d5e
MS
150 if (IS_ERR(old_file))
151 return PTR_ERR(old_file);
152
0480334f 153 new_file = ovl_path_open(new, O_LARGEFILE | O_WRONLY);
e9be9d5e
MS
154 if (IS_ERR(new_file)) {
155 error = PTR_ERR(new_file);
156 goto out_fput;
157 }
158
2ea98466
AG
159 /* Try to use clone_file_range to clone up within the same fs */
160 error = vfs_clone_file_range(old_file, 0, new_file, 0, len);
161 if (!error)
162 goto out;
163 /* Couldn't clone, so now we try to copy the data */
164 error = 0;
165
e9be9d5e
MS
166 /* FIXME: copy up sparse files efficiently */
167 while (len) {
168 size_t this_len = OVL_COPY_UP_CHUNK_SIZE;
169 long bytes;
170
171 if (len < this_len)
172 this_len = len;
173
174 if (signal_pending_state(TASK_KILLABLE, current)) {
175 error = -EINTR;
176 break;
177 }
178
179 bytes = do_splice_direct(old_file, &old_pos,
180 new_file, &new_pos,
181 this_len, SPLICE_F_MOVE);
182 if (bytes <= 0) {
183 error = bytes;
184 break;
185 }
186 WARN_ON(old_pos != new_pos);
187
188 len -= bytes;
189 }
2ea98466 190out:
641089c1
MS
191 if (!error)
192 error = vfs_fsync(new_file, 0);
e9be9d5e
MS
193 fput(new_file);
194out_fput:
195 fput(old_file);
196 return error;
197}
198
e9be9d5e
MS
199static int ovl_set_timestamps(struct dentry *upperdentry, struct kstat *stat)
200{
201 struct iattr attr = {
202 .ia_valid =
203 ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET,
204 .ia_atime = stat->atime,
205 .ia_mtime = stat->mtime,
206 };
207
208 return notify_change(upperdentry, &attr, NULL);
209}
210
211int ovl_set_attr(struct dentry *upperdentry, struct kstat *stat)
212{
213 int err = 0;
214
215 if (!S_ISLNK(stat->mode)) {
216 struct iattr attr = {
217 .ia_valid = ATTR_MODE,
218 .ia_mode = stat->mode,
219 };
220 err = notify_change(upperdentry, &attr, NULL);
221 }
222 if (!err) {
223 struct iattr attr = {
224 .ia_valid = ATTR_UID | ATTR_GID,
225 .ia_uid = stat->uid,
226 .ia_gid = stat->gid,
227 };
228 err = notify_change(upperdentry, &attr, NULL);
229 }
230 if (!err)
231 ovl_set_timestamps(upperdentry, stat);
232
233 return err;
e9be9d5e
MS
234}
235
54fb347e 236struct ovl_fh *ovl_encode_fh(struct dentry *lower, bool is_upper)
3a1e819b
AG
237{
238 struct ovl_fh *fh;
239 int fh_type, fh_len, dwords;
240 void *buf;
241 int buflen = MAX_HANDLE_SZ;
02bcd157 242 uuid_t *uuid = &lower->d_sb->s_uuid;
3a1e819b
AG
243
244 buf = kmalloc(buflen, GFP_TEMPORARY);
245 if (!buf)
246 return ERR_PTR(-ENOMEM);
247
248 /*
249 * We encode a non-connectable file handle for non-dir, because we
250 * only need to find the lower inode number and we don't want to pay
251 * the price or reconnecting the dentry.
252 */
253 dwords = buflen >> 2;
254 fh_type = exportfs_encode_fh(lower, buf, &dwords, 0);
255 buflen = (dwords << 2);
256
257 fh = ERR_PTR(-EIO);
258 if (WARN_ON(fh_type < 0) ||
259 WARN_ON(buflen > MAX_HANDLE_SZ) ||
260 WARN_ON(fh_type == FILEID_INVALID))
261 goto out;
262
263 BUILD_BUG_ON(MAX_HANDLE_SZ + offsetof(struct ovl_fh, fid) > 255);
264 fh_len = offsetof(struct ovl_fh, fid) + buflen;
265 fh = kmalloc(fh_len, GFP_KERNEL);
266 if (!fh) {
267 fh = ERR_PTR(-ENOMEM);
268 goto out;
269 }
270
271 fh->version = OVL_FH_VERSION;
272 fh->magic = OVL_FH_MAGIC;
273 fh->type = fh_type;
274 fh->flags = OVL_FH_FLAG_CPU_ENDIAN;
54fb347e
AG
275 /*
276 * When we will want to decode an overlay dentry from this handle
277 * and all layers are on the same fs, if we get a disconncted real
278 * dentry when we decode fid, the only way to tell if we should assign
279 * it to upperdentry or to lowerstack is by checking this flag.
280 */
281 if (is_upper)
282 fh->flags |= OVL_FH_FLAG_PATH_UPPER;
3a1e819b
AG
283 fh->len = fh_len;
284 fh->uuid = *uuid;
285 memcpy(fh->fid, buf, buflen);
286
287out:
288 kfree(buf);
289 return fh;
290}
291
292static int ovl_set_origin(struct dentry *dentry, struct dentry *lower,
293 struct dentry *upper)
294{
3a1e819b
AG
295 const struct ovl_fh *fh = NULL;
296 int err;
297
298 /*
299 * When lower layer doesn't support export operations store a 'null' fh,
300 * so we can use the overlay.origin xattr to distignuish between a copy
301 * up and a pure upper inode.
302 */
02bcd157 303 if (ovl_can_decode_fh(lower->d_sb)) {
54fb347e 304 fh = ovl_encode_fh(lower, false);
3a1e819b
AG
305 if (IS_ERR(fh))
306 return PTR_ERR(fh);
307 }
308
6266d465
MS
309 /*
310 * Do not fail when upper doesn't support xattrs.
311 */
312 err = ovl_check_setxattr(dentry, upper, OVL_XATTR_ORIGIN, fh,
313 fh ? fh->len : 0, 0);
3a1e819b
AG
314 kfree(fh);
315
316 return err;
317}
318
e9be9d5e
MS
319static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir,
320 struct dentry *dentry, struct path *lowerpath,
42f269b9 321 struct kstat *stat, const char *link,
d8514d8e 322 struct kstat *pstat, bool tmpfile)
e9be9d5e
MS
323{
324 struct inode *wdir = workdir->d_inode;
325 struct inode *udir = upperdir->d_inode;
326 struct dentry *newdentry = NULL;
327 struct dentry *upper = NULL;
42f269b9 328 struct dentry *temp = NULL;
e9be9d5e 329 int err;
d8ad8b49
VG
330 const struct cred *old_creds = NULL;
331 struct cred *new_creds = NULL;
32a3d848
AV
332 struct cattr cattr = {
333 /* Can't properly set mode on creation because of the umask */
334 .mode = stat->mode & S_IFMT,
335 .rdev = stat->rdev,
336 .link = link
337 };
e9be9d5e 338
d8ad8b49
VG
339 err = security_inode_copy_up(dentry, &new_creds);
340 if (err < 0)
e85f82ff 341 goto out;
d8ad8b49
VG
342
343 if (new_creds)
344 old_creds = override_creds(new_creds);
345
d8514d8e
AG
346 if (tmpfile)
347 temp = ovl_do_tmpfile(upperdir, stat->mode);
348 else
3d27573c 349 temp = ovl_lookup_temp(workdir);
d8514d8e 350 err = 0;
8137ae26
AG
351 if (IS_ERR(temp)) {
352 err = PTR_ERR(temp);
353 temp = NULL;
354 }
355
356 if (!err && !tmpfile)
d8514d8e 357 err = ovl_create_real(wdir, temp, &cattr, NULL, true);
d8ad8b49
VG
358
359 if (new_creds) {
360 revert_creds(old_creds);
361 put_cred(new_creds);
362 }
363
e9be9d5e 364 if (err)
e85f82ff 365 goto out;
e9be9d5e
MS
366
367 if (S_ISREG(stat->mode)) {
368 struct path upperpath;
f134f244 369
e9be9d5e
MS
370 ovl_path_upper(dentry, &upperpath);
371 BUG_ON(upperpath.dentry != NULL);
42f269b9 372 upperpath.dentry = temp;
e9be9d5e 373
01ad3eb8
AG
374 if (tmpfile) {
375 inode_unlock(udir);
376 err = ovl_copy_up_data(lowerpath, &upperpath,
377 stat->size);
378 inode_lock_nested(udir, I_MUTEX_PARENT);
379 } else {
380 err = ovl_copy_up_data(lowerpath, &upperpath,
381 stat->size);
382 }
e9be9d5e 383
e9be9d5e
MS
384 if (err)
385 goto out_cleanup;
386 }
387
42f269b9 388 err = ovl_copy_xattr(lowerpath->dentry, temp);
e9be9d5e
MS
389 if (err)
390 goto out_cleanup;
391
42f269b9
AG
392 inode_lock(temp->d_inode);
393 err = ovl_set_attr(temp, stat);
394 inode_unlock(temp->d_inode);
e9be9d5e
MS
395 if (err)
396 goto out_cleanup;
397
3a1e819b
AG
398 /*
399 * Store identifier of lower inode in upper inode xattr to
400 * allow lookup of the copy up origin inode.
fbaf94ee
MS
401 *
402 * Don't set origin when we are breaking the association with a lower
403 * hard link.
3a1e819b 404 */
fbaf94ee
MS
405 if (S_ISDIR(stat->mode) || stat->nlink == 1) {
406 err = ovl_set_origin(dentry, lowerpath->dentry, temp);
407 if (err)
408 goto out_cleanup;
409 }
3a1e819b 410
e85f82ff
MS
411 upper = lookup_one_len(dentry->d_name.name, upperdir,
412 dentry->d_name.len);
413 if (IS_ERR(upper)) {
414 err = PTR_ERR(upper);
415 upper = NULL;
416 goto out_cleanup;
417 }
418
d8514d8e
AG
419 if (tmpfile)
420 err = ovl_do_link(temp, udir, upper, true);
421 else
422 err = ovl_do_rename(wdir, temp, udir, upper, 0);
e9be9d5e
MS
423 if (err)
424 goto out_cleanup;
425
d8514d8e 426 newdentry = dget(tmpfile ? upper : temp);
09d8b586 427 ovl_inode_update(d_inode(dentry), newdentry);
42f269b9
AG
428
429 /* Restore timestamps on parent (best effort) */
430 ovl_set_timestamps(upperdir, pstat);
e85f82ff 431out:
42f269b9 432 dput(temp);
42f269b9 433 dput(upper);
e9be9d5e
MS
434 return err;
435
436out_cleanup:
d8514d8e
AG
437 if (!tmpfile)
438 ovl_cleanup(wdir, temp);
e85f82ff 439 goto out;
e9be9d5e
MS
440}
441
442/*
443 * Copy up a single dentry
444 *
a6c60655
MS
445 * All renames start with copy up of source if necessary. The actual
446 * rename will only proceed once the copy up was successful. Copy up uses
447 * upper parent i_mutex for exclusion. Since rename can change d_parent it
448 * is possible that the copy up will lock the old parent. At that point
449 * the file will have already been copied up anyway.
e9be9d5e 450 */
9aba6521
AG
451static int ovl_copy_up_one(struct dentry *parent, struct dentry *dentry,
452 struct path *lowerpath, struct kstat *stat)
e9be9d5e 453{
7764235b 454 DEFINE_DELAYED_CALL(done);
e9be9d5e
MS
455 struct dentry *workdir = ovl_workdir(dentry);
456 int err;
457 struct kstat pstat;
458 struct path parentpath;
7764235b 459 struct dentry *lowerdentry = lowerpath->dentry;
e9be9d5e 460 struct dentry *upperdir;
7764235b 461 const char *link = NULL;
d8514d8e 462 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
e9be9d5e 463
cc6f67bc
MS
464 if (WARN_ON(!workdir))
465 return -EROFS;
466
7764235b 467 ovl_do_check_copy_up(lowerdentry);
fb5bb2c3 468
e9be9d5e
MS
469 ovl_path_upper(parent, &parentpath);
470 upperdir = parentpath.dentry;
471
f3a15685
AG
472 /* Mark parent "impure" because it may now contain non-pure upper */
473 err = ovl_set_impure(parent, upperdir);
474 if (err)
475 return err;
476
a528d35e
DH
477 err = vfs_getattr(&parentpath, &pstat,
478 STATX_ATIME | STATX_MTIME, AT_STATX_SYNC_AS_STAT);
e9be9d5e
MS
479 if (err)
480 return err;
481
482 if (S_ISLNK(stat->mode)) {
7764235b 483 link = vfs_get_link(lowerdentry, &done);
e9be9d5e
MS
484 if (IS_ERR(link))
485 return PTR_ERR(link);
486 }
487
01ad3eb8
AG
488 /* Should we copyup with O_TMPFILE or with workdir? */
489 if (S_ISREG(stat->mode) && ofs->tmpfile) {
490 err = ovl_copy_up_start(dentry);
491 /* err < 0: interrupted, err > 0: raced with another copy-up */
492 if (unlikely(err)) {
493 pr_debug("ovl_copy_up_start(%pd2) = %i\n", dentry, err);
494 if (err > 0)
495 err = 0;
496 goto out_done;
497 }
498
499 inode_lock_nested(upperdir->d_inode, I_MUTEX_PARENT);
500 err = ovl_copy_up_locked(workdir, upperdir, dentry, lowerpath,
501 stat, link, &pstat, true);
502 inode_unlock(upperdir->d_inode);
503 ovl_copy_up_end(dentry);
504 goto out_done;
505 }
506
e9be9d5e
MS
507 err = -EIO;
508 if (lock_rename(workdir, upperdir) != NULL) {
509 pr_err("overlayfs: failed to lock workdir+upperdir\n");
510 goto out_unlock;
511 }
a6c60655 512 if (ovl_dentry_upper(dentry)) {
0f7ff2da 513 /* Raced with another copy-up? Nothing to do, then... */
e9be9d5e 514 err = 0;
0f7ff2da 515 goto out_unlock;
e9be9d5e
MS
516 }
517
518 err = ovl_copy_up_locked(workdir, upperdir, dentry, lowerpath,
01ad3eb8 519 stat, link, &pstat, false);
e9be9d5e
MS
520out_unlock:
521 unlock_rename(workdir, upperdir);
01ad3eb8 522out_done:
7764235b 523 do_delayed_call(&done);
e9be9d5e
MS
524
525 return err;
526}
527
9aba6521 528int ovl_copy_up_flags(struct dentry *dentry, int flags)
e9be9d5e 529{
8eac98b8
VG
530 int err = 0;
531 const struct cred *old_cred = ovl_override_creds(dentry->d_sb);
e9be9d5e 532
e9be9d5e
MS
533 while (!err) {
534 struct dentry *next;
535 struct dentry *parent;
536 struct path lowerpath;
537 struct kstat stat;
538 enum ovl_path_type type = ovl_path_type(dentry);
539
1afaba1e 540 if (OVL_TYPE_UPPER(type))
e9be9d5e
MS
541 break;
542
543 next = dget(dentry);
544 /* find the topmost dentry not yet copied up */
545 for (;;) {
546 parent = dget_parent(next);
547
548 type = ovl_path_type(parent);
1afaba1e 549 if (OVL_TYPE_UPPER(type))
e9be9d5e
MS
550 break;
551
552 dput(next);
553 next = parent;
554 }
555
556 ovl_path_lower(next, &lowerpath);
a528d35e
DH
557 err = vfs_getattr(&lowerpath, &stat,
558 STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
9aba6521
AG
559 /* maybe truncate regular file. this has no effect on dirs */
560 if (flags & O_TRUNC)
561 stat.size = 0;
e9be9d5e 562 if (!err)
0f7ff2da 563 err = ovl_copy_up_one(parent, next, &lowerpath, &stat);
e9be9d5e
MS
564
565 dput(parent);
566 dput(next);
567 }
8eac98b8 568 revert_creds(old_cred);
e9be9d5e
MS
569
570 return err;
571}
9aba6521
AG
572
573int ovl_copy_up(struct dentry *dentry)
574{
575 return ovl_copy_up_flags(dentry, 0);
576}