]>
Commit | Line | Data |
---|---|---|
1143c684 SL |
1 | From 512f1fdb9a7096405014d1466fc37e7e7cef2caf Mon Sep 17 00:00:00 2001 |
2 | From: Philipp Zabel <p.zabel@pengutronix.de> | |
3 | Date: Mon, 8 Apr 2019 08:32:49 -0400 | |
4 | Subject: media: coda: clear error return value before picture run | |
5 | ||
6 | [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] | |
7 | ||
8 | The error return value is not written by some firmware codecs, such as | |
9 | MPEG-2 decode on CodaHx4. Clear the error return value before starting | |
10 | the picture run to avoid misinterpreting unrelated values returned by | |
11 | sequence initialization as error return value. | |
12 | ||
13 | Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> | |
14 | Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> | |
15 | Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | |
16 | Signed-off-by: Sasha Levin <sashal@kernel.org> | |
17 | --- | |
18 | drivers/media/platform/coda/coda-bit.c | 3 +++ | |
19 | 1 file changed, 3 insertions(+) | |
20 | ||
21 | diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c | |
22 | index d76511c1c1e3f..a4639813cf35d 100644 | |
23 | --- a/drivers/media/platform/coda/coda-bit.c | |
24 | +++ b/drivers/media/platform/coda/coda-bit.c | |
25 | @@ -1829,6 +1829,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) | |
26 | /* Clear decode success flag */ | |
27 | coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); | |
28 | ||
29 | + /* Clear error return value */ | |
30 | + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); | |
31 | + | |
32 | trace_coda_dec_pic_run(ctx, meta); | |
33 | ||
34 | coda_command_async(ctx, CODA_COMMAND_PIC_RUN); | |
35 | -- | |
36 | 2.20.1 | |
37 |