]>
Commit | Line | Data |
---|---|---|
345c7afc SL |
1 | From 76476ab077b638b2e4e8576522e431544de6fcb9 Mon Sep 17 00:00:00 2001 |
2 | From: Po-Hsu Lin <po-hsu.lin@canonical.com> | |
3 | Date: Thu, 18 Apr 2019 19:57:25 +0800 | |
4 | Subject: selftests/net: correct the return value for run_netsocktests | |
5 | ||
6 | [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ] | |
7 | ||
8 | The run_netsocktests will be marked as passed regardless the actual test | |
9 | result from the ./socket: | |
10 | ||
11 | selftests: net: run_netsocktests | |
12 | ======================================== | |
13 | -------------------- | |
14 | running socket test | |
15 | -------------------- | |
16 | [FAIL] | |
17 | ok 1..6 selftests: net: run_netsocktests [PASS] | |
18 | ||
19 | This is because the test script itself has been successfully executed. | |
20 | Fix this by exit 1 when the test failed. | |
21 | ||
22 | Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> | |
23 | Signed-off-by: David S. Miller <davem@davemloft.net> | |
24 | Signed-off-by: Sasha Levin <sashal@kernel.org> | |
25 | --- | |
26 | tools/testing/selftests/net/run_netsocktests | 2 +- | |
27 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
28 | ||
29 | diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests | |
30 | index 16058bbea7a85..c195b44786627 100755 | |
31 | --- a/tools/testing/selftests/net/run_netsocktests | |
32 | +++ b/tools/testing/selftests/net/run_netsocktests | |
33 | @@ -6,7 +6,7 @@ echo "--------------------" | |
34 | ./socket | |
35 | if [ $? -ne 0 ]; then | |
36 | echo "[FAIL]" | |
37 | + exit 1 | |
38 | else | |
39 | echo "[PASS]" | |
40 | fi | |
41 | - | |
42 | -- | |
43 | 2.20.1 | |
44 |