]>
Commit | Line | Data |
---|---|---|
38edc49d SLM |
1 | From 2b3a0828e3e55b7ef2f89210e492e465257b6c7e Mon Sep 17 00:00:00 2001 |
2 | From: Aditya Pakki <pakki001@umn.edu> | |
3 | Date: Mon, 18 Mar 2019 21:19:56 -0500 | |
4 | Subject: x86/hpet: Prevent potential NULL pointer dereference | |
5 | ||
6 | [ Upstream commit 2e84f116afca3719c9d0a1a78b47b48f75fd5724 ] | |
7 | ||
8 | hpet_virt_address may be NULL when ioremap_nocache fail, but the code lacks | |
9 | a check. | |
10 | ||
11 | Add a check to prevent NULL pointer dereference. | |
12 | ||
13 | Signed-off-by: Aditya Pakki <pakki001@umn.edu> | |
14 | Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | |
15 | Cc: kjlu@umn.edu | |
16 | Cc: Borislav Petkov <bp@alien8.de> | |
17 | Cc: "H. Peter Anvin" <hpa@zytor.com> | |
18 | Cc: Kees Cook <keescook@chromium.org> | |
19 | Cc: Joe Perches <joe@perches.com> | |
20 | Cc: Nicolai Stange <nstange@suse.de> | |
21 | Cc: Roland Dreier <roland@purestorage.com> | |
22 | Link: https://lkml.kernel.org/r/20190319021958.17275-1-pakki001@umn.edu | |
23 | Signed-off-by: Sasha Levin <sashal@kernel.org> | |
24 | --- | |
25 | arch/x86/kernel/hpet.c | 2 ++ | |
26 | 1 file changed, 2 insertions(+) | |
27 | ||
28 | diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c | |
29 | index 3fdc1e53aaac..9cce5504a5c7 100644 | |
30 | --- a/arch/x86/kernel/hpet.c | |
31 | +++ b/arch/x86/kernel/hpet.c | |
32 | @@ -825,6 +825,8 @@ int __init hpet_enable(void) | |
33 | return 0; | |
34 | ||
35 | hpet_set_mapping(); | |
36 | + if (!hpet_virt_address) | |
37 | + return 0; | |
38 | ||
39 | /* | |
40 | * Read the period and check for a sane value: | |
41 | -- | |
42 | 2.19.1 | |
43 |