]>
Commit | Line | Data |
---|---|---|
9ee5bbd1 GKH |
1 | From stable-bounces@linux.kernel.org Fri Apr 25 13:48:07 2008 |
2 | From: Alan Stern <stern@rowland.harvard.edu> | |
3 | Date: Fri, 25 Apr 2008 20:05:46 GMT | |
4 | Subject: USB: OHCI: fix bug in controller resume | |
5 | To: jejb@kernel.org, stable@kernel.org | |
6 | Message-ID: <200804252005.m3PK5kbv013942@hera.kernel.org> | |
7 | ||
8 | From: Alan Stern <stern@rowland.harvard.edu> | |
9 | ||
10 | commit: 0d22f65515307c878ddd20b1305cce925ca9516c | |
11 | ||
12 | This patch (as1063) fixes a bug in the way ohci-hcd resumes its | |
13 | controllers. It leaves the Master Interrupt Enable bit turned off. | |
14 | ||
15 | If the root hub is resumed immediately this won't matter. But if the | |
16 | root hub is suspended (say because no devices are plugged in), it won't | |
17 | ever wake up by itself. | |
18 | ||
19 | Signed-off-by: Alan Stern <stern@rowland.harvard.edu> | |
20 | CC: David Brownell <david-b@pacbell.net> | |
21 | Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | |
22 | ||
23 | --- | |
24 | drivers/usb/host/ohci-pci.c | 4 +++- | |
25 | 1 file changed, 3 insertions(+), 1 deletion(-) | |
26 | ||
27 | --- a/drivers/usb/host/ohci-pci.c | |
28 | +++ b/drivers/usb/host/ohci-pci.c | |
29 | @@ -312,11 +312,13 @@ static int ohci_pci_suspend (struct usb_ | |
30 | ||
31 | static int ohci_pci_resume (struct usb_hcd *hcd) | |
32 | { | |
33 | + struct ohci_hcd *ohci = hcd_to_ohci(hcd); | |
34 | + | |
35 | set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags); | |
36 | ||
37 | /* FIXME: we should try to detect loss of VBUS power here */ | |
38 | prepare_for_handover(hcd); | |
39 | - | |
40 | + ohci_writel(ohci, OHCI_INTR_MIE, &ohci->regs->intrenable); | |
41 | return 0; | |
42 | } | |
43 |