]>
Commit | Line | Data |
---|---|---|
a709ecc8 GKH |
1 | From pingc@wacom.com Wed Apr 21 15:34:14 2010 |
2 | From: Ping Cheng <pingc@wacom.com> | |
3 | Date: Mon, 19 Apr 2010 11:10:50 -0700 | |
4 | Subject: Input: wacom - switch mode upon system resume | |
5 | To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Greg KH" <gregkh@suse.de> | |
6 | Cc: <Anton@anikin.name>, <stable@kernel.org>, <stable-commits@vger.kernel.org> | |
7 | Message-ID: <6753EB6004AFF34FAA275742C104F95201DF6FE3@wacom-nt10.wacom.com> | |
8 | ||
9 | From: Ping Cheng <pingc@wacom.com> | |
10 | ||
11 | commit 014f61504af276ba9d9544d8a7401d8f8526eb73 upstream. | |
12 | ||
13 | When Wacom devices wake up from a sleep, the switch mode command | |
14 | (wacom_query_tablet_data) is needed before wacom_open is called. | |
15 | wacom_query_tablet_data should not be executed inside wacom_open | |
16 | since wacom_open is called more than once during probe. | |
17 | ||
18 | Reported-and-tested-by: Anton Anikin <Anton@Anikin.name> | |
19 | Signed-off-by: Ping Cheng <pingc@wacom.com> | |
20 | Signed-off-by: Dmitry Torokhov <dtor@mail.ru> | |
21 | Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | |
22 | ||
23 | --- | |
24 | drivers/input/tablet/wacom_sys.c | 10 +++++++--- | |
25 | 1 file changed, 7 insertions(+), 3 deletions(-) | |
26 | ||
27 | --- a/drivers/input/tablet/wacom_sys.c | |
28 | +++ b/drivers/input/tablet/wacom_sys.c | |
29 | @@ -562,11 +562,15 @@ static int wacom_resume(struct usb_inter | |
30 | int rv; | |
31 | ||
32 | mutex_lock(&wacom->lock); | |
33 | - if (wacom->open) { | |
34 | + | |
35 | + /* switch to wacom mode first */ | |
36 | + wacom_query_tablet_data(intf); | |
37 | + | |
38 | + if (wacom->open) | |
39 | rv = usb_submit_urb(wacom->irq, GFP_NOIO); | |
40 | - wacom_query_tablet_data(intf); | |
41 | - } else | |
42 | + else | |
43 | rv = 0; | |
44 | + | |
45 | mutex_unlock(&wacom->lock); | |
46 | ||
47 | return rv; |