]>
Commit | Line | Data |
---|---|---|
61ee496e GKH |
1 | From 0350cb078f5035716ebdad4ad4709d02fe466a8a Mon Sep 17 00:00:00 2001 |
2 | From: Dan Carpenter <error27@gmail.com> | |
3 | Date: Thu, 22 Apr 2010 11:39:29 +0200 | |
4 | Subject: ocfs2: potential ERR_PTR dereference on error paths | |
5 | ||
6 | From: Dan Carpenter <error27@gmail.com> | |
7 | ||
8 | commit 0350cb078f5035716ebdad4ad4709d02fe466a8a upstream. | |
9 | ||
10 | If "handle" is non null at the end of the function then we assume it's a | |
11 | valid pointer and pass it to ocfs2_commit_trans(); | |
12 | ||
13 | Signed-off-by: Dan Carpenter <error27@gmail.com> | |
14 | Signed-off-by: Joel Becker <joel.becker@oracle.com> | |
15 | Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | |
16 | ||
17 | --- | |
18 | fs/ocfs2/inode.c | 1 + | |
19 | 1 file changed, 1 insertion(+) | |
20 | ||
21 | --- a/fs/ocfs2/inode.c | |
22 | +++ b/fs/ocfs2/inode.c | |
23 | @@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(str | |
24 | handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); | |
25 | if (IS_ERR(handle)) { | |
26 | status = PTR_ERR(handle); | |
27 | + handle = NULL; | |
28 | mlog_errno(status); | |
29 | goto out; | |
30 | } |