]>
Commit | Line | Data |
---|---|---|
ae06513c GKH |
1 | From 590b0b9754bd8928926bae7194b6da7ead9bda3b Mon Sep 17 00:00:00 2001 |
2 | From: Greg Kroah-Hartman <gregkh@suse.de> | |
3 | Date: Tue, 16 Nov 2010 11:17:01 -0800 | |
4 | Subject: Staging: asus_oled: fix up some sysfs attribute permissions | |
5 | ||
6 | From: Greg Kroah-Hartman <gregkh@suse.de> | |
7 | ||
8 | commit 590b0b9754bd8928926bae7194b6da7ead9bda3b upstream. | |
9 | ||
10 | They should not be writable by any user | |
11 | ||
12 | Reported-by: Linus Torvalds <torvalds@linux-foundation.org> | |
13 | Cc: Jakub Schmidtke <sjakub@gmail.com> | |
14 | Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | |
15 | ||
16 | --- | |
17 | drivers/staging/asus_oled/asus_oled.c | 8 ++++---- | |
18 | 1 file changed, 4 insertions(+), 4 deletions(-) | |
19 | ||
20 | --- a/drivers/staging/asus_oled/asus_oled.c | |
21 | +++ b/drivers/staging/asus_oled/asus_oled.c | |
22 | @@ -620,13 +620,13 @@ static ssize_t class_set_picture(struct | |
23 | ||
24 | #define ASUS_OLED_DEVICE_ATTR(_file) dev_attr_asus_oled_##_file | |
25 | ||
26 | -static DEVICE_ATTR(asus_oled_enabled, S_IWUGO | S_IRUGO, | |
27 | +static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO, | |
28 | get_enabled, set_enabled); | |
29 | -static DEVICE_ATTR(asus_oled_picture, S_IWUGO , NULL, set_picture); | |
30 | +static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture); | |
31 | ||
32 | -static DEVICE_ATTR(enabled, S_IWUGO | S_IRUGO, | |
33 | +static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO, | |
34 | class_get_enabled, class_set_enabled); | |
35 | -static DEVICE_ATTR(picture, S_IWUGO, NULL, class_set_picture); | |
36 | +static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture); | |
37 | ||
38 | static int asus_oled_probe(struct usb_interface *interface, | |
39 | const struct usb_device_id *id) |