]>
Commit | Line | Data |
---|---|---|
7f7c74eb GKH |
1 | From 530fd8e305b59abdb5f2a04069a28d11506ded22 Mon Sep 17 00:00:00 2001 |
2 | From: =?UTF-8?q?Salva=20Peir=C3=B3?= <speiro@ai2.upv.es> | |
3 | Date: Fri, 11 Oct 2013 12:50:03 +0300 | |
4 | Subject: farsync: fix info leak in ioctl | |
5 | ||
6 | From: =?UTF-8?q?Salva=20Peir=C3=B3?= <speiro@ai2.upv.es> | |
7 | ||
8 | [ Upstream commit 96b340406724d87e4621284ebac5e059d67b2194 ] | |
9 | ||
10 | The fst_get_iface() code fails to initialize the two padding bytes of | |
11 | struct sync_serial_settings after the ->loopback member. Add an explicit | |
12 | memset(0) before filling the structure to avoid the info leak. | |
13 | ||
14 | Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> | |
15 | Signed-off-by: David S. Miller <davem@davemloft.net> | |
16 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
17 | --- | |
18 | drivers/net/wan/farsync.c | 1 + | |
19 | 1 file changed, 1 insertion(+) | |
20 | ||
21 | --- a/drivers/net/wan/farsync.c | |
22 | +++ b/drivers/net/wan/farsync.c | |
23 | @@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card | |
24 | } | |
25 | ||
26 | i = port->index; | |
27 | + memset(&sync, 0, sizeof(sync)); | |
28 | sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed); | |
29 | /* Lucky card and linux use same encoding here */ | |
30 | sync.clock_type = FST_RDB(card, portConfig[i].internalClock) == |