]>
Commit | Line | Data |
---|---|---|
fc58cd71 GKH |
1 | From f17bc3f4707eb87bdb80b895911c551cdd606fbd Mon Sep 17 00:00:00 2001 |
2 | From: Philipp Zabel <p.zabel@pengutronix.de> | |
3 | Date: Mon, 26 May 2014 10:55:51 -0300 | |
4 | Subject: media: mt9v032: fix hblank calculation | |
5 | ||
6 | From: Philipp Zabel <p.zabel@pengutronix.de> | |
7 | ||
8 | commit f17bc3f4707eb87bdb80b895911c551cdd606fbd upstream. | |
9 | ||
10 | Since (min_row_time - crop->width) can be negative, we have to do a signed | |
11 | comparison here. Otherwise max_t casts the negative value to unsigned int | |
12 | and sets min_hblank to that invalid value. | |
13 | ||
14 | Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> | |
15 | Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | |
16 | Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> | |
17 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
18 | ||
19 | --- | |
20 | drivers/media/i2c/mt9v032.c | 4 ++-- | |
21 | 1 file changed, 2 insertions(+), 2 deletions(-) | |
22 | ||
23 | --- a/drivers/media/i2c/mt9v032.c | |
24 | +++ b/drivers/media/i2c/mt9v032.c | |
25 | @@ -305,8 +305,8 @@ mt9v032_update_hblank(struct mt9v032 *mt | |
26 | ||
27 | if (mt9v032->version->version == MT9V034_CHIP_ID_REV1) | |
28 | min_hblank += (mt9v032->hratio - 1) * 10; | |
29 | - min_hblank = max_t(unsigned int, (int)mt9v032->model->data->min_row_time - crop->width, | |
30 | - (int)min_hblank); | |
31 | + min_hblank = max_t(int, mt9v032->model->data->min_row_time - crop->width, | |
32 | + min_hblank); | |
33 | hblank = max_t(unsigned int, mt9v032->hblank, min_hblank); | |
34 | ||
35 | return mt9v032_write(client, MT9V032_HORIZONTAL_BLANKING, hblank); |