]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blame - releases/3.19.2/btrfs-fix-lost-return-value-due-to-variable-shadowing.patch
4.14-stable patches
[thirdparty/kernel/stable-queue.git] / releases / 3.19.2 / btrfs-fix-lost-return-value-due-to-variable-shadowing.patch
CommitLineData
103e869f
GKH
1From 1932b7be973b554ffe20a5bba6ffaed6fa995cdc Mon Sep 17 00:00:00 2001
2From: David Sterba <dsterba@suse.cz>
3Date: Tue, 24 Feb 2015 18:57:18 +0100
4Subject: btrfs: fix lost return value due to variable shadowing
5
6From: David Sterba <dsterba@suse.cz>
7
8commit 1932b7be973b554ffe20a5bba6ffaed6fa995cdc upstream.
9
10A block-local variable stores error code but btrfs_get_blocks_direct may
11not return it in the end as there's a ret defined in the function scope.
12
13Fixes: d187663ef24c ("Btrfs: lock extents as we map them in DIO")
14Signed-off-by: David Sterba <dsterba@suse.cz>
15Signed-off-by: Chris Mason <clm@fb.com>
16Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
17
18---
19 fs/btrfs/inode.c | 1 -
20 1 file changed, 1 deletion(-)
21
22--- a/fs/btrfs/inode.c
23+++ b/fs/btrfs/inode.c
24@@ -7208,7 +7208,6 @@ static int btrfs_get_blocks_direct(struc
25 ((BTRFS_I(inode)->flags & BTRFS_INODE_NODATACOW) &&
26 em->block_start != EXTENT_MAP_HOLE)) {
27 int type;
28- int ret;
29 u64 block_start, orig_start, orig_block_len, ram_bytes;
30
31 if (test_bit(EXTENT_FLAG_PREALLOC, &em->flags))