]>
Commit | Line | Data |
---|---|---|
eefdbb8e GKH |
1 | From c5e691928bf166ac03430e957038b60adba3cf6c Mon Sep 17 00:00:00 2001 |
2 | From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> | |
3 | Date: Tue, 24 Mar 2015 09:57:55 -0400 | |
4 | Subject: tools lib traceevent kbuffer: Remove extra update to data pointer in PADDING | |
5 | ||
6 | From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> | |
7 | ||
8 | commit c5e691928bf166ac03430e957038b60adba3cf6c upstream. | |
9 | ||
10 | When a event PADDING is hit (a deleted event that is still in the ring | |
11 | buffer), translate_data() sets the length of the padding and also updates | |
12 | the data pointer which is passed back to the caller. | |
13 | ||
14 | This is unneeded because the caller also updates the data pointer with | |
15 | the passed back length. translate_data() should not update the pointer, | |
16 | only set the length. | |
17 | ||
18 | Signed-off-by: Steven Rostedt <rostedt@goodmis.org> | |
19 | Cc: Andrew Morton <akpm@linux-foundation.org> | |
20 | Cc: Jiri Olsa <jolsa@redhat.com> | |
21 | Cc: Namhyung Kim <namhyung@kernel.org> | |
22 | Link: http://lkml.kernel.org/r/20150324135923.461431960@goodmis.org | |
23 | Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> | |
24 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
25 | ||
26 | --- | |
27 | tools/lib/traceevent/kbuffer-parse.c | 1 - | |
28 | 1 file changed, 1 deletion(-) | |
29 | ||
30 | --- a/tools/lib/traceevent/kbuffer-parse.c | |
31 | +++ b/tools/lib/traceevent/kbuffer-parse.c | |
32 | @@ -372,7 +372,6 @@ translate_data(struct kbuffer *kbuf, voi | |
33 | switch (type_len) { | |
34 | case KBUFFER_TYPE_PADDING: | |
35 | *length = read_4(kbuf, data); | |
36 | - data += *length; | |
37 | break; | |
38 | ||
39 | case KBUFFER_TYPE_TIME_EXTEND: |