projects / thirdparty / kernel / stable-queue.git / blame
| Commit | Line | Data |
|---|---|---|
| ba23ed0e GKH |
1 | From bb9696192826a7d9279caf872e95b41bc26c7eff Mon Sep 17 00:00:00 2001 |
| 2 | From: Tejun Heo <tj@kernel.org> | |
| 3 | Date: Mon, 22 Jul 2013 16:53:36 -0400 | |
| 4 | Subject: libata: make it clear that sata_inic162x is experimental | |
| 5 | ||
| 6 | From: Tejun Heo <tj@kernel.org> | |
| 7 | ||
| 8 | commit bb9696192826a7d9279caf872e95b41bc26c7eff upstream. | |
| 9 | ||
| 10 | sata_inic162x never reached a state where it's reliable enough for | |
| 11 | production use and data corruption is a relatively common occurrence. | |
| 12 | Make the driver generate warning about the issues and mark the Kconfig | |
| 13 | option as experimental. | |
| 14 | ||
| 15 | If the situation doesn't improve, we'd be better off making it depend | |
| 16 | on CONFIG_BROKEN. Let's wait for several cycles and see if the kernel | |
| 17 | message draws any attention. | |
| 18 | ||
| 19 | Signed-off-by: Tejun Heo <tj@kernel.org> | |
| 20 | Reported-by: Martin Braure de Calignon <braurede@free.fr> | |
| 21 | Reported-by: Ben Hutchings <ben@decadent.org.uk> | |
| 22 | Reported-by: risc4all@yahoo.com | |
| 23 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| 24 | ||
| 25 | --- | |
| 26 | drivers/ata/Kconfig | 2 +- | |
| 27 | drivers/ata/sata_inic162x.c | 14 ++++++++++++++ | |
| 28 | 2 files changed, 15 insertions(+), 1 deletion(-) | |
| 29 | ||
| 30 | --- a/drivers/ata/Kconfig | |
| 31 | +++ b/drivers/ata/Kconfig | |
| 32 | @@ -93,7 +93,7 @@ config SATA_FSL | |
| 33 | If unsure, say N. | |
| 34 | ||
| 35 | config SATA_INIC162X | |
| 36 | - tristate "Initio 162x SATA support" | |
| 37 | + tristate "Initio 162x SATA support (Very Experimental)" | |
| 38 | depends on PCI | |
| 39 | help | |
| 40 | This option enables support for Initio 162x Serial ATA. | |
| 41 | --- a/drivers/ata/sata_inic162x.c | |
| 42 | +++ b/drivers/ata/sata_inic162x.c | |
| 43 | @@ -6,6 +6,18 @@ | |
| 44 | * | |
| 45 | * This file is released under GPL v2. | |
| 46 | * | |
| 47 | + * **** WARNING **** | |
| 48 | + * | |
| 49 | + * This driver never worked properly and unfortunately data corruption is | |
| 50 | + * relatively common. There isn't anyone working on the driver and there's | |
| 51 | + * no support from the vendor. Do not use this driver in any production | |
| 52 | + * environment. | |
| 53 | + * | |
| 54 | + * http://thread.gmane.org/gmane.linux.debian.devel.bugs.rc/378525/focus=54491 | |
| 55 | + * https://bugzilla.kernel.org/show_bug.cgi?id=60565 | |
| 56 | + * | |
| 57 | + * ***************** | |
| 58 | + * | |
| 59 | * This controller is eccentric and easily locks up if something isn't | |
| 60 | * right. Documentation is available at initio's website but it only | |
| 61 | * documents registers (not programming model). | |
| 62 | @@ -809,6 +821,8 @@ static int inic_init_one(struct pci_dev | |
| 63 | ||
| 64 | ata_print_version_once(&pdev->dev, DRV_VERSION); | |
| 65 | ||
| 66 | + dev_alert(&pdev->dev, "inic162x support is broken with common data corruption issues and will be disabled by default, contact linux-ide@vger.kernel.org if in production use\n"); | |
| 67 | + | |
| 68 | /* alloc host */ | |
| 69 | host = ata_host_alloc_pinfo(&pdev->dev, ppi, NR_PORTS); | |
| 70 | hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL); |