]>
Commit | Line | Data |
---|---|---|
c7c50bcb GKH |
1 | From 4b961180ef275035b1538317ffd0e21e80e63e77 Mon Sep 17 00:00:00 2001 |
2 | From: Ben Hutchings <ben@decadent.org.uk> | |
3 | Date: Sun, 19 Aug 2012 19:32:27 -0300 | |
4 | Subject: media: rc: ite-cir: Initialise ite_dev::rdev earlier | |
5 | ||
6 | From: Ben Hutchings <ben@decadent.org.uk> | |
7 | ||
8 | commit 4b961180ef275035b1538317ffd0e21e80e63e77 upstream. | |
9 | ||
10 | ite_dev::rdev is currently initialised in ite_probe() after | |
11 | rc_register_device() returns. If a newly registered device is opened | |
12 | quickly enough, we may enable interrupts and try to use ite_dev::rdev | |
13 | before it has been initialised. Move it up to the earliest point we | |
14 | can, right after calling rc_allocate_device(). | |
15 | ||
16 | Reported-and-tested-by: YunQiang Su <wzssyqa@gmail.com> | |
17 | ||
18 | Signed-off-by: Ben Hutchings <ben@decadent.org.uk> | |
19 | Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | |
20 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
21 | ||
22 | --- | |
23 | drivers/media/rc/ite-cir.c | 2 +- | |
24 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
25 | ||
26 | --- a/drivers/media/rc/ite-cir.c | |
27 | +++ b/drivers/media/rc/ite-cir.c | |
28 | @@ -1473,6 +1473,7 @@ static int ite_probe(struct pnp_dev *pde | |
29 | rdev = rc_allocate_device(); | |
30 | if (!rdev) | |
31 | goto failure; | |
32 | + itdev->rdev = rdev; | |
33 | ||
34 | ret = -ENODEV; | |
35 | ||
36 | @@ -1604,7 +1605,6 @@ static int ite_probe(struct pnp_dev *pde | |
37 | if (ret) | |
38 | goto failure3; | |
39 | ||
40 | - itdev->rdev = rdev; | |
41 | ite_pr(KERN_NOTICE, "driver has been successfully loaded\n"); | |
42 | ||
43 | return 0; |