projects / thirdparty / kernel / stable-queue.git / blame
| Commit | Line | Data |
|---|---|---|
| df1b7722 GKH |
1 | From foo@baz Mon Apr 9 13:58:16 CEST 2018 |
| 2 | From: Jason Yan <yanaijie@huawei.com> | |
| 3 | Date: Thu, 4 Jan 2018 21:04:31 +0800 | |
| 4 | Subject: scsi: libsas: fix memory leak in sas_smp_get_phy_events() | |
| 5 | ||
| 6 | From: Jason Yan <yanaijie@huawei.com> | |
| 7 | ||
| 8 | ||
| 9 | [ Upstream commit 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4 ] | |
| 10 | ||
| 11 | We've got a memory leak with the following producer: | |
| 12 | ||
| 13 | while true; | |
| 14 | do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; | |
| 15 | done | |
| 16 | ||
| 17 | The buffer req is allocated and not freed after we return. Fix it. | |
| 18 | ||
| 19 | Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") | |
| 20 | Signed-off-by: Jason Yan <yanaijie@huawei.com> | |
| 21 | CC: John Garry <john.garry@huawei.com> | |
| 22 | CC: chenqilin <chenqilin2@huawei.com> | |
| 23 | CC: chenxiang <chenxiang66@hisilicon.com> | |
| 24 | Reviewed-by: Christoph Hellwig <hch@lst.de> | |
| 25 | Reviewed-by: Hannes Reinecke <hare@suse.com> | |
| 26 | Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> | |
| 27 | Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> | |
| 28 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| 29 | --- | |
| 30 | drivers/scsi/libsas/sas_expander.c | 1 + | |
| 31 | 1 file changed, 1 insertion(+) | |
| 32 | ||
| 33 | --- a/drivers/scsi/libsas/sas_expander.c | |
| 34 | +++ b/drivers/scsi/libsas/sas_expander.c | |
| 35 | @@ -695,6 +695,7 @@ int sas_smp_get_phy_events(struct sas_ph | |
| 36 | phy->phy_reset_problem_count = scsi_to_u32(&resp[24]); | |
| 37 | ||
| 38 | out: | |
| 39 | + kfree(req); | |
| 40 | kfree(resp); | |
| 41 | return res; | |
| 42 |