]>
Commit | Line | Data |
---|---|---|
f85a50aa GKH |
1 | From 18d45b11d96e6f9b3814960a1394083a3d6b7f74 Mon Sep 17 00:00:00 2001 |
2 | From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> | |
3 | Date: Thu, 15 Mar 2018 13:57:55 +0530 | |
4 | Subject: trace_uprobe: Use %lx to display offset | |
5 | ||
6 | From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> | |
7 | ||
8 | commit 18d45b11d96e6f9b3814960a1394083a3d6b7f74 upstream. | |
9 | ||
10 | tu->offset is unsigned long, not a pointer, thus %lx should | |
11 | be used to print it, not the %px. | |
12 | ||
13 | Link: http://lkml.kernel.org/r/20180315082756.9050-1-ravi.bangoria@linux.vnet.ibm.com | |
14 | ||
15 | Cc: stable@vger.kernel.org | |
16 | Acked-by: Masami Hiramatsu <mhiramat@kernel.org> | |
17 | Fixes: 0e4d819d0893 ("trace_uprobe: Display correct offset in uprobe_events") | |
18 | Suggested-by: Kees Cook <keescook@chromium.org> | |
19 | Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> | |
20 | Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> | |
21 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
22 | ||
23 | --- | |
24 | kernel/trace/trace_uprobe.c | 2 +- | |
25 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
26 | ||
27 | --- a/kernel/trace/trace_uprobe.c | |
28 | +++ b/kernel/trace/trace_uprobe.c | |
29 | @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_fi | |
30 | ||
31 | /* Don't print "0x (null)" when offset is 0 */ | |
32 | if (tu->offset) { | |
33 | - seq_printf(m, "0x%px", (void *)tu->offset); | |
34 | + seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset); | |
35 | } else { | |
36 | switch (sizeof(void *)) { | |
37 | case 4: |