]>
Commit | Line | Data |
---|---|---|
a15a8890 SL |
1 | From 4873fe40194cf6f9748e16e7edfe12463735a7d8 Mon Sep 17 00:00:00 2001 |
2 | From: Max Uvarov <muvarov@gmail.com> | |
3 | Date: Tue, 28 May 2019 13:00:52 +0300 | |
4 | Subject: net: phy: dp83867: Set up RGMII TX delay | |
5 | ||
6 | [ Upstream commit 2b892649254fec01678c64f16427622b41fa27f4 ] | |
7 | ||
8 | PHY_INTERFACE_MODE_RGMII_RXID is less then TXID | |
9 | so code to set tx delay is never called. | |
10 | ||
11 | Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") | |
12 | Signed-off-by: Max Uvarov <muvarov@gmail.com> | |
13 | Cc: Florian Fainelli <f.fainelli@gmail.com> | |
14 | Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> | |
15 | Signed-off-by: David S. Miller <davem@davemloft.net> | |
16 | Signed-off-by: Sasha Levin <sashal@kernel.org> | |
17 | --- | |
18 | drivers/net/phy/dp83867.c | 4 +--- | |
19 | 1 file changed, 1 insertion(+), 3 deletions(-) | |
20 | ||
21 | diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c | |
22 | index b3935778b19f..e4bf9e7d7583 100644 | |
23 | --- a/drivers/net/phy/dp83867.c | |
24 | +++ b/drivers/net/phy/dp83867.c | |
25 | @@ -260,10 +260,8 @@ static int dp83867_config_init(struct phy_device *phydev) | |
26 | ret = phy_write(phydev, MII_DP83867_PHYCTRL, val); | |
27 | if (ret) | |
28 | return ret; | |
29 | - } | |
30 | ||
31 | - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) && | |
32 | - (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) { | |
33 | + /* Set up RGMII delays */ | |
34 | val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL); | |
35 | ||
36 | if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) | |
37 | -- | |
38 | 2.20.1 | |
39 |