]>
Commit | Line | Data |
---|---|---|
763299ca GKH |
1 | From 7978db344719dab1e56d05e6fc04aaaddcde0a5e Mon Sep 17 00:00:00 2001 |
2 | From: Tobias Jordan <Tobias.Jordan@elektrobit.com> | |
3 | Date: Wed, 4 Oct 2017 11:35:03 +0530 | |
4 | Subject: PM / OPP: Add missing of_node_put(np) | |
5 | ||
6 | From: Tobias Jordan <Tobias.Jordan@elektrobit.com> | |
7 | ||
8 | commit 7978db344719dab1e56d05e6fc04aaaddcde0a5e upstream. | |
9 | ||
10 | The for_each_available_child_of_node() loop in _of_add_opp_table_v2() | |
11 | doesn't drop the reference to "np" on errors. Fix that. | |
12 | ||
13 | Fixes: 274659029c9d (PM / OPP: Add support to parse "operating-points-v2" bindings) | |
14 | Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com> | |
15 | [ VK: Improved commit log. ] | |
16 | Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> | |
17 | Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> | |
18 | Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> | |
19 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
20 | ||
21 | ||
22 | --- | |
23 | drivers/base/power/opp/core.c | 1 + | |
24 | 1 file changed, 1 insertion(+) | |
25 | ||
26 | --- a/drivers/base/power/opp/core.c | |
27 | +++ b/drivers/base/power/opp/core.c | |
28 | @@ -1205,6 +1205,7 @@ static int _of_add_opp_table_v2(struct d | |
29 | if (ret) { | |
30 | dev_err(dev, "%s: Failed to add OPP, %d\n", __func__, | |
31 | ret); | |
32 | + of_node_put(np); | |
33 | goto free_table; | |
34 | } | |
35 | } |