]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blame - releases/4.4.140/staging-comedi-quatech_daqp_cs-fix-no-op-loop-daqp_ao_insn_write.patch
4.14-stable patches
[thirdparty/kernel/stable-queue.git] / releases / 4.4.140 / staging-comedi-quatech_daqp_cs-fix-no-op-loop-daqp_ao_insn_write.patch
CommitLineData
fb11ba52
GKH
1From 1376b0a2160319125c3a2822e8c09bd283cd8141 Mon Sep 17 00:00:00 2001
2From: Dan Carpenter <dan.carpenter@oracle.com>
3Date: Tue, 5 Jun 2018 12:36:30 +0300
4Subject: staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()
5
6From: Dan Carpenter <dan.carpenter@oracle.com>
7
8commit 1376b0a2160319125c3a2822e8c09bd283cd8141 upstream.
9
10There is a '>' vs '<' typo so this loop is a no-op.
11
12Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()")
13Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
14Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
15Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
16
17
18---
19 drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
20 1 file changed, 1 insertion(+), 1 deletion(-)
21
22--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
23+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
24@@ -642,7 +642,7 @@ static int daqp_ao_insn_write(struct com
25 /* Make sure D/A update mode is direct update */
26 outb(0, dev->iobase + DAQP_AUX_REG);
27
28- for (i = 0; i > insn->n; i++) {
29+ for (i = 0; i < insn->n; i++) {
30 unsigned val = data[i];
31 int ret;
32