]>
Commit | Line | Data |
---|---|---|
bec8288c GKH |
1 | From 628bd85947091830a8c4872adfd5ed1d515a9cf2 Mon Sep 17 00:00:00 2001 |
2 | From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | |
3 | Date: Mon, 12 Nov 2018 08:42:14 -0700 | |
4 | Subject: loop: Fix double mutex_unlock(&loop_ctl_mutex) in loop_control_ioctl() | |
5 | ||
6 | From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | |
7 | ||
8 | commit 628bd85947091830a8c4872adfd5ed1d515a9cf2 upstream. | |
9 | ||
10 | Commit 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex") forgot to | |
11 | remove mutex_unlock(&loop_ctl_mutex) from loop_control_ioctl() when | |
12 | replacing loop_index_mutex with loop_ctl_mutex. | |
13 | ||
14 | Fixes: 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex") | |
15 | Reported-by: syzbot <syzbot+c0138741c2290fc5e63f@syzkaller.appspotmail.com> | |
16 | Reviewed-by: Ming Lei <ming.lei@redhat.com> | |
17 | Reviewed-by: Jan Kara <jack@suse.cz> | |
18 | Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | |
19 | Signed-off-by: Jens Axboe <axboe@kernel.dk> | |
20 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
21 | ||
22 | --- | |
23 | drivers/block/loop.c | 2 -- | |
24 | 1 file changed, 2 deletions(-) | |
25 | ||
26 | --- a/drivers/block/loop.c | |
27 | +++ b/drivers/block/loop.c | |
28 | @@ -1936,12 +1936,10 @@ static long loop_control_ioctl(struct fi | |
29 | break; | |
30 | if (lo->lo_state != Lo_unbound) { | |
31 | ret = -EBUSY; | |
32 | - mutex_unlock(&loop_ctl_mutex); | |
33 | break; | |
34 | } | |
35 | if (atomic_read(&lo->lo_refcnt) > 0) { | |
36 | ret = -EBUSY; | |
37 | - mutex_unlock(&loop_ctl_mutex); | |
38 | break; | |
39 | } | |
40 | lo->lo_disk->private_data = NULL; |