]>
Commit | Line | Data |
---|---|---|
7e0d956d GKH |
1 | From cfd278c280f997cf2fe4662e0acab0fe465f637b Mon Sep 17 00:00:00 2001 |
2 | From: NeilBrown <neilb@suse.com> | |
3 | Date: Mon, 19 Dec 2016 11:19:31 +1100 | |
4 | Subject: NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success. | |
5 | ||
6 | From: NeilBrown <neilb@suse.com> | |
7 | ||
8 | commit cfd278c280f997cf2fe4662e0acab0fe465f637b upstream. | |
9 | ||
10 | Various places assume that if nfs4_fl_prepare_ds() turns a non-NULL 'ds', | |
11 | then ds->ds_clp will also be non-NULL. | |
12 | ||
13 | This is not necessasrily true in the case when the process received a fatal signal | |
14 | while nfs4_pnfs_ds_connect is waiting in nfs4_wait_ds_connect(). | |
15 | In that case ->ds_clp may not be set, and the devid may not recently have been marked | |
16 | unavailable. | |
17 | ||
18 | So add a test for ds_clp == NULL and return NULL in that case. | |
19 | ||
20 | Fixes: c23266d532b4 ("NFS4.1 Fix data server connection race") | |
21 | Signed-off-by: NeilBrown <neilb@suse.com> | |
22 | Acked-by: Olga Kornievskaia <aglo@umich.edu> | |
23 | Acked-by: Adamson, Andy <William.Adamson@netapp.com> | |
24 | Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> | |
25 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
26 | ||
27 | --- | |
28 | fs/nfs/filelayout/filelayoutdev.c | 3 ++- | |
29 | 1 file changed, 2 insertions(+), 1 deletion(-) | |
30 | ||
31 | --- a/fs/nfs/filelayout/filelayoutdev.c | |
32 | +++ b/fs/nfs/filelayout/filelayoutdev.c | |
33 | @@ -283,7 +283,8 @@ nfs4_fl_prepare_ds(struct pnfs_layout_se | |
34 | s->nfs_client->cl_rpcclient->cl_auth->au_flavor); | |
35 | ||
36 | out_test_devid: | |
37 | - if (filelayout_test_devid_unavailable(devid)) | |
38 | + if (ret->ds_clp == NULL || | |
39 | + filelayout_test_devid_unavailable(devid)) | |
40 | ret = NULL; | |
41 | out: | |
42 | return ret; |