]>
Commit | Line | Data |
---|---|---|
dcf4d15d GKH |
1 | From a377f9e906af4df9071ba8ddba60188cb4013d93 Mon Sep 17 00:00:00 2001 |
2 | From: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> | |
3 | Date: Wed, 4 May 2016 16:56:52 -0500 | |
4 | Subject: USB: serial: cp210x: fix hardware flow-control disable | |
5 | ||
6 | From: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> | |
7 | ||
8 | commit a377f9e906af4df9071ba8ddba60188cb4013d93 upstream. | |
9 | ||
10 | A bug in the CRTSCTS handling caused RTS to alternate between | |
11 | ||
12 | CRTSCTS=0 => "RTS is transmit active signal" and | |
13 | CRTSCTS=1 => "RTS is used for receive flow control" | |
14 | ||
15 | instead of | |
16 | ||
17 | CRTSCTS=0 => "RTS is statically active" and | |
18 | CRTSCTS=1 => "RTS is used for receive flow control" | |
19 | ||
20 | This only happened after first having enabled CRTSCTS. | |
21 | ||
22 | Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> | |
23 | Fixes: 39a66b8d22a3 ("[PATCH] USB: CP2101 Add support for flow control") | |
24 | [johan: reword commit message ] | |
25 | Signed-off-by: Johan Hovold <johan@kernel.org> | |
26 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
27 | ||
28 | --- | |
29 | drivers/usb/serial/cp210x.c | 3 +-- | |
30 | 1 file changed, 1 insertion(+), 2 deletions(-) | |
31 | ||
32 | --- a/drivers/usb/serial/cp210x.c | |
33 | +++ b/drivers/usb/serial/cp210x.c | |
34 | @@ -971,8 +971,7 @@ static void cp210x_set_termios(struct tt | |
35 | } else { | |
36 | modem_ctl[0] &= ~0x7B; | |
37 | modem_ctl[0] |= 0x01; | |
38 | - /* FIXME - OR here instead of assignment looks wrong */ | |
39 | - modem_ctl[4] |= 0x40; | |
40 | + modem_ctl[4] = 0x40; | |
41 | dev_dbg(dev, "%s - flow control = NONE\n", __func__); | |
42 | } | |
43 |