]>
Commit | Line | Data |
---|---|---|
ad834691 GKH |
1 | From 5ca05345c56cb979e1a25ab6146437002f95cac8 Mon Sep 17 00:00:00 2001 |
2 | From: Ian Abbott <abbotti@mev.co.uk> | |
3 | Date: Wed, 20 Jul 2016 17:07:34 +0100 | |
4 | Subject: staging: comedi: ni_mio_common: fix wrong insn_write handler | |
5 | MIME-Version: 1.0 | |
6 | Content-Type: text/plain; charset=UTF-8 | |
7 | Content-Transfer-Encoding: 8bit | |
8 | ||
9 | From: Ian Abbott <abbotti@mev.co.uk> | |
10 | ||
11 | commit 5ca05345c56cb979e1a25ab6146437002f95cac8 upstream. | |
12 | ||
13 | For counter subdevices, the `s->insn_write` handler is being set to the | |
14 | wrong function, `ni_tio_insn_read()`. It should be | |
15 | `ni_tio_insn_write()`. | |
16 | ||
17 | Signed-off-by: Ian Abbott <abbotti@mev.co.uk> | |
18 | Reported-by: Éric Piel <piel@delmic.com> | |
19 | Fixes: 10f74377eec3 ("staging: comedi: ni_tio: make ni_tio_winsn() a | |
20 | proper comedi (*insn_write)" | |
21 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
22 | ||
23 | --- | |
24 | drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- | |
25 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
26 | ||
27 | --- a/drivers/staging/comedi/drivers/ni_mio_common.c | |
28 | +++ b/drivers/staging/comedi/drivers/ni_mio_common.c | |
29 | @@ -5488,7 +5488,7 @@ static int ni_E_init(struct comedi_devic | |
30 | s->maxdata = (devpriv->is_m_series) ? 0xffffffff | |
31 | : 0x00ffffff; | |
32 | s->insn_read = ni_tio_insn_read; | |
33 | - s->insn_write = ni_tio_insn_read; | |
34 | + s->insn_write = ni_tio_insn_write; | |
35 | s->insn_config = ni_tio_insn_config; | |
36 | #ifdef PCIDMA | |
37 | if (dev->irq && devpriv->mite) { |