]>
Commit | Line | Data |
---|---|---|
5a5e98ca GKH |
1 | From 3295235fd70ed6d594aadee8c892a14f6a4b2d2e Mon Sep 17 00:00:00 2001 |
2 | From: Wei Yongjun <weiyj.lk@gmail.com> | |
3 | Date: Sat, 13 Aug 2016 01:28:24 +0000 | |
4 | Subject: usb: renesas_usbhs: gadget: fix return value check in usbhs_mod_gadget_probe() | |
5 | ||
6 | From: Wei Yongjun <weiyj.lk@gmail.com> | |
7 | ||
8 | commit 3295235fd70ed6d594aadee8c892a14f6a4b2d2e upstream. | |
9 | ||
10 | In case of error, the function usb_get_phy() returns ERR_PTR() and never | |
11 | returns NULL. The NULL test in the return value check should be replaced | |
12 | with IS_ERR(). | |
13 | ||
14 | Fixes: b5a2875605ca ("usb: renesas_usbhs: Allow an OTG PHY driver to | |
15 | provide VBUS") | |
16 | Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> | |
17 | Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> | |
18 | Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> | |
19 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
20 | ||
21 | --- | |
22 | drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- | |
23 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
24 | ||
25 | --- a/drivers/usb/renesas_usbhs/mod_gadget.c | |
26 | +++ b/drivers/usb/renesas_usbhs/mod_gadget.c | |
27 | @@ -1076,7 +1076,7 @@ int usbhs_mod_gadget_probe(struct usbhs_ | |
28 | ||
29 | gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED); | |
30 | dev_info(dev, "%stransceiver found\n", | |
31 | - gpriv->transceiver ? "" : "no "); | |
32 | + !IS_ERR(gpriv->transceiver) ? "" : "no "); | |
33 | ||
34 | /* | |
35 | * CAUTION |