]>
Commit | Line | Data |
---|---|---|
35d01876 GKH |
1 | From 42819eb7a0957cc340ad4ed8bba736bab5ebc464 Mon Sep 17 00:00:00 2001 |
2 | From: Martin Wilck <mwilck@suse.com> | |
3 | Date: Mon, 14 Aug 2017 22:12:37 +0200 | |
4 | Subject: nvmet: don't overwrite identify sn/fr with 0-bytes | |
5 | ||
6 | From: Martin Wilck <mwilck@suse.com> | |
7 | ||
8 | commit 42819eb7a0957cc340ad4ed8bba736bab5ebc464 upstream. | |
9 | ||
10 | The merged version of my patch "nvmet: don't report 0-bytes in serial | |
11 | number" fails to remove two lines which should have been replaced, | |
12 | so that the space-padded strings are overwritten again with 0-bytes. | |
13 | Fix it. | |
14 | ||
15 | Fixes: 42de82a8b544 nvmet: don't report 0-bytes in serial number | |
16 | Signed-off-by: Martin Wilck <mwilck@suse.com> | |
17 | Reviewed-by: Sagi Grimberg <sagi@grimbeg.me> | |
18 | Signed-off-by: Christoph Hellwig <hch@lst.de> | |
19 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
20 | ||
21 | --- | |
22 | drivers/nvme/target/admin-cmd.c | 6 ------ | |
23 | 1 file changed, 6 deletions(-) | |
24 | ||
25 | --- a/drivers/nvme/target/admin-cmd.c | |
26 | +++ b/drivers/nvme/target/admin-cmd.c | |
27 | @@ -197,12 +197,6 @@ static void nvmet_execute_identify_ctrl( | |
28 | copy_and_pad(id->mn, sizeof(id->mn), model, sizeof(model) - 1); | |
29 | copy_and_pad(id->fr, sizeof(id->fr), UTS_RELEASE, strlen(UTS_RELEASE)); | |
30 | ||
31 | - memset(id->mn, ' ', sizeof(id->mn)); | |
32 | - strncpy((char *)id->mn, "Linux", sizeof(id->mn)); | |
33 | - | |
34 | - memset(id->fr, ' ', sizeof(id->fr)); | |
35 | - strncpy((char *)id->fr, UTS_RELEASE, sizeof(id->fr)); | |
36 | - | |
37 | id->rab = 6; | |
38 | ||
39 | /* |