]>
Commit | Line | Data |
---|---|---|
13e8e92f GKH |
1 | From foo@baz Mon Sep 17 12:22:41 CEST 2018 |
2 | From: Dan Carpenter <dan.carpenter@oracle.com> | |
3 | Date: Wed, 20 Jun 2018 13:39:53 +0300 | |
4 | Subject: f2fs: Fix uninitialized return in f2fs_ioc_shutdown() | |
5 | ||
6 | From: Dan Carpenter <dan.carpenter@oracle.com> | |
7 | ||
8 | [ Upstream commit 2a96d8ad94ce57cb0072f7a660b1039720c47716 ] | |
9 | ||
10 | "ret" can be uninitialized on the success path when "in == | |
11 | F2FS_GOING_DOWN_FULLSYNC". | |
12 | ||
13 | Fixes: 60b2b4ee2bc0 ("f2fs: Fix deadlock in shutdown ioctl") | |
14 | Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> | |
15 | Reviewed-by: Chao Yu <yuchao0@huawei.com> | |
16 | Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> | |
17 | Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> | |
18 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
19 | --- | |
20 | fs/f2fs/file.c | 2 +- | |
21 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
22 | ||
23 | --- a/fs/f2fs/file.c | |
24 | +++ b/fs/f2fs/file.c | |
25 | @@ -1665,7 +1665,7 @@ static int f2fs_ioc_shutdown(struct file | |
26 | struct f2fs_sb_info *sbi = F2FS_I_SB(inode); | |
27 | struct super_block *sb = sbi->sb; | |
28 | __u32 in; | |
29 | - int ret; | |
30 | + int ret = 0; | |
31 | ||
32 | if (!capable(CAP_SYS_ADMIN)) | |
33 | return -EPERM; |