]>
Commit | Line | Data |
---|---|---|
e3829b40 GKH |
1 | From foo@baz Sat Sep 29 04:29:21 PDT 2018 |
2 | From: Bart Van Assche <bart.vanassche@wdc.com> | |
3 | Date: Fri, 22 Jun 2018 14:53:01 -0700 | |
4 | Subject: scsi: target/iscsi: Make iscsit_ta_authentication() respect the output buffer size | |
5 | ||
6 | From: Bart Van Assche <bart.vanassche@wdc.com> | |
7 | ||
8 | [ Upstream commit 35bea5c84fd13c643cce63f0b5cd4b148f8c901d ] | |
9 | ||
10 | Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1") | |
11 | Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> | |
12 | Reviewed-by: Mike Christie <mchristi@redhat.com> | |
13 | Cc: Mike Christie <mchristi@redhat.com> | |
14 | Cc: Christoph Hellwig <hch@lst.de> | |
15 | Cc: Hannes Reinecke <hare@suse.com> | |
16 | Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> | |
17 | Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> | |
18 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
19 | --- | |
20 | drivers/target/iscsi/iscsi_target_tpg.c | 3 +-- | |
21 | 1 file changed, 1 insertion(+), 2 deletions(-) | |
22 | ||
23 | --- a/drivers/target/iscsi/iscsi_target_tpg.c | |
24 | +++ b/drivers/target/iscsi/iscsi_target_tpg.c | |
25 | @@ -637,8 +637,7 @@ int iscsit_ta_authentication(struct iscs | |
26 | none = strstr(buf1, NONE); | |
27 | if (none) | |
28 | goto out; | |
29 | - strncat(buf1, ",", strlen(",")); | |
30 | - strncat(buf1, NONE, strlen(NONE)); | |
31 | + strlcat(buf1, "," NONE, sizeof(buf1)); | |
32 | if (iscsi_update_param_value(param, buf1) < 0) | |
33 | return -EINVAL; | |
34 | } |