]>
Commit | Line | Data |
---|---|---|
f1359f75 GKH |
1 | From foo@baz Thu Dec 14 11:45:58 CET 2017 |
2 | From: Jon Maloy <jon.maloy@ericsson.com> | |
3 | Date: Mon, 4 Dec 2017 22:00:20 +0100 | |
4 | Subject: tipc: fix memory leak in tipc_accept_from_sock() | |
5 | ||
6 | From: Jon Maloy <jon.maloy@ericsson.com> | |
7 | ||
8 | ||
9 | [ Upstream commit a7d5f107b4978e08eeab599ee7449af34d034053 ] | |
10 | ||
11 | When the function tipc_accept_from_sock() fails to create an instance of | |
12 | struct tipc_subscriber it omits to free the already created instance of | |
13 | struct tipc_conn instance before it returns. | |
14 | ||
15 | We fix that with this commit. | |
16 | ||
17 | Reported-by: David S. Miller <davem@davemloft.net> | |
18 | Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> | |
19 | Signed-off-by: David S. Miller <davem@davemloft.net> | |
20 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
21 | --- | |
22 | net/tipc/server.c | 1 + | |
23 | 1 file changed, 1 insertion(+) | |
24 | ||
25 | --- a/net/tipc/server.c | |
26 | +++ b/net/tipc/server.c | |
27 | @@ -313,6 +313,7 @@ static int tipc_accept_from_sock(struct | |
28 | newcon->usr_data = s->tipc_conn_new(newcon->conid); | |
29 | if (!newcon->usr_data) { | |
30 | sock_release(newsock); | |
31 | + conn_put(newcon); | |
32 | return -ENOMEM; | |
33 | } | |
34 |