]>
Commit | Line | Data |
---|---|---|
016107b0 SL |
1 | From 83738e6a06bbc9ef998253964b95b90c5d3767dd Mon Sep 17 00:00:00 2001 |
2 | From: Sasha Levin <sashal@kernel.org> | |
3 | Date: Thu, 27 Aug 2020 09:07:42 +0200 | |
4 | Subject: EDAC/aspeed: Fix handling of platform_get_irq() error | |
5 | ||
6 | From: Krzysztof Kozlowski <krzk@kernel.org> | |
7 | ||
8 | [ Upstream commit afce6996943be265fa39240b67025cfcb1bcdfb1 ] | |
9 | ||
10 | platform_get_irq() returns a negative error number on error. In such a | |
11 | case, comparison to 0 would pass the check therefore check the return | |
12 | value properly, whether it is negative. | |
13 | ||
14 | [ bp: Massage commit message. ] | |
15 | ||
16 | Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") | |
17 | Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> | |
18 | Signed-off-by: Borislav Petkov <bp@suse.de> | |
19 | Reviewed-by: Stefan Schaeckeler <schaecsn@gmx.net> | |
20 | Link: https://lkml.kernel.org/r/20200827070743.26628-1-krzk@kernel.org | |
21 | Signed-off-by: Sasha Levin <sashal@kernel.org> | |
22 | --- | |
23 | drivers/edac/aspeed_edac.c | 4 ++-- | |
24 | 1 file changed, 2 insertions(+), 2 deletions(-) | |
25 | ||
26 | diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c | |
27 | index 5634437bb39d2..66669f9d690be 100644 | |
28 | --- a/drivers/edac/aspeed_edac.c | |
29 | +++ b/drivers/edac/aspeed_edac.c | |
30 | @@ -209,8 +209,8 @@ static int config_irq(void *ctx, struct platform_device *pdev) | |
31 | /* register interrupt handler */ | |
32 | irq = platform_get_irq(pdev, 0); | |
33 | dev_dbg(&pdev->dev, "got irq %d\n", irq); | |
34 | - if (!irq) | |
35 | - return -ENODEV; | |
36 | + if (irq < 0) | |
37 | + return irq; | |
38 | ||
39 | rc = devm_request_irq(&pdev->dev, irq, mcr_isr, IRQF_TRIGGER_HIGH, | |
40 | DRV_NAME, ctx); | |
41 | -- | |
42 | 2.25.1 | |
43 |