]> git.ipfire.org Git - thirdparty/git.git/blame - submodule.c
diff-files: move misplaced cleanup label
[thirdparty/git.git] / submodule.c
CommitLineData
e724197f 1
752c0c24 2#include "cache.h"
69aba532 3#include "repository.h"
b2141fc1 4#include "config.h"
851e18c3 5#include "submodule-config.h"
752c0c24
JS
6#include "submodule.h"
7#include "dir.h"
8#include "diff.h"
9#include "commit.h"
10#include "revision.h"
ee6fc514 11#include "run-command.h"
c7e1a736 12#include "diffcore.h"
68d03e4a 13#include "refs.h"
aee9c7d6 14#include "string-list.h"
fe299ec5 15#include "oid-array.h"
dbbcd44f 16#include "strvec.h"
5fee9952 17#include "blob.h"
fe85ee6e 18#include "thread-utils.h"
4638728c 19#include "quote.h"
06bf4ad1 20#include "remote.h"
f6f85861 21#include "worktree.h"
046b4823 22#include "parse-options.h"
0d4a1321 23#include "object-store.h"
64043556 24#include "commit-reach.h"
aee9c7d6 25
d7a3803f 26static int config_update_recurse_submodules = RECURSE_SUBMODULES_OFF;
6859de45 27static int initialized_fetch_ref_tips;
910650d2 28static struct oid_array ref_tips_before_fetch;
29static struct oid_array ref_tips_after_fetch;
6859de45 30
d4e98b58 31/*
34e2ba04
BW
32 * Check if the .gitmodules file is unmerged. Parsing of the .gitmodules file
33 * will be disabled because we can't guess what might be configured in
34 * .gitmodules unless the user resolves the conflict.
d4e98b58 35 */
847a9e5d 36int is_gitmodules_unmerged(struct index_state *istate)
34e2ba04
BW
37{
38 int pos = index_name_pos(istate, GITMODULES_FILE, strlen(GITMODULES_FILE));
39 if (pos < 0) { /* .gitmodules not found or isn't merged */
40 pos = -1 - pos;
41 if (istate->cache_nr > pos) { /* there is a .gitmodules */
42 const struct cache_entry *ce = istate->cache[pos];
43 if (ce_namelen(ce) == strlen(GITMODULES_FILE) &&
44 !strcmp(ce->name, GITMODULES_FILE))
45 return 1;
46 }
47 }
48
49 return 0;
50}
752c0c24 51
b5c259f2
AO
52/*
53 * Check if the .gitmodules file is safe to write.
54 *
55 * Writing to the .gitmodules file requires that the file exists in the
56 * working tree or, if it doesn't, that a brand new .gitmodules file is going
57 * to be created (i.e. it's neither in the index nor in the current branch).
58 *
59 * It is not safe to write to .gitmodules if it's not in the working tree but
60 * it is in the index or in the current branch, because writing new values
61 * (and staging them) would blindly overwrite ALL the old content.
62 */
63int is_writing_gitmodules_ok(void)
64{
65 struct object_id oid;
66 return file_exists(GITMODULES_FILE) ||
67 (get_oid(GITMODULES_INDEX, &oid) < 0 && get_oid(GITMODULES_HEAD, &oid) < 0);
68}
69
5fee9952 70/*
91b83480
BW
71 * Check if the .gitmodules file has unstaged modifications. This must be
72 * checked before allowing modifications to the .gitmodules file with the
73 * intention to stage them later, because when continuing we would stage the
74 * modifications the user didn't stage herself too. That might change in a
75 * future version when we learn to stage the changes we do ourselves without
76 * staging any previous modifications.
5fee9952 77 */
7da9aba4 78int is_staging_gitmodules_ok(struct index_state *istate)
5fee9952 79{
91b83480
BW
80 int pos = index_name_pos(istate, GITMODULES_FILE, strlen(GITMODULES_FILE));
81
82 if ((pos >= 0) && (pos < istate->cache_nr)) {
83 struct stat st;
84 if (lstat(GITMODULES_FILE, &st) == 0 &&
7edee329 85 ie_modified(istate, istate->cache[pos], &st, 0) & DATA_CHANGED)
91b83480
BW
86 return 0;
87 }
88
89 return 1;
5fee9952
JL
90}
91
2e2d4040
NTND
92static int for_each_remote_ref_submodule(const char *submodule,
93 each_ref_fn fn, void *cb_data)
94{
95 return refs_for_each_remote_ref(get_submodule_ref_store(submodule),
96 fn, cb_data);
97}
98
0656781f
JL
99/*
100 * Try to update the "path" entry in the "submodule.<name>" section of the
101 * .gitmodules file. Return 0 only if a .gitmodules file was found, a section
102 * with the correct path=<oldpath> setting was found and we could update it.
103 */
104int update_path_in_gitmodules(const char *oldpath, const char *newpath)
105{
106 struct strbuf entry = STRBUF_INIT;
851e18c3 107 const struct submodule *submodule;
45f5ef3d 108 int ret;
0656781f 109
4c0eeafe 110 if (!file_exists(GITMODULES_FILE)) /* Do nothing without .gitmodules */
0656781f
JL
111 return -1;
112
68f08b4b 113 if (is_gitmodules_unmerged(the_repository->index))
0656781f
JL
114 die(_("Cannot change unmerged .gitmodules, resolve merge conflicts first"));
115
14228447 116 submodule = submodule_from_path(the_repository, null_oid(), oldpath);
851e18c3 117 if (!submodule || !submodule->name) {
0656781f
JL
118 warning(_("Could not find section in .gitmodules where path=%s"), oldpath);
119 return -1;
120 }
121 strbuf_addstr(&entry, "submodule.");
851e18c3 122 strbuf_addstr(&entry, submodule->name);
0656781f 123 strbuf_addstr(&entry, ".path");
45f5ef3d 124 ret = config_set_in_gitmodules_file_gently(entry.buf, newpath);
0656781f 125 strbuf_release(&entry);
45f5ef3d 126 return ret;
0656781f
JL
127}
128
95c16418
JL
129/*
130 * Try to remove the "submodule.<name>" section from .gitmodules where the given
131 * path is configured. Return 0 only if a .gitmodules file was found, a section
132 * with the correct path=<path> setting was found and we could remove it.
133 */
134int remove_path_from_gitmodules(const char *path)
135{
136 struct strbuf sect = STRBUF_INIT;
851e18c3 137 const struct submodule *submodule;
95c16418 138
4c0eeafe 139 if (!file_exists(GITMODULES_FILE)) /* Do nothing without .gitmodules */
95c16418
JL
140 return -1;
141
68f08b4b 142 if (is_gitmodules_unmerged(the_repository->index))
95c16418
JL
143 die(_("Cannot change unmerged .gitmodules, resolve merge conflicts first"));
144
14228447 145 submodule = submodule_from_path(the_repository, null_oid(), path);
851e18c3 146 if (!submodule || !submodule->name) {
95c16418
JL
147 warning(_("Could not find section in .gitmodules where path=%s"), path);
148 return -1;
149 }
150 strbuf_addstr(&sect, "submodule.");
851e18c3 151 strbuf_addstr(&sect, submodule->name);
4c0eeafe 152 if (git_config_rename_section_in_file(GITMODULES_FILE, sect.buf, NULL) < 0) {
95c16418
JL
153 /* Maybe the user already did that, don't error out here */
154 warning(_("Could not remove .gitmodules entry for %s"), path);
155 strbuf_release(&sect);
156 return -1;
157 }
158 strbuf_release(&sect);
159 return 0;
160}
161
3b8317a9 162void stage_updated_gitmodules(struct index_state *istate)
5fee9952 163{
3b8317a9 164 if (add_file_to_index(istate, GITMODULES_FILE, 0))
5fee9952
JL
165 die(_("staging updated .gitmodules failed"));
166}
167
a35e03de
JT
168static struct string_list added_submodule_odb_paths = STRING_LIST_INIT_NODUP;
169
18cfc088
SB
170/* TODO: remove this function, use repo_submodule_init instead. */
171int add_submodule_odb(const char *path)
752c0c24
JS
172{
173 struct strbuf objects_directory = STRBUF_INIT;
de7a7960 174 int ret = 0;
752c0c24 175
99b43a61
JK
176 ret = strbuf_git_path_submodule(&objects_directory, path, "objects/");
177 if (ret)
178 goto done;
de7a7960
JL
179 if (!is_directory(objects_directory.buf)) {
180 ret = -1;
181 goto done;
182 }
a35e03de
JT
183 string_list_insert(&added_submodule_odb_paths,
184 strbuf_detach(&objects_directory, NULL));
de7a7960
JL
185done:
186 strbuf_release(&objects_directory);
187 return ret;
752c0c24
JS
188}
189
8d33c3af
JT
190void add_submodule_odb_by_path(const char *path)
191{
192 string_list_insert(&added_submodule_odb_paths, xstrdup(path));
193}
194
a35e03de
JT
195int register_all_submodule_odb_as_alternates(void)
196{
197 int i;
198 int ret = added_submodule_odb_paths.nr;
199
200 for (i = 0; i < added_submodule_odb_paths.nr; i++)
201 add_to_alternates_memory(added_submodule_odb_paths.items[i].string);
202 if (ret) {
203 string_list_clear(&added_submodule_odb_paths, 0);
71ef66d7
JT
204 trace2_data_intmax("submodule", the_repository,
205 "register_all_submodule_odb_as_alternates/registered", ret);
a35e03de
JT
206 if (git_env_bool("GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB", 0))
207 BUG("register_all_submodule_odb_as_alternates() called");
208 }
209 return ret;
210}
211
aee9c7d6
JL
212void set_diffopt_flags_from_submodule_config(struct diff_options *diffopt,
213 const char *path)
214{
3b8fb393 215 const struct submodule *submodule = submodule_from_path(the_repository,
14228447 216 null_oid(),
217 path);
851e18c3 218 if (submodule) {
fdfa9e97
BW
219 const char *ignore;
220 char *key;
aee9c7d6 221
fdfa9e97 222 key = xstrfmt("submodule.%s.ignore", submodule->name);
f1de981e 223 if (repo_config_get_string_tmp(the_repository, key, &ignore))
fdfa9e97
BW
224 ignore = submodule->ignore;
225 free(key);
302ad7a9 226
fdfa9e97
BW
227 if (ignore)
228 handle_ignore_submodules_arg(diffopt, ignore);
68f08b4b 229 else if (is_gitmodules_unmerged(the_repository->index))
0d1e0e78 230 diffopt->flags.ignore_submodules = 1;
046b4823
SB
231 }
232}
233
234/* Cheap function that only determines if we're interested in submodules at all */
235int git_default_submodule_config(const char *var, const char *value, void *cb)
236{
237 if (!strcmp(var, "submodule.recurse")) {
238 int v = git_config_bool(var, value) ?
239 RECURSE_SUBMODULES_ON : RECURSE_SUBMODULES_OFF;
240 config_update_recurse_submodules = v;
241 }
242 return 0;
1d789d08
SB
243}
244
d7a3803f
SB
245int option_parse_recurse_submodules_worktree_updater(const struct option *opt,
246 const char *arg, int unset)
247{
248 if (unset) {
249 config_update_recurse_submodules = RECURSE_SUBMODULES_OFF;
250 return 0;
251 }
252 if (arg)
253 config_update_recurse_submodules =
254 parse_update_recurse_submodules_arg(opt->long_name,
255 arg);
256 else
257 config_update_recurse_submodules = RECURSE_SUBMODULES_ON;
258
259 return 0;
260}
261
f9f42560
BW
262/*
263 * Determine if a submodule has been initialized at a given 'path'
264 */
a452128a
AR
265/*
266 * NEEDSWORK: Emit a warning if submodule.active exists, but is valueless,
267 * ie, the config looks like: "[submodule] active\n".
268 * Since that is an invalid pathspec, we should inform the user.
269 */
961b130d
GC
270int is_tree_submodule_active(struct repository *repo,
271 const struct object_id *treeish_name,
272 const char *path)
f9f42560
BW
273{
274 int ret = 0;
a086f921
BW
275 char *key = NULL;
276 char *value = NULL;
277 const struct string_list *sl;
627d9342
BW
278 const struct submodule *module;
279
961b130d 280 module = submodule_from_path(repo, treeish_name, path);
f9f42560 281
a086f921
BW
282 /* early return if there isn't a path->module mapping */
283 if (!module)
284 return 0;
f9f42560 285
a086f921
BW
286 /* submodule.<name>.active is set */
287 key = xstrfmt("submodule.%s.active", module->name);
627d9342 288 if (!repo_config_get_bool(repo, key, &ret)) {
a086f921
BW
289 free(key);
290 return ret;
291 }
292 free(key);
f9f42560 293
a086f921 294 /* submodule.active is set */
627d9342 295 sl = repo_config_get_value_multi(repo, "submodule.active");
a086f921
BW
296 if (sl) {
297 struct pathspec ps;
c972bf4c 298 struct strvec args = STRVEC_INIT;
a086f921 299 const struct string_list_item *item;
f9f42560 300
a086f921 301 for_each_string_list_item(item, sl) {
c972bf4c 302 strvec_push(&args, item->string);
a086f921
BW
303 }
304
d70a9eb6 305 parse_pathspec(&ps, 0, 0, NULL, args.v);
68f08b4b 306 ret = match_pathspec(repo->index, &ps, path, strlen(path), 0, NULL, 1);
a086f921 307
c972bf4c 308 strvec_clear(&args);
a086f921
BW
309 clear_pathspec(&ps);
310 return ret;
f9f42560
BW
311 }
312
a086f921
BW
313 /* fallback to checking if the URL is set */
314 key = xstrfmt("submodule.%s.url", module->name);
627d9342 315 ret = !repo_config_get_string(repo, key, &value);
a086f921
BW
316
317 free(value);
318 free(key);
f9f42560
BW
319 return ret;
320}
321
961b130d
GC
322int is_submodule_active(struct repository *repo, const char *path)
323{
324 return is_tree_submodule_active(repo, null_oid(), path);
325}
326
15cdc647 327int is_submodule_populated_gently(const char *path, int *return_error_code)
5688c28d
BW
328{
329 int ret = 0;
330 char *gitdir = xstrfmt("%s/.git", path);
331
15cdc647 332 if (resolve_gitdir_gently(gitdir, return_error_code))
5688c28d
BW
333 ret = 1;
334
335 free(gitdir);
336 return ret;
337}
338
bdab9721
BW
339/*
340 * Dies if the provided 'prefix' corresponds to an unpopulated submodule
341 */
847a9e5d 342void die_in_unpopulated_submodule(struct index_state *istate,
bdab9721
BW
343 const char *prefix)
344{
345 int i, prefixlen;
346
347 if (!prefix)
348 return;
349
350 prefixlen = strlen(prefix);
351
352 for (i = 0; i < istate->cache_nr; i++) {
353 struct cache_entry *ce = istate->cache[i];
354 int ce_len = ce_namelen(ce);
355
356 if (!S_ISGITLINK(ce->ce_mode))
357 continue;
358 if (prefixlen <= ce_len)
359 continue;
360 if (strncmp(ce->name, prefix, ce_len))
361 continue;
362 if (prefix[ce_len] != '/')
363 continue;
364
365 die(_("in unpopulated submodule '%s'"), ce->name);
366 }
367}
368
c08397e3
BW
369/*
370 * Dies if any paths in the provided pathspec descends into a submodule
371 */
847a9e5d 372void die_path_inside_submodule(struct index_state *istate,
c08397e3
BW
373 const struct pathspec *ps)
374{
375 int i, j;
376
377 for (i = 0; i < istate->cache_nr; i++) {
378 struct cache_entry *ce = istate->cache[i];
379 int ce_len = ce_namelen(ce);
380
381 if (!S_ISGITLINK(ce->ce_mode))
382 continue;
383
384 for (j = 0; j < ps->nr ; j++) {
385 const struct pathspec_item *item = &ps->items[j];
386
387 if (item->len <= ce_len)
388 continue;
389 if (item->match[ce_len] != '/')
390 continue;
391 if (strncmp(ce->name, item->match, ce_len))
392 continue;
393 if (item->len == ce_len + 1)
394 continue;
395
396 die(_("Pathspec '%s' is in submodule '%.*s'"),
397 item->original, ce_len, ce->name);
398 }
399 }
400}
401
ec6141a0 402enum submodule_update_type parse_submodule_update_type(const char *value)
ea2fa5a3 403{
ea2fa5a3 404 if (!strcmp(value, "none"))
ec6141a0 405 return SM_UPDATE_NONE;
ea2fa5a3 406 else if (!strcmp(value, "checkout"))
ec6141a0 407 return SM_UPDATE_CHECKOUT;
ea2fa5a3 408 else if (!strcmp(value, "rebase"))
ec6141a0 409 return SM_UPDATE_REBASE;
ea2fa5a3 410 else if (!strcmp(value, "merge"))
ec6141a0
BW
411 return SM_UPDATE_MERGE;
412 else if (*value == '!')
413 return SM_UPDATE_COMMAND;
414 else
415 return SM_UPDATE_UNSPECIFIED;
416}
417
418int parse_submodule_update_strategy(const char *value,
419 struct submodule_update_strategy *dst)
420{
421 enum submodule_update_type type;
422
423 free((void*)dst->command);
424 dst->command = NULL;
425
426 type = parse_submodule_update_type(value);
427 if (type == SM_UPDATE_UNSPECIFIED)
ea2fa5a3 428 return -1;
ec6141a0
BW
429
430 dst->type = type;
431 if (type == SM_UPDATE_COMMAND)
432 dst->command = xstrdup(value + 1);
433
ea2fa5a3
SB
434 return 0;
435}
436
3604242f
SB
437const char *submodule_strategy_to_string(const struct submodule_update_strategy *s)
438{
439 struct strbuf sb = STRBUF_INIT;
440 switch (s->type) {
441 case SM_UPDATE_CHECKOUT:
442 return "checkout";
443 case SM_UPDATE_MERGE:
444 return "merge";
445 case SM_UPDATE_REBASE:
446 return "rebase";
447 case SM_UPDATE_NONE:
448 return "none";
449 case SM_UPDATE_UNSPECIFIED:
450 return NULL;
451 case SM_UPDATE_COMMAND:
452 strbuf_addf(&sb, "!%s", s->command);
453 return strbuf_detach(&sb, NULL);
454 }
455 return NULL;
456}
457
46a958b3
JL
458void handle_ignore_submodules_arg(struct diff_options *diffopt,
459 const char *arg)
460{
8ef93124 461 diffopt->flags.ignore_submodule_set = 1;
0d1e0e78
BW
462 diffopt->flags.ignore_submodules = 0;
463 diffopt->flags.ignore_untracked_in_submodules = 0;
464 diffopt->flags.ignore_dirty_submodules = 0;
be4f2b40 465
46a958b3 466 if (!strcmp(arg, "all"))
0d1e0e78 467 diffopt->flags.ignore_submodules = 1;
46a958b3 468 else if (!strcmp(arg, "untracked"))
0d1e0e78 469 diffopt->flags.ignore_untracked_in_submodules = 1;
46a958b3 470 else if (!strcmp(arg, "dirty"))
0d1e0e78 471 diffopt->flags.ignore_dirty_submodules = 1;
aee9c7d6 472 else if (strcmp(arg, "none"))
a4ffbbbb 473 die(_("bad --ignore-submodules argument: %s"), arg);
5a59a230
NTND
474 /*
475 * Please update _git_status() in git-completion.bash when you
476 * add new options
477 */
46a958b3
JL
478}
479
4831c23f
JH
480static int prepare_submodule_diff_summary(struct repository *r, struct rev_info *rev,
481 const char *path,
482 struct commit *left, struct commit *right,
483 struct commit_list *merge_bases)
808a95dc 484{
8e6df650 485 struct commit_list *list;
808a95dc 486
85a1ec2c 487 repo_init_revisions(r, rev, NULL);
808a95dc
JN
488 setup_revisions(0, NULL, rev, NULL);
489 rev->left_right = 1;
490 rev->first_parent_only = 1;
491 left->object.flags |= SYMMETRIC_LEFT;
492 add_pending_object(rev, &left->object, path);
493 add_pending_object(rev, &right->object, path);
808a95dc
JN
494 for (list = merge_bases; list; list = list->next) {
495 list->item->object.flags |= UNINTERESTING;
496 add_pending_object(rev, &list->item->object,
f2fd0760 497 oid_to_hex(&list->item->object.oid));
808a95dc
JN
498 }
499 return prepare_revision_walk(rev);
500}
501
180b154b 502static void print_submodule_diff_summary(struct repository *r, struct rev_info *rev, struct diff_options *o)
808a95dc
JN
503{
504 static const char format[] = " %m %s";
505 struct strbuf sb = STRBUF_INIT;
506 struct commit *commit;
507
508 while ((commit = get_revision(rev))) {
509 struct pretty_print_context ctx = {0};
510 ctx.date_mode = rev->date_mode;
ecaee805 511 ctx.output_encoding = get_log_output_encoding();
808a95dc 512 strbuf_setlen(&sb, 0);
605f0ec1
SB
513 repo_format_commit_message(r, commit, format, &sb,
514 &ctx);
808a95dc 515 strbuf_addch(&sb, '\n');
f3597138
SB
516 if (commit->object.flags & SYMMETRIC_LEFT)
517 diff_emit_submodule_del(o, sb.buf);
518 else
519 diff_emit_submodule_add(o, sb.buf);
808a95dc
JN
520 }
521 strbuf_release(&sb);
522}
523
c972bf4c 524void prepare_submodule_repo_env(struct strvec *out)
6cd5757c 525{
d1fa9435 526 prepare_other_repo_env(out, DEFAULT_GIT_DIR_ENVIRONMENT);
6cd5757c
SB
527}
528
c972bf4c 529static void prepare_submodule_repo_env_in_gitdir(struct strvec *out)
a62387b3 530{
d1fa9435 531 prepare_other_repo_env(out, ".");
a62387b3
SB
532}
533
605f0ec1
SB
534/*
535 * Initialize a repository struct for a submodule based on the provided 'path'.
536 *
605f0ec1
SB
537 * Returns the repository struct on success,
538 * NULL when the submodule is not present.
8e6df650 539 */
605f0ec1
SB
540static struct repository *open_submodule(const char *path)
541{
542 struct strbuf sb = STRBUF_INIT;
543 struct repository *out = xmalloc(sizeof(*out));
544
545 if (submodule_to_gitdir(&sb, path) || repo_init(out, sb.buf, NULL)) {
546 strbuf_release(&sb);
547 free(out);
548 return NULL;
549 }
550
551 /* Mark it as a submodule */
552 out->submodule_prefix = xstrdup(path);
553
554 strbuf_release(&sb);
555 return out;
556}
557
558/*
559 * Helper function to display the submodule header line prior to the full
560 * summary output.
561 *
562 * If it can locate the submodule git directory it will create a repository
563 * handle for the submodule and lookup both the left and right commits and
564 * put them into the left and right pointers.
8e6df650 565 */
605f0ec1
SB
566static void show_submodule_header(struct diff_options *o,
567 const char *path,
602a283a 568 struct object_id *one, struct object_id *two,
f3597138 569 unsigned dirty_submodule,
605f0ec1 570 struct repository *sub,
8e6df650
JK
571 struct commit **left, struct commit **right,
572 struct commit_list **merge_bases)
752c0c24 573{
752c0c24
JS
574 const char *message = NULL;
575 struct strbuf sb = STRBUF_INIT;
752c0c24
JS
576 int fast_forward = 0, fast_backward = 0;
577
c7e1a736 578 if (dirty_submodule & DIRTY_SUBMODULE_UNTRACKED)
f3597138
SB
579 diff_emit_submodule_untracked(o, path);
580
c7e1a736 581 if (dirty_submodule & DIRTY_SUBMODULE_MODIFIED)
f3597138 582 diff_emit_submodule_modified(o, path);
c7e1a736 583
8e6df650
JK
584 if (is_null_oid(one))
585 message = "(new submodule)";
586 else if (is_null_oid(two))
587 message = "(submodule deleted)";
588
605f0ec1 589 if (!sub) {
8e6df650 590 if (!message)
2d94dd2f 591 message = "(commits not present)";
8e6df650
JK
592 goto output_header;
593 }
594
595 /*
596 * Attempt to lookup the commit references, and determine if this is
597 * a fast forward or fast backwards update.
598 */
605f0ec1
SB
599 *left = lookup_commit_reference(sub, one);
600 *right = lookup_commit_reference(sub, two);
8e6df650
JK
601
602 /*
603 * Warn about missing commits in the submodule project, but only if
604 * they aren't null.
605 */
606 if ((!is_null_oid(one) && !*left) ||
607 (!is_null_oid(two) && !*right))
608 message = "(commits not present)";
609
605f0ec1 610 *merge_bases = repo_get_merge_bases(sub, *left, *right);
8e6df650
JK
611 if (*merge_bases) {
612 if ((*merge_bases)->item == *left)
613 fast_forward = 1;
614 else if ((*merge_bases)->item == *right)
615 fast_backward = 1;
616 }
617
4a7e27e9 618 if (oideq(one, two)) {
c7e1a736
JL
619 strbuf_release(&sb);
620 return;
621 }
622
8e6df650 623output_header:
f3597138 624 strbuf_addf(&sb, "Submodule %s ", path);
30e677e0 625 strbuf_add_unique_abbrev(&sb, one, DEFAULT_ABBREV);
a94bb683 626 strbuf_addstr(&sb, (fast_backward || fast_forward) ? ".." : "...");
30e677e0 627 strbuf_add_unique_abbrev(&sb, two, DEFAULT_ABBREV);
752c0c24 628 if (message)
f3597138 629 strbuf_addf(&sb, " %s\n", message);
752c0c24 630 else
f3597138
SB
631 strbuf_addf(&sb, "%s:\n", fast_backward ? " (rewind)" : "");
632 diff_emit_submodule_header(o, sb.buf);
752c0c24 633
752c0c24
JS
634 strbuf_release(&sb);
635}
ee6fc514 636
180b154b 637void show_submodule_diff_summary(struct diff_options *o, const char *path,
8e6df650 638 struct object_id *one, struct object_id *two,
f3597138 639 unsigned dirty_submodule)
8e6df650 640{
f196c1e9 641 struct rev_info rev = REV_INFO_INIT;
8e6df650
JK
642 struct commit *left = NULL, *right = NULL;
643 struct commit_list *merge_bases = NULL;
605f0ec1 644 struct repository *sub;
8e6df650 645
605f0ec1 646 sub = open_submodule(path);
f3597138 647 show_submodule_header(o, path, one, two, dirty_submodule,
605f0ec1 648 sub, &left, &right, &merge_bases);
8e6df650
JK
649
650 /*
651 * If we don't have both a left and a right pointer, there is no
652 * reason to try and display a summary. The header line should contain
653 * all the information the user needs.
654 */
605f0ec1 655 if (!left || !right || !sub)
8e6df650
JK
656 goto out;
657
658 /* Treat revision walker failure the same as missing commits */
4831c23f 659 if (prepare_submodule_diff_summary(sub, &rev, path, left, right, merge_bases)) {
f3597138 660 diff_emit_submodule_error(o, "(revision walker failed)\n");
8e6df650
JK
661 goto out;
662 }
663
180b154b 664 print_submodule_diff_summary(sub, &rev, o);
8e6df650
JK
665
666out:
bf20fe4c 667 free_commit_list(merge_bases);
f196c1e9 668 release_revisions(&rev);
8e6df650
JK
669 clear_commit_marks(left, ~0);
670 clear_commit_marks(right, ~0);
605f0ec1
SB
671 if (sub) {
672 repo_clear(sub);
673 free(sub);
674 }
8e6df650
JK
675}
676
f3597138 677void show_submodule_inline_diff(struct diff_options *o, const char *path,
fd47ae6a 678 struct object_id *one, struct object_id *two,
f3597138 679 unsigned dirty_submodule)
fd47ae6a 680{
bc099914 681 const struct object_id *old_oid = the_hash_algo->empty_tree, *new_oid = the_hash_algo->empty_tree;
fd47ae6a
JK
682 struct commit *left = NULL, *right = NULL;
683 struct commit_list *merge_bases = NULL;
fd47ae6a 684 struct child_process cp = CHILD_PROCESS_INIT;
f3597138 685 struct strbuf sb = STRBUF_INIT;
605f0ec1 686 struct repository *sub;
fd47ae6a 687
605f0ec1 688 sub = open_submodule(path);
f3597138 689 show_submodule_header(o, path, one, two, dirty_submodule,
605f0ec1 690 sub, &left, &right, &merge_bases);
fd47ae6a
JK
691
692 /* We need a valid left and right commit to display a difference */
693 if (!(left || is_null_oid(one)) ||
694 !(right || is_null_oid(two)))
695 goto done;
696
697 if (left)
bc099914 698 old_oid = one;
fd47ae6a 699 if (right)
bc099914 700 new_oid = two;
fd47ae6a 701
fd47ae6a
JK
702 cp.git_cmd = 1;
703 cp.dir = path;
f3597138 704 cp.out = -1;
fd47ae6a
JK
705 cp.no_stdin = 1;
706
707 /* TODO: other options may need to be passed here. */
c972bf4c
JK
708 strvec_pushl(&cp.args, "diff", "--submodule=diff", NULL);
709 strvec_pushf(&cp.args, "--color=%s", want_color(o->use_color) ?
f3597138 710 "always" : "never");
5a522142 711
0d1e0e78 712 if (o->flags.reverse_diff) {
c972bf4c 713 strvec_pushf(&cp.args, "--src-prefix=%s%s/",
f6d8942b 714 o->b_prefix, path);
c972bf4c 715 strvec_pushf(&cp.args, "--dst-prefix=%s%s/",
f6d8942b 716 o->a_prefix, path);
fd47ae6a 717 } else {
c972bf4c 718 strvec_pushf(&cp.args, "--src-prefix=%s%s/",
f6d8942b 719 o->a_prefix, path);
c972bf4c 720 strvec_pushf(&cp.args, "--dst-prefix=%s%s/",
f6d8942b 721 o->b_prefix, path);
fd47ae6a 722 }
c972bf4c 723 strvec_push(&cp.args, oid_to_hex(old_oid));
fd47ae6a
JK
724 /*
725 * If the submodule has modified content, we will diff against the
726 * work tree, under the assumption that the user has asked for the
727 * diff format and wishes to actually see all differences even if they
728 * haven't yet been committed to the submodule yet.
729 */
730 if (!(dirty_submodule & DIRTY_SUBMODULE_MODIFIED))
c972bf4c 731 strvec_push(&cp.args, oid_to_hex(new_oid));
fd47ae6a 732
17b254cd 733 prepare_submodule_repo_env(&cp.env_array);
f1c0368d
DT
734
735 if (!is_directory(path)) {
736 /* fall back to absorbed git dir, if any */
737 if (!sub)
738 goto done;
739 cp.dir = sub->gitdir;
740 strvec_push(&cp.env_array, GIT_DIR_ENVIRONMENT "=.");
741 strvec_push(&cp.env_array, GIT_WORK_TREE_ENVIRONMENT "=.");
742 }
743
67f61efb 744 if (start_command(&cp)) {
f3597138 745 diff_emit_submodule_error(o, "(diff failed)\n");
67f61efb
DT
746 goto done;
747 }
f3597138
SB
748
749 while (strbuf_getwholeline_fd(&sb, cp.out, '\n') != EOF)
750 diff_emit_submodule_pipethrough(o, sb.buf, sb.len);
751
752 if (finish_command(&cp))
753 diff_emit_submodule_error(o, "(diff failed)\n");
fd47ae6a
JK
754
755done:
f3597138 756 strbuf_release(&sb);
bf20fe4c 757 free_commit_list(merge_bases);
fd47ae6a
JK
758 if (left)
759 clear_commit_marks(left, ~0);
760 if (right)
761 clear_commit_marks(right, ~0);
605f0ec1
SB
762 if (sub) {
763 repo_clear(sub);
764 free(sub);
765 }
fd47ae6a
JK
766}
767
84f8925e
SB
768int should_update_submodules(void)
769{
770 return config_update_recurse_submodules == RECURSE_SUBMODULES_ON;
771}
772
773const struct submodule *submodule_from_ce(const struct cache_entry *ce)
774{
775 if (!S_ISGITLINK(ce->ce_mode))
776 return NULL;
777
778 if (!should_update_submodules())
779 return NULL;
780
14228447 781 return submodule_from_path(the_repository, null_oid(), ce->name);
84f8925e
SB
782}
783
aacc5c1a 784static struct oid_array *submodule_commits(struct string_list *submodules,
c68f8375 785 const char *name)
aacc5c1a
BW
786{
787 struct string_list_item *item;
788
c68f8375 789 item = string_list_insert(submodules, name);
aacc5c1a
BW
790 if (item->util)
791 return (struct oid_array *) item->util;
792
793 /* NEEDSWORK: should we have oid_array_init()? */
794 item->util = xcalloc(1, sizeof(struct oid_array));
795 return (struct oid_array *) item->util;
796}
797
c68f8375 798struct collect_changed_submodules_cb_data {
6245b98b 799 struct repository *repo;
c68f8375
HV
800 struct string_list *changed;
801 const struct object_id *commit_oid;
802};
803
804/*
805 * this would normally be two functions: default_name_from_path() and
806 * path_from_default_name(). Since the default name is the same as
807 * the submodule path we can get away with just one function which only
808 * checks whether there is a submodule in the working directory at that
809 * location.
810 */
811static const char *default_name_or_path(const char *path_or_name)
812{
813 int error_code;
814
815 if (!is_submodule_populated_gently(path_or_name, &error_code))
816 return NULL;
817
818 return path_or_name;
819}
820
aacc5c1a
BW
821static void collect_changed_submodules_cb(struct diff_queue_struct *q,
822 struct diff_options *options,
823 void *data)
824{
c68f8375
HV
825 struct collect_changed_submodules_cb_data *me = data;
826 struct string_list *changed = me->changed;
827 const struct object_id *commit_oid = me->commit_oid;
aacc5c1a 828 int i;
aacc5c1a
BW
829
830 for (i = 0; i < q->nr; i++) {
831 struct diff_filepair *p = q->queue[i];
832 struct oid_array *commits;
c68f8375
HV
833 const struct submodule *submodule;
834 const char *name;
835
aacc5c1a
BW
836 if (!S_ISGITLINK(p->two->mode))
837 continue;
838
6245b98b 839 submodule = submodule_from_path(me->repo,
3b8fb393 840 commit_oid, p->two->path);
c68f8375
HV
841 if (submodule)
842 name = submodule->name;
843 else {
844 name = default_name_or_path(p->two->path);
845 /* make sure name does not collide with existing one */
5fc84755 846 if (name)
6245b98b 847 submodule = submodule_from_name(me->repo,
5fc84755 848 commit_oid, name);
c68f8375 849 if (submodule) {
a4ffbbbb 850 warning(_("Submodule in commit %s at path: "
c68f8375 851 "'%s' collides with a submodule named "
a4ffbbbb 852 "the same. Skipping it."),
5fc84755 853 oid_to_hex(commit_oid), p->two->path);
c68f8375
HV
854 name = NULL;
855 }
aacc5c1a 856 }
c68f8375
HV
857
858 if (!name)
859 continue;
860
861 commits = submodule_commits(changed, name);
862 oid_array_append(commits, &p->two->oid);
aacc5c1a
BW
863 }
864}
865
866/*
867 * Collect the paths of submodules in 'changed' which have changed based on
868 * the revisions as specified in 'argv'. Each entry in 'changed' will also
869 * have a corresponding 'struct oid_array' (in the 'util' field) which lists
870 * what the submodule pointers were updated to during the change.
871 */
6245b98b 872static void collect_changed_submodules(struct repository *r,
174d131f 873 struct string_list *changed,
c972bf4c 874 struct strvec *argv)
aacc5c1a
BW
875{
876 struct rev_info rev;
877 const struct commit *commit;
a462bee5
OS
878 int save_warning;
879 struct setup_revision_opt s_r_opt = {
880 .assume_dashdash = 1,
881 };
aacc5c1a 882
a462bee5
OS
883 save_warning = warn_on_object_refname_ambiguity;
884 warn_on_object_refname_ambiguity = 0;
6245b98b 885 repo_init_revisions(r, &rev, NULL);
a462bee5
OS
886 setup_revisions(argv->nr, argv->v, &rev, &s_r_opt);
887 warn_on_object_refname_ambiguity = save_warning;
aacc5c1a 888 if (prepare_revision_walk(&rev))
a4ffbbbb 889 die(_("revision walk setup failed"));
aacc5c1a
BW
890
891 while ((commit = get_revision(&rev))) {
892 struct rev_info diff_rev;
c68f8375 893 struct collect_changed_submodules_cb_data data;
6245b98b 894 data.repo = r;
c68f8375
HV
895 data.changed = changed;
896 data.commit_oid = &commit->object.oid;
aacc5c1a 897
6245b98b 898 repo_init_revisions(r, &diff_rev, NULL);
aacc5c1a
BW
899 diff_rev.diffopt.output_format |= DIFF_FORMAT_CALLBACK;
900 diff_rev.diffopt.format_callback = collect_changed_submodules_cb;
c68f8375 901 diff_rev.diffopt.format_callback_data = &data;
d01141de
SO
902 diff_rev.dense_combined_merges = 1;
903 diff_tree_combined_merge(commit, &diff_rev);
2108fe4a 904 release_revisions(&diff_rev);
aacc5c1a
BW
905 }
906
907 reset_revision_walk();
2108fe4a 908 release_revisions(&rev);
aacc5c1a
BW
909}
910
911static void free_submodules_oids(struct string_list *submodules)
912{
913 struct string_list_item *item;
914 for_each_string_list_item(item, submodules)
915 oid_array_clear((struct oid_array *) item->util);
916 string_list_clear(submodules, 1);
917}
918
7290ef58
MH
919static int has_remote(const char *refname, const struct object_id *oid,
920 int flags, void *cb_data)
d2b17b32
FG
921{
922 return 1;
923}
924
1b7ba794 925static int append_oid_to_argv(const struct object_id *oid, void *data)
d2b17b32 926{
c972bf4c
JK
927 struct strvec *argv = data;
928 strvec_push(argv, oid_to_hex(oid));
9cfa1c26
HV
929 return 0;
930}
931
3c96aa97 932struct has_commit_data {
6245b98b 933 struct repository *repo;
3c96aa97
SB
934 int result;
935 const char *path;
936};
937
1b7ba794 938static int check_has_commit(const struct object_id *oid, void *data)
d2b17b32 939{
3c96aa97 940 struct has_commit_data *cb = data;
13a2f620
JT
941 struct repository subrepo;
942 enum object_type type;
5b6607d2 943
13a2f620
JT
944 if (repo_submodule_init(&subrepo, cb->repo, cb->path, null_oid())) {
945 cb->result = 0;
946 goto cleanup;
947 }
948
949 type = oid_object_info(&subrepo, oid, NULL);
5b6607d2 950
3c96aa97
SB
951 switch (type) {
952 case OBJ_COMMIT:
13a2f620 953 goto cleanup;
3c96aa97
SB
954 case OBJ_BAD:
955 /*
956 * Object is missing or invalid. If invalid, an error message
957 * has already been printed.
958 */
959 cb->result = 0;
13a2f620 960 goto cleanup;
3c96aa97
SB
961 default:
962 die(_("submodule entry '%s' (%s) is a %s, not a commit"),
debca9d2 963 cb->path, oid_to_hex(oid), type_name(type));
3c96aa97 964 }
13a2f620
JT
965cleanup:
966 repo_clear(&subrepo);
967 return 0;
5b6607d2
HV
968}
969
6245b98b
NTND
970static int submodule_has_commits(struct repository *r,
971 const char *path,
972 struct oid_array *commits)
5b6607d2 973{
6245b98b 974 struct has_commit_data has_commit = { r, 1, path };
5b6607d2 975
7c8d2b00 976 /*
64127575 977 * Perform a cheap, but incorrect check for the existence of 'commits'.
7c8d2b00 978 * This is done by adding the submodule's object store to the in-core
64127575 979 * object store, and then querying for each commit's existence. If we
7c8d2b00
BW
980 * do not have the commit object anywhere, there is no chance we have
981 * it in the object store of the correct submodule and have it
982 * reachable from a ref, so we can fail early without spawning rev-list
983 * which is expensive.
984 */
5b6607d2
HV
985 if (add_submodule_odb(path))
986 return 0;
987
910650d2 988 oid_array_for_each_unique(commits, check_has_commit, &has_commit);
7c8d2b00 989
3c96aa97 990 if (has_commit.result) {
7c8d2b00
BW
991 /*
992 * Even if the submodule is checked out and the commit is
993 * present, make sure it exists in the submodule's object store
994 * and that it is reachable from a ref.
995 */
996 struct child_process cp = CHILD_PROCESS_INIT;
997 struct strbuf out = STRBUF_INIT;
998
c972bf4c 999 strvec_pushl(&cp.args, "rev-list", "-n", "1", NULL);
7c8d2b00 1000 oid_array_for_each_unique(commits, append_oid_to_argv, &cp.args);
c972bf4c 1001 strvec_pushl(&cp.args, "--not", "--all", NULL);
7c8d2b00
BW
1002
1003 prepare_submodule_repo_env(&cp.env_array);
1004 cp.git_cmd = 1;
1005 cp.no_stdin = 1;
1006 cp.dir = path;
1007
1008 if (capture_command(&cp, &out, GIT_MAX_HEXSZ + 1) || out.len)
3c96aa97 1009 has_commit.result = 0;
7c8d2b00
BW
1010
1011 strbuf_release(&out);
1012 }
1013
3c96aa97 1014 return has_commit.result;
5b6607d2
HV
1015}
1016
6245b98b
NTND
1017static int submodule_needs_pushing(struct repository *r,
1018 const char *path,
1019 struct oid_array *commits)
5b6607d2 1020{
6245b98b 1021 if (!submodule_has_commits(r, path, commits))
250ab24a
HV
1022 /*
1023 * NOTE: We do consider it safe to return "no" here. The
1024 * correct answer would be "We do not know" instead of
1025 * "No push needed", but it is quite hard to change
1026 * the submodule pointer without having the submodule
1027 * around. If a user did however change the submodules
1028 * without having the submodule around, this indicates
1029 * an expert who knows what they are doing or a
1030 * maintainer integrating work from other people. In
1031 * both cases it should be safe to skip this check.
1032 */
d2b17b32
FG
1033 return 0;
1034
1035 if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
d3180279 1036 struct child_process cp = CHILD_PROCESS_INIT;
d2b17b32
FG
1037 struct strbuf buf = STRBUF_INIT;
1038 int needs_pushing = 0;
1039
c972bf4c 1040 strvec_push(&cp.args, "rev-list");
910650d2 1041 oid_array_for_each_unique(commits, append_oid_to_argv, &cp.args);
c972bf4c 1042 strvec_pushl(&cp.args, "--not", "--remotes", "-n", "1" , NULL);
5b6607d2 1043
c12e8656 1044 prepare_submodule_repo_env(&cp.env_array);
d2b17b32
FG
1045 cp.git_cmd = 1;
1046 cp.no_stdin = 1;
1047 cp.out = -1;
1048 cp.dir = path;
1049 if (start_command(&cp))
a4ffbbbb 1050 die(_("Could not run 'git rev-list <commits> --not --remotes -n 1' command in submodule %s"),
5b6607d2 1051 path);
db1ba2a2 1052 if (strbuf_read(&buf, cp.out, the_hash_algo->hexsz + 1))
d2b17b32
FG
1053 needs_pushing = 1;
1054 finish_command(&cp);
1055 close(cp.out);
1056 strbuf_release(&buf);
1057 return needs_pushing;
1058 }
1059
1060 return 0;
1061}
1062
6245b98b 1063int find_unpushed_submodules(struct repository *r,
174d131f
NTND
1064 struct oid_array *commits,
1065 const char *remotes_name,
1066 struct string_list *needs_pushing)
d2b17b32 1067{
14739447 1068 struct string_list submodules = STRING_LIST_INIT_DUP;
c68f8375 1069 struct string_list_item *name;
c972bf4c 1070 struct strvec argv = STRVEC_INIT;
a762e51e 1071
d70a9eb6 1072 /* argv.v[0] will be ignored by setup_revisions */
c972bf4c 1073 strvec_push(&argv, "find_unpushed_submodules");
910650d2 1074 oid_array_for_each_unique(commits, append_oid_to_argv, &argv);
c972bf4c
JK
1075 strvec_push(&argv, "--not");
1076 strvec_pushf(&argv, "--remotes=%s", remotes_name);
9cfa1c26 1077
6245b98b 1078 collect_changed_submodules(r, &submodules, &argv);
d2b17b32 1079
c68f8375
HV
1080 for_each_string_list_item(name, &submodules) {
1081 struct oid_array *commits = name->util;
1082 const struct submodule *submodule;
1083 const char *path = NULL;
1084
14228447 1085 submodule = submodule_from_name(r, null_oid(), name->string);
c68f8375
HV
1086 if (submodule)
1087 path = submodule->path;
1088 else
1089 path = default_name_or_path(name->string);
1090
1091 if (!path)
1092 continue;
5b6607d2 1093
6245b98b 1094 if (submodule_needs_pushing(r, path, commits))
aacc5c1a 1095 string_list_insert(needs_pushing, path);
14739447 1096 }
610b2337
BW
1097
1098 free_submodules_oids(&submodules);
c972bf4c 1099 strvec_clear(&argv);
d2b17b32 1100
a762e51e 1101 return needs_pushing->nr;
d2b17b32
FG
1102}
1103
2a90556d 1104static int push_submodule(const char *path,
06bf4ad1 1105 const struct remote *remote,
60fba4bf 1106 const struct refspec *rs,
2a90556d
BW
1107 const struct string_list *push_options,
1108 int dry_run)
eb21c732 1109{
eb21c732 1110 if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
d3180279 1111 struct child_process cp = CHILD_PROCESS_INIT;
c972bf4c 1112 strvec_push(&cp.args, "push");
0301c821 1113 if (dry_run)
c972bf4c 1114 strvec_push(&cp.args, "--dry-run");
eb21c732 1115
2a90556d
BW
1116 if (push_options && push_options->nr) {
1117 const struct string_list_item *item;
1118 for_each_string_list_item(item, push_options)
c972bf4c 1119 strvec_pushf(&cp.args, "--push-option=%s",
f6d8942b 1120 item->string);
2a90556d 1121 }
06bf4ad1
BW
1122
1123 if (remote->origin != REMOTE_UNCONFIGURED) {
1124 int i;
c972bf4c 1125 strvec_push(&cp.args, remote->name);
60fba4bf 1126 for (i = 0; i < rs->raw_nr; i++)
c972bf4c 1127 strvec_push(&cp.args, rs->raw[i]);
06bf4ad1
BW
1128 }
1129
c12e8656 1130 prepare_submodule_repo_env(&cp.env_array);
eb21c732
HV
1131 cp.git_cmd = 1;
1132 cp.no_stdin = 1;
1133 cp.dir = path;
1134 if (run_command(&cp))
1135 return 0;
1136 close(cp.out);
1137 }
1138
1139 return 1;
1140}
1141
06bf4ad1
BW
1142/*
1143 * Perform a check in the submodule to see if the remote and refspec work.
1144 * Die if the submodule can't be pushed.
1145 */
c7be7201
BW
1146static void submodule_push_check(const char *path, const char *head,
1147 const struct remote *remote,
60fba4bf 1148 const struct refspec *rs)
06bf4ad1
BW
1149{
1150 struct child_process cp = CHILD_PROCESS_INIT;
1151 int i;
1152
c972bf4c
JK
1153 strvec_push(&cp.args, "submodule--helper");
1154 strvec_push(&cp.args, "push-check");
1155 strvec_push(&cp.args, head);
1156 strvec_push(&cp.args, remote->name);
06bf4ad1 1157
60fba4bf 1158 for (i = 0; i < rs->raw_nr; i++)
c972bf4c 1159 strvec_push(&cp.args, rs->raw[i]);
06bf4ad1
BW
1160
1161 prepare_submodule_repo_env(&cp.env_array);
1162 cp.git_cmd = 1;
1163 cp.no_stdin = 1;
1164 cp.no_stdout = 1;
1165 cp.dir = path;
1166
1167 /*
1168 * Simply indicate if 'submodule--helper push-check' failed.
1169 * More detailed error information will be provided by the
1170 * child process.
1171 */
1172 if (run_command(&cp))
a4ffbbbb 1173 die(_("process for submodule '%s' failed"), path);
06bf4ad1
BW
1174}
1175
6245b98b 1176int push_unpushed_submodules(struct repository *r,
174d131f 1177 struct oid_array *commits,
06bf4ad1 1178 const struct remote *remote,
60fba4bf 1179 const struct refspec *rs,
2a90556d 1180 const struct string_list *push_options,
0301c821 1181 int dry_run)
eb21c732
HV
1182{
1183 int i, ret = 1;
f93d7c6f 1184 struct string_list needs_pushing = STRING_LIST_INIT_DUP;
eb21c732 1185
6245b98b 1186 if (!find_unpushed_submodules(r, commits,
174d131f 1187 remote->name, &needs_pushing))
eb21c732
HV
1188 return 1;
1189
06bf4ad1
BW
1190 /*
1191 * Verify that the remote and refspec can be propagated to all
1192 * submodules. This check can be skipped if the remote and refspec
1193 * won't be propagated due to the remote being unconfigured (e.g. a URL
1194 * instead of a remote name).
1195 */
c7be7201
BW
1196 if (remote->origin != REMOTE_UNCONFIGURED) {
1197 char *head;
1198 struct object_id head_oid;
1199
0f2dc722 1200 head = resolve_refdup("HEAD", 0, &head_oid, NULL);
c7be7201
BW
1201 if (!head)
1202 die(_("Failed to resolve HEAD as a valid ref."));
1203
06bf4ad1
BW
1204 for (i = 0; i < needs_pushing.nr; i++)
1205 submodule_push_check(needs_pushing.items[i].string,
60fba4bf 1206 head, remote, rs);
c7be7201
BW
1207 free(head);
1208 }
06bf4ad1
BW
1209
1210 /* Actually push the submodules */
eb21c732
HV
1211 for (i = 0; i < needs_pushing.nr; i++) {
1212 const char *path = needs_pushing.items[i].string;
a4ffbbbb 1213 fprintf(stderr, _("Pushing submodule '%s'\n"), path);
60fba4bf 1214 if (!push_submodule(path, remote, rs,
06bf4ad1 1215 push_options, dry_run)) {
a4ffbbbb 1216 fprintf(stderr, _("Unable to push submodule '%s'\n"), path);
eb21c732
HV
1217 ret = 0;
1218 }
1219 }
1220
1221 string_list_clear(&needs_pushing, 0);
1222
1223 return ret;
1224}
1225
419fd786
BW
1226static int append_oid_to_array(const char *ref, const struct object_id *oid,
1227 int flags, void *data)
6859de45 1228{
419fd786
BW
1229 struct oid_array *array = data;
1230 oid_array_append(array, oid);
6859de45
JK
1231 return 0;
1232}
1233
2eb80bcd 1234void check_for_new_submodule_commits(struct object_id *oid)
6859de45
JK
1235{
1236 if (!initialized_fetch_ref_tips) {
419fd786 1237 for_each_ref(append_oid_to_array, &ref_tips_before_fetch);
6859de45
JK
1238 initialized_fetch_ref_tips = 1;
1239 }
1240
910650d2 1241 oid_array_append(&ref_tips_after_fetch, oid);
6859de45
JK
1242}
1243
16dd6fe1
SB
1244static void calculate_changed_submodule_paths(struct repository *r,
1245 struct string_list *changed_submodule_names)
88a21979 1246{
c972bf4c 1247 struct strvec argv = STRVEC_INIT;
bcd73372 1248 struct string_list_item *name;
88a21979 1249
18322bad 1250 /* No need to check if there are no submodules configured */
6245b98b 1251 if (!submodule_from_path(r, NULL, NULL))
18322bad
JL
1252 return;
1253
c972bf4c 1254 strvec_push(&argv, "--"); /* argv[0] program name */
910650d2 1255 oid_array_for_each_unique(&ref_tips_after_fetch,
d1a8460c 1256 append_oid_to_argv, &argv);
c972bf4c 1257 strvec_push(&argv, "--not");
910650d2 1258 oid_array_for_each_unique(&ref_tips_before_fetch,
d1a8460c 1259 append_oid_to_argv, &argv);
88a21979
JL
1260
1261 /*
1262 * Collect all submodules (whether checked out or not) for which new
c68f8375 1263 * commits have been recorded upstream in "changed_submodule_names".
88a21979 1264 */
bcd73372 1265 collect_changed_submodules(r, changed_submodule_names, &argv);
aacc5c1a 1266
bcd73372 1267 for_each_string_list_item(name, changed_submodule_names) {
c68f8375
HV
1268 struct oid_array *commits = name->util;
1269 const struct submodule *submodule;
1270 const char *path = NULL;
1271
14228447 1272 submodule = submodule_from_name(r, null_oid(), name->string);
c68f8375
HV
1273 if (submodule)
1274 path = submodule->path;
1275 else
1276 path = default_name_or_path(name->string);
1277
1278 if (!path)
1279 continue;
aacc5c1a 1280
bcd73372
SB
1281 if (submodule_has_commits(r, path, commits)) {
1282 oid_array_clear(commits);
1283 *name->string = '\0';
1284 }
88a21979 1285 }
6859de45 1286
bcd73372
SB
1287 string_list_remove_empty_items(changed_submodule_names, 1);
1288
c972bf4c 1289 strvec_clear(&argv);
910650d2 1290 oid_array_clear(&ref_tips_before_fetch);
1291 oid_array_clear(&ref_tips_after_fetch);
6859de45 1292 initialized_fetch_ref_tips = 0;
88a21979
JL
1293}
1294
6245b98b 1295int submodule_touches_in_range(struct repository *r,
174d131f 1296 struct object_id *excl_oid,
a6d7eb2c
SB
1297 struct object_id *incl_oid)
1298{
1299 struct string_list subs = STRING_LIST_INIT_DUP;
c972bf4c 1300 struct strvec args = STRVEC_INIT;
a6d7eb2c
SB
1301 int ret;
1302
a6d7eb2c 1303 /* No need to check if there are no submodules configured */
6245b98b 1304 if (!submodule_from_path(r, NULL, NULL))
a6d7eb2c
SB
1305 return 0;
1306
c972bf4c
JK
1307 strvec_push(&args, "--"); /* args[0] program name */
1308 strvec_push(&args, oid_to_hex(incl_oid));
4d36f88b 1309 if (!is_null_oid(excl_oid)) {
c972bf4c
JK
1310 strvec_push(&args, "--not");
1311 strvec_push(&args, oid_to_hex(excl_oid));
4d36f88b 1312 }
a6d7eb2c 1313
6245b98b 1314 collect_changed_submodules(r, &subs, &args);
a6d7eb2c
SB
1315 ret = subs.nr;
1316
c972bf4c 1317 strvec_clear(&args);
a6d7eb2c
SB
1318
1319 free_submodules_oids(&subs);
1320 return ret;
1321}
1322
fe85ee6e
SB
1323struct submodule_parallel_fetch {
1324 int count;
c972bf4c 1325 struct strvec args;
e724197f 1326 struct repository *r;
fe85ee6e
SB
1327 const char *prefix;
1328 int command_line_option;
8fa29159 1329 int default_option;
fe85ee6e
SB
1330 int quiet;
1331 int result;
16dd6fe1
SB
1332
1333 struct string_list changed_submodule_names;
be76c212
SB
1334
1335 /* Pending fetches by OIDs */
1336 struct fetch_task **oid_fetch_tasks;
1337 int oid_fetch_tasks_nr, oid_fetch_tasks_alloc;
02225408
ES
1338
1339 struct strbuf submodules_with_errors;
fe85ee6e 1340};
f69a6e4f
ÆAB
1341#define SPF_INIT { \
1342 .args = STRVEC_INIT, \
1343 .changed_submodule_names = STRING_LIST_INIT_DUP, \
1344 .submodules_with_errors = STRBUF_INIT, \
1345}
fe85ee6e 1346
4b4acedd
HV
1347static int get_fetch_recurse_config(const struct submodule *submodule,
1348 struct submodule_parallel_fetch *spf)
1349{
1350 if (spf->command_line_option != RECURSE_SUBMODULES_DEFAULT)
1351 return spf->command_line_option;
1352
1353 if (submodule) {
1354 char *key;
1355 const char *value;
1356
1357 int fetch_recurse = submodule->fetch_recurse;
1358 key = xstrfmt("submodule.%s.fetchRecurseSubmodules", submodule->name);
f1de981e 1359 if (!repo_config_get_string_tmp(spf->r, key, &value)) {
4b4acedd
HV
1360 fetch_recurse = parse_fetch_recurse_submodules_arg(key, value);
1361 }
1362 free(key);
1363
1364 if (fetch_recurse != RECURSE_SUBMODULES_NONE)
1365 /* local config overrules everything except commandline */
1366 return fetch_recurse;
1367 }
1368
1369 return spf->default_option;
1370}
1371
be76c212
SB
1372/*
1373 * Fetch in progress (if callback data) or
1374 * pending (if in oid_fetch_tasks in struct submodule_parallel_fetch)
1375 */
1376struct fetch_task {
1377 struct repository *repo;
1378 const struct submodule *sub;
1379 unsigned free_sub : 1; /* Do we need to free the submodule? */
1380
1381 struct oid_array *commits; /* Ensure these commits are fetched */
1382};
1383
1384/**
1385 * When a submodule is not defined in .gitmodules, we cannot access it
1386 * via the regular submodule-config. Create a fake submodule, which we can
1387 * work on.
1388 */
1389static const struct submodule *get_non_gitmodules_submodule(const char *path)
1390{
1391 struct submodule *ret = NULL;
1392 const char *name = default_name_or_path(path);
1393
1394 if (!name)
1395 return NULL;
1396
1397 ret = xmalloc(sizeof(*ret));
1398 memset(ret, 0, sizeof(*ret));
1399 ret->path = name;
1400 ret->name = name;
1401
1402 return (const struct submodule *) ret;
1403}
1404
1405static struct fetch_task *fetch_task_create(struct repository *r,
1406 const char *path)
1407{
1408 struct fetch_task *task = xmalloc(sizeof(*task));
1409 memset(task, 0, sizeof(*task));
1410
14228447 1411 task->sub = submodule_from_path(r, null_oid(), path);
be76c212
SB
1412 if (!task->sub) {
1413 /*
1414 * No entry in .gitmodules? Technically not a submodule,
1415 * but historically we supported repositories that happen to be
1416 * in-place where a gitlink is. Keep supporting them.
1417 */
1418 task->sub = get_non_gitmodules_submodule(path);
1419 if (!task->sub) {
1420 free(task);
1421 return NULL;
1422 }
1423
1424 task->free_sub = 1;
1425 }
1426
1427 return task;
1428}
1429
1430static void fetch_task_release(struct fetch_task *p)
1431{
1432 if (p->free_sub)
1433 free((void*)p->sub);
1434 p->free_sub = 0;
1435 p->sub = NULL;
1436
1437 if (p->repo)
1438 repo_clear(p->repo);
1439 FREE_AND_NULL(p->repo);
1440}
1441
26f80ccf 1442static struct repository *get_submodule_repo_for(struct repository *r,
8eb8dcf9 1443 const char *path)
26f80ccf
SB
1444{
1445 struct repository *ret = xmalloc(sizeof(*ret));
1446
8eb8dcf9 1447 if (repo_submodule_init(ret, r, path, null_oid())) {
5df5106e
JT
1448 free(ret);
1449 return NULL;
26f80ccf
SB
1450 }
1451
1452 return ret;
1453}
1454
fe85ee6e
SB
1455static int get_next_submodule(struct child_process *cp,
1456 struct strbuf *err, void *data, void **task_cb)
7dce19d3 1457{
fe85ee6e 1458 struct submodule_parallel_fetch *spf = data;
6859de45 1459
e724197f 1460 for (; spf->count < spf->r->index->cache_nr; spf->count++) {
e724197f 1461 const struct cache_entry *ce = spf->r->index->cache[spf->count];
26f80ccf 1462 const char *default_argv;
be76c212 1463 struct fetch_task *task;
7dce19d3
JL
1464
1465 if (!S_ISGITLINK(ce->ce_mode))
1466 continue;
1467
be76c212
SB
1468 task = fetch_task_create(spf->r, ce->name);
1469 if (!task)
1470 continue;
492c6c46 1471
be76c212 1472 switch (get_fetch_recurse_config(task->sub, spf))
4b4acedd
HV
1473 {
1474 default:
1475 case RECURSE_SUBMODULES_DEFAULT:
1476 case RECURSE_SUBMODULES_ON_DEMAND:
be76c212 1477 if (!task->sub ||
08a297bd 1478 !string_list_lookup(
16dd6fe1 1479 &spf->changed_submodule_names,
be76c212 1480 task->sub->name))
8f0700dd
JL
1481 continue;
1482 default_argv = "on-demand";
4b4acedd
HV
1483 break;
1484 case RECURSE_SUBMODULES_ON:
1485 default_argv = "yes";
1486 break;
1487 case RECURSE_SUBMODULES_OFF:
1488 continue;
be254a0e
JL
1489 }
1490
8eb8dcf9 1491 task->repo = get_submodule_repo_for(spf->r, task->sub->path);
be76c212
SB
1492 if (task->repo) {
1493 struct strbuf submodule_prefix = STRBUF_INIT;
fe85ee6e 1494 child_process_init(cp);
be76c212 1495 cp->dir = task->repo->gitdir;
a62387b3 1496 prepare_submodule_repo_env_in_gitdir(&cp->env_array);
fe85ee6e
SB
1497 cp->git_cmd = 1;
1498 if (!spf->quiet)
a4ffbbbb 1499 strbuf_addf(err, _("Fetching submodule %s%s\n"),
fe85ee6e 1500 spf->prefix, ce->name);
c972bf4c 1501 strvec_init(&cp->args);
d70a9eb6 1502 strvec_pushv(&cp->args, spf->args.v);
c972bf4c
JK
1503 strvec_push(&cp->args, default_argv);
1504 strvec_push(&cp->args, "--submodule-prefix");
be76c212
SB
1505
1506 strbuf_addf(&submodule_prefix, "%s%s/",
1507 spf->prefix,
1508 task->sub->path);
c972bf4c 1509 strvec_push(&cp->args, submodule_prefix.buf);
26f80ccf 1510
fe85ee6e 1511 spf->count++;
be76c212
SB
1512 *task_cb = task;
1513
1514 strbuf_release(&submodule_prefix);
fe85ee6e 1515 return 1;
26f80ccf 1516 } else {
505a2765 1517 struct strbuf empty_submodule_path = STRBUF_INIT;
be76c212
SB
1518
1519 fetch_task_release(task);
1520 free(task);
1521
26f80ccf
SB
1522 /*
1523 * An empty directory is normal,
1524 * the submodule is not initialized
1525 */
505a2765
PK
1526 strbuf_addf(&empty_submodule_path, "%s/%s/",
1527 spf->r->worktree,
1528 ce->name);
26f80ccf 1529 if (S_ISGITLINK(ce->ce_mode) &&
505a2765 1530 !is_empty_dir(empty_submodule_path.buf)) {
26f80ccf
SB
1531 spf->result = 1;
1532 strbuf_addf(err,
303b3c1c 1533 _("Could not access submodule '%s'\n"),
26f80ccf
SB
1534 ce->name);
1535 }
505a2765 1536 strbuf_release(&empty_submodule_path);
fe85ee6e 1537 }
7dce19d3 1538 }
be76c212
SB
1539
1540 if (spf->oid_fetch_tasks_nr) {
1541 struct fetch_task *task =
1542 spf->oid_fetch_tasks[spf->oid_fetch_tasks_nr - 1];
1543 struct strbuf submodule_prefix = STRBUF_INIT;
1544 spf->oid_fetch_tasks_nr--;
1545
1546 strbuf_addf(&submodule_prefix, "%s%s/",
1547 spf->prefix, task->sub->path);
1548
1549 child_process_init(cp);
1550 prepare_submodule_repo_env_in_gitdir(&cp->env_array);
1551 cp->git_cmd = 1;
1552 cp->dir = task->repo->gitdir;
1553
c972bf4c 1554 strvec_init(&cp->args);
d70a9eb6 1555 strvec_pushv(&cp->args, spf->args.v);
c972bf4c
JK
1556 strvec_push(&cp->args, "on-demand");
1557 strvec_push(&cp->args, "--submodule-prefix");
1558 strvec_push(&cp->args, submodule_prefix.buf);
be76c212
SB
1559
1560 /* NEEDSWORK: have get_default_remote from submodule--helper */
c972bf4c 1561 strvec_push(&cp->args, "origin");
be76c212
SB
1562 oid_array_for_each_unique(task->commits,
1563 append_oid_to_argv, &cp->args);
1564
1565 *task_cb = task;
7dce19d3 1566 strbuf_release(&submodule_prefix);
be76c212 1567 return 1;
7dce19d3 1568 }
be76c212 1569
fe85ee6e
SB
1570 return 0;
1571}
1572
2a73b3da 1573static int fetch_start_failure(struct strbuf *err,
fe85ee6e
SB
1574 void *cb, void *task_cb)
1575{
1576 struct submodule_parallel_fetch *spf = cb;
be76c212 1577 struct fetch_task *task = task_cb;
fe85ee6e
SB
1578
1579 spf->result = 1;
1580
be76c212 1581 fetch_task_release(task);
fe85ee6e
SB
1582 return 0;
1583}
1584
be76c212
SB
1585static int commit_missing_in_sub(const struct object_id *oid, void *data)
1586{
1587 struct repository *subrepo = data;
1588
1589 enum object_type type = oid_object_info(subrepo, oid, NULL);
1590
1591 return type != OBJ_COMMIT;
1592}
1593
2a73b3da
SB
1594static int fetch_finish(int retvalue, struct strbuf *err,
1595 void *cb, void *task_cb)
fe85ee6e
SB
1596{
1597 struct submodule_parallel_fetch *spf = cb;
be76c212
SB
1598 struct fetch_task *task = task_cb;
1599
1600 struct string_list_item *it;
1601 struct oid_array *commits;
fe85ee6e 1602
02225408
ES
1603 if (!task || !task->sub)
1604 BUG("callback cookie bogus");
1605
1606 if (retvalue) {
bd5e567d
JT
1607 /*
1608 * NEEDSWORK: This indicates that the overall fetch
1609 * failed, even though there may be a subsequent fetch
1610 * by commit hash that might work. It may be a good
1611 * idea to not indicate failure in this case, and only
1612 * indicate failure if the subsequent fetch fails.
1613 */
fe85ee6e
SB
1614 spf->result = 1;
1615
02225408
ES
1616 strbuf_addf(&spf->submodules_with_errors, "\t%s\n",
1617 task->sub->name);
1618 }
be76c212
SB
1619
1620 /* Is this the second time we process this submodule? */
1621 if (task->commits)
1622 goto out;
1623
1624 it = string_list_lookup(&spf->changed_submodule_names, task->sub->name);
1625 if (!it)
1626 /* Could be an unchanged submodule, not contained in the list */
1627 goto out;
1628
1629 commits = it->util;
1630 oid_array_filter(commits,
1631 commit_missing_in_sub,
1632 task->repo);
1633
1634 /* Are there commits we want, but do not exist? */
1635 if (commits->nr) {
1636 task->commits = commits;
1637 ALLOC_GROW(spf->oid_fetch_tasks,
1638 spf->oid_fetch_tasks_nr + 1,
1639 spf->oid_fetch_tasks_alloc);
1640 spf->oid_fetch_tasks[spf->oid_fetch_tasks_nr] = task;
1641 spf->oid_fetch_tasks_nr++;
1642 return 0;
1643 }
1644
1645out:
1646 fetch_task_release(task);
1647
fe85ee6e
SB
1648 return 0;
1649}
1650
e724197f 1651int fetch_populated_submodules(struct repository *r,
c972bf4c 1652 const struct strvec *options,
fe85ee6e 1653 const char *prefix, int command_line_option,
8fa29159 1654 int default_option,
62104ba1 1655 int quiet, int max_parallel_jobs)
fe85ee6e
SB
1656{
1657 int i;
fe85ee6e
SB
1658 struct submodule_parallel_fetch spf = SPF_INIT;
1659
e724197f 1660 spf.r = r;
fe85ee6e 1661 spf.command_line_option = command_line_option;
8fa29159 1662 spf.default_option = default_option;
fe85ee6e
SB
1663 spf.quiet = quiet;
1664 spf.prefix = prefix;
1665
e724197f 1666 if (!r->worktree)
fe85ee6e
SB
1667 goto out;
1668
e724197f 1669 if (repo_read_index(r) < 0)
a4ffbbbb 1670 die(_("index file corrupt"));
fe85ee6e 1671
c972bf4c 1672 strvec_push(&spf.args, "fetch");
d70a9eb6
JK
1673 for (i = 0; i < options->nr; i++)
1674 strvec_push(&spf.args, options->v[i]);
c972bf4c 1675 strvec_push(&spf.args, "--recurse-submodules-default");
fe85ee6e
SB
1676 /* default value, "--submodule-prefix" and its value are added later */
1677
16dd6fe1
SB
1678 calculate_changed_submodule_paths(r, &spf.changed_submodule_names);
1679 string_list_sort(&spf.changed_submodule_names);
ee4512ed
JH
1680 run_processes_parallel_tr2(max_parallel_jobs,
1681 get_next_submodule,
1682 fetch_start_failure,
1683 fetch_finish,
1684 &spf,
1685 "submodule", "parallel/fetch");
fe85ee6e 1686
02225408
ES
1687 if (spf.submodules_with_errors.len > 0)
1688 fprintf(stderr, _("Errors during submodule fetch:\n%s"),
1689 spf.submodules_with_errors.buf);
1690
1691
c972bf4c 1692 strvec_clear(&spf.args);
88a21979 1693out:
bcd73372 1694 free_submodules_oids(&spf.changed_submodule_names);
fe85ee6e 1695 return spf.result;
7dce19d3
JL
1696}
1697
3bfc4504 1698unsigned is_submodule_modified(const char *path, int ignore_untracked)
ee6fc514 1699{
d3180279 1700 struct child_process cp = CHILD_PROCESS_INIT;
ee6fc514 1701 struct strbuf buf = STRBUF_INIT;
af6865a7 1702 FILE *fp;
c7e1a736 1703 unsigned dirty_submodule = 0;
eee49b6c 1704 const char *git_dir;
af6865a7 1705 int ignore_cp_exit_code = 0;
ee6fc514 1706
eee49b6c 1707 strbuf_addf(&buf, "%s/.git", path);
13d6ec91 1708 git_dir = read_gitfile(buf.buf);
eee49b6c
JL
1709 if (!git_dir)
1710 git_dir = buf.buf;
5c896f7c
SB
1711 if (!is_git_directory(git_dir)) {
1712 if (is_directory(git_dir))
1713 die(_("'%s' not recognized as a git repository"), git_dir);
ee6fc514
JL
1714 strbuf_release(&buf);
1715 /* The submodule is not checked out, so it is not modified */
1716 return 0;
ee6fc514
JL
1717 }
1718 strbuf_reset(&buf);
1719
c972bf4c 1720 strvec_pushl(&cp.args, "status", "--porcelain=2", NULL);
3bfc4504 1721 if (ignore_untracked)
c972bf4c 1722 strvec_push(&cp.args, "-uno");
3bfc4504 1723
c12e8656 1724 prepare_submodule_repo_env(&cp.env_array);
ee6fc514
JL
1725 cp.git_cmd = 1;
1726 cp.no_stdin = 1;
1727 cp.out = -1;
eee49b6c 1728 cp.dir = path;
ee6fc514 1729 if (start_command(&cp))
a4ffbbbb 1730 die(_("Could not run 'git status --porcelain=2' in submodule %s"), path);
ee6fc514 1731
af6865a7
SB
1732 fp = xfdopen(cp.out, "r");
1733 while (strbuf_getwholeline(&buf, fp, '\n') != EOF) {
fcecf0b9
SB
1734 /* regular untracked files */
1735 if (buf.buf[0] == '?')
c7e1a736 1736 dirty_submodule |= DIRTY_SUBMODULE_UNTRACKED;
40069d6e
SB
1737
1738 if (buf.buf[0] == 'u' ||
1739 buf.buf[0] == '1' ||
1740 buf.buf[0] == '2') {
1741 /* T = line type, XY = status, SSSS = submodule state */
1742 if (buf.len < strlen("T XY SSSS"))
033abf97 1743 BUG("invalid status --porcelain=2 line %s",
40069d6e
SB
1744 buf.buf);
1745
1746 if (buf.buf[5] == 'S' && buf.buf[8] == 'U')
1747 /* nested untracked file */
1748 dirty_submodule |= DIRTY_SUBMODULE_UNTRACKED;
1749
1750 if (buf.buf[0] == 'u' ||
1751 buf.buf[0] == '2' ||
1752 memcmp(buf.buf + 5, "S..U", 4))
1753 /* other change */
1754 dirty_submodule |= DIRTY_SUBMODULE_MODIFIED;
c7e1a736 1755 }
64f9a946
SB
1756
1757 if ((dirty_submodule & DIRTY_SUBMODULE_MODIFIED) &&
1758 ((dirty_submodule & DIRTY_SUBMODULE_UNTRACKED) ||
af6865a7
SB
1759 ignore_untracked)) {
1760 /*
1761 * We're not interested in any further information from
1762 * the child any more, neither output nor its exit code.
1763 */
1764 ignore_cp_exit_code = 1;
c7e1a736 1765 break;
af6865a7 1766 }
c7e1a736 1767 }
af6865a7 1768 fclose(fp);
ee6fc514 1769
af6865a7 1770 if (finish_command(&cp) && !ignore_cp_exit_code)
a4ffbbbb 1771 die(_("'git status --porcelain=2' failed in submodule %s"), path);
ee6fc514 1772
ee6fc514 1773 strbuf_release(&buf);
c7e1a736 1774 return dirty_submodule;
ee6fc514 1775}
68d03e4a 1776
293ab15e
JL
1777int submodule_uses_gitfile(const char *path)
1778{
d3180279 1779 struct child_process cp = CHILD_PROCESS_INIT;
293ab15e
JL
1780 struct strbuf buf = STRBUF_INIT;
1781 const char *git_dir;
1782
1783 strbuf_addf(&buf, "%s/.git", path);
1784 git_dir = read_gitfile(buf.buf);
1785 if (!git_dir) {
1786 strbuf_release(&buf);
1787 return 0;
1788 }
1789 strbuf_release(&buf);
1790
1791 /* Now test that all nested submodules use a gitfile too */
afbdba39
JH
1792 strvec_pushl(&cp.args,
1793 "submodule", "foreach", "--quiet", "--recursive",
1794 "test -f .git", NULL);
1795
c12e8656 1796 prepare_submodule_repo_env(&cp.env_array);
293ab15e
JL
1797 cp.git_cmd = 1;
1798 cp.no_stdin = 1;
1799 cp.no_stderr = 1;
1800 cp.no_stdout = 1;
1801 cp.dir = path;
1802 if (run_command(&cp))
1803 return 0;
1804
1805 return 1;
1806}
1807
83b76966
SB
1808/*
1809 * Check if it is a bad idea to remove a submodule, i.e. if we'd lose data
1810 * when doing so.
1811 *
1812 * Return 1 if we'd lose data, return 0 if the removal is fine,
1813 * and negative values for errors.
1814 */
1815int bad_to_remove_submodule(const char *path, unsigned flags)
293ab15e 1816{
293ab15e 1817 ssize_t len;
d3180279 1818 struct child_process cp = CHILD_PROCESS_INIT;
293ab15e 1819 struct strbuf buf = STRBUF_INIT;
83b76966 1820 int ret = 0;
293ab15e 1821
dbe44faa 1822 if (!file_exists(path) || is_empty_dir(path))
83b76966 1823 return 0;
293ab15e
JL
1824
1825 if (!submodule_uses_gitfile(path))
83b76966 1826 return 1;
293ab15e 1827
c972bf4c 1828 strvec_pushl(&cp.args, "status", "--porcelain",
f6d8942b 1829 "--ignore-submodules=none", NULL);
83b76966
SB
1830
1831 if (flags & SUBMODULE_REMOVAL_IGNORE_UNTRACKED)
c972bf4c 1832 strvec_push(&cp.args, "-uno");
83b76966 1833 else
c972bf4c 1834 strvec_push(&cp.args, "-uall");
83b76966
SB
1835
1836 if (!(flags & SUBMODULE_REMOVAL_IGNORE_IGNORED_UNTRACKED))
c972bf4c 1837 strvec_push(&cp.args, "--ignored");
293ab15e 1838
c12e8656 1839 prepare_submodule_repo_env(&cp.env_array);
293ab15e
JL
1840 cp.git_cmd = 1;
1841 cp.no_stdin = 1;
1842 cp.out = -1;
1843 cp.dir = path;
83b76966
SB
1844 if (start_command(&cp)) {
1845 if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
35ad44cb 1846 die(_("could not start 'git status' in submodule '%s'"),
83b76966
SB
1847 path);
1848 ret = -1;
1849 goto out;
1850 }
293ab15e
JL
1851
1852 len = strbuf_read(&buf, cp.out, 1024);
1853 if (len > 2)
83b76966 1854 ret = 1;
293ab15e
JL
1855 close(cp.out);
1856
83b76966
SB
1857 if (finish_command(&cp)) {
1858 if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
35ad44cb 1859 die(_("could not run 'git status' in submodule '%s'"),
83b76966
SB
1860 path);
1861 ret = -1;
1862 }
1863out:
293ab15e 1864 strbuf_release(&buf);
83b76966 1865 return ret;
293ab15e
JL
1866}
1867
898c2e65
SB
1868void submodule_unset_core_worktree(const struct submodule *sub)
1869{
ce125d43 1870 struct strbuf config_path = STRBUF_INIT;
898c2e65 1871
ce125d43
JT
1872 submodule_name_to_gitdir(&config_path, the_repository, sub->name);
1873 strbuf_addstr(&config_path, "/config");
1874
1875 if (git_config_set_in_file_gently(config_path.buf, "core.worktree", NULL))
898c2e65
SB
1876 warning(_("Could not unset core.worktree setting in submodule '%s'"),
1877 sub->path);
1878
ce125d43 1879 strbuf_release(&config_path);
898c2e65
SB
1880}
1881
202275b9
SB
1882static const char *get_super_prefix_or_empty(void)
1883{
1884 const char *s = get_super_prefix();
1885 if (!s)
1886 s = "";
1887 return s;
1888}
1889
6e3c1595
SB
1890static int submodule_has_dirty_index(const struct submodule *sub)
1891{
1892 struct child_process cp = CHILD_PROCESS_INIT;
1893
da27bc81 1894 prepare_submodule_repo_env(&cp.env_array);
6e3c1595
SB
1895
1896 cp.git_cmd = 1;
c972bf4c 1897 strvec_pushl(&cp.args, "diff-index", "--quiet",
f6d8942b 1898 "--cached", "HEAD", NULL);
6e3c1595
SB
1899 cp.no_stdin = 1;
1900 cp.no_stdout = 1;
1901 cp.dir = sub->path;
1902 if (start_command(&cp))
a4ffbbbb 1903 die(_("could not recurse into submodule '%s'"), sub->path);
6e3c1595
SB
1904
1905 return finish_command(&cp);
1906}
1907
1908static void submodule_reset_index(const char *path)
1909{
1910 struct child_process cp = CHILD_PROCESS_INIT;
da27bc81 1911 prepare_submodule_repo_env(&cp.env_array);
6e3c1595
SB
1912
1913 cp.git_cmd = 1;
1914 cp.no_stdin = 1;
1915 cp.dir = path;
1916
c972bf4c 1917 strvec_pushf(&cp.args, "--super-prefix=%s%s/",
f6d8942b 1918 get_super_prefix_or_empty(), path);
94b7f156 1919 /* TODO: determine if this might overwright untracked files */
c972bf4c 1920 strvec_pushl(&cp.args, "read-tree", "-u", "--reset", NULL);
6e3c1595 1921
c972bf4c 1922 strvec_push(&cp.args, empty_tree_oid_hex());
6e3c1595
SB
1923
1924 if (run_command(&cp))
a4ffbbbb 1925 die(_("could not reset submodule index"));
6e3c1595
SB
1926}
1927
1928/**
1929 * Moves a submodule at a given path from a given head to another new head.
1930 * For edge cases (a submodule coming into existence or removing a submodule)
1931 * pass NULL for old or new respectively.
1932 */
1933int submodule_move_head(const char *path,
bc099914
BW
1934 const char *old_head,
1935 const char *new_head,
6e3c1595
SB
1936 unsigned flags)
1937{
1938 int ret = 0;
1939 struct child_process cp = CHILD_PROCESS_INIT;
1940 const struct submodule *sub;
f2d48994 1941 int *error_code_ptr, error_code;
6e3c1595 1942
627d9342 1943 if (!is_submodule_active(the_repository, path))
823bab09
SB
1944 return 0;
1945
f2d48994
SB
1946 if (flags & SUBMODULE_MOVE_HEAD_FORCE)
1947 /*
1948 * Pass non NULL pointer to is_submodule_populated_gently
1949 * to prevent die()-ing. We'll use connect_work_tree_and_git_dir
1950 * to fixup the submodule in the force case later.
1951 */
1952 error_code_ptr = &error_code;
1953 else
1954 error_code_ptr = NULL;
1955
bc099914 1956 if (old_head && !is_submodule_populated_gently(path, error_code_ptr))
f2d48994 1957 return 0;
6e3c1595 1958
14228447 1959 sub = submodule_from_path(the_repository, null_oid(), path);
6e3c1595
SB
1960
1961 if (!sub)
033abf97 1962 BUG("could not get submodule information for '%s'", path);
6e3c1595 1963
bc099914 1964 if (old_head && !(flags & SUBMODULE_MOVE_HEAD_FORCE)) {
6e3c1595
SB
1965 /* Check if the submodule has a dirty index. */
1966 if (submodule_has_dirty_index(sub))
1967 return error(_("submodule '%s' has dirty index"), path);
1968 }
1969
1970 if (!(flags & SUBMODULE_MOVE_HEAD_DRY_RUN)) {
bc099914 1971 if (old_head) {
6e3c1595 1972 if (!submodule_uses_gitfile(path))
cf7a901a 1973 absorb_git_dir_into_superproject(path,
6e3c1595
SB
1974 ABSORB_GITDIR_RECURSE_SUBMODULES);
1975 } else {
ce125d43
JT
1976 struct strbuf gitdir = STRBUF_INIT;
1977 submodule_name_to_gitdir(&gitdir, the_repository,
1978 sub->name);
1979 connect_work_tree_and_git_dir(path, gitdir.buf, 0);
1980 strbuf_release(&gitdir);
6e3c1595
SB
1981
1982 /* make sure the index is clean as well */
1983 submodule_reset_index(path);
1984 }
f2d48994 1985
bc099914 1986 if (old_head && (flags & SUBMODULE_MOVE_HEAD_FORCE)) {
ce125d43
JT
1987 struct strbuf gitdir = STRBUF_INIT;
1988 submodule_name_to_gitdir(&gitdir, the_repository,
1989 sub->name);
1990 connect_work_tree_and_git_dir(path, gitdir.buf, 1);
1991 strbuf_release(&gitdir);
f2d48994 1992 }
6e3c1595
SB
1993 }
1994
da27bc81 1995 prepare_submodule_repo_env(&cp.env_array);
6e3c1595
SB
1996
1997 cp.git_cmd = 1;
1998 cp.no_stdin = 1;
1999 cp.dir = path;
2000
c972bf4c 2001 strvec_pushf(&cp.args, "--super-prefix=%s%s/",
f6d8942b 2002 get_super_prefix_or_empty(), path);
c972bf4c 2003 strvec_pushl(&cp.args, "read-tree", "--recurse-submodules", NULL);
6e3c1595
SB
2004
2005 if (flags & SUBMODULE_MOVE_HEAD_DRY_RUN)
c972bf4c 2006 strvec_push(&cp.args, "-n");
6e3c1595 2007 else
c972bf4c 2008 strvec_push(&cp.args, "-u");
6e3c1595
SB
2009
2010 if (flags & SUBMODULE_MOVE_HEAD_FORCE)
c972bf4c 2011 strvec_push(&cp.args, "--reset");
6e3c1595 2012 else
c972bf4c 2013 strvec_push(&cp.args, "-m");
6e3c1595 2014
7dcc1f4d 2015 if (!(flags & SUBMODULE_MOVE_HEAD_FORCE))
c972bf4c 2016 strvec_push(&cp.args, old_head ? old_head : empty_tree_oid_hex());
7dcc1f4d 2017
c972bf4c 2018 strvec_push(&cp.args, new_head ? new_head : empty_tree_oid_hex());
6e3c1595
SB
2019
2020 if (run_command(&cp)) {
ba95d4e4 2021 ret = error(_("Submodule '%s' could not be updated."), path);
6e3c1595
SB
2022 goto out;
2023 }
2024
2025 if (!(flags & SUBMODULE_MOVE_HEAD_DRY_RUN)) {
bc099914 2026 if (new_head) {
a17062cf 2027 child_process_init(&cp);
6e3c1595 2028 /* also set the HEAD accordingly */
a17062cf
SB
2029 cp.git_cmd = 1;
2030 cp.no_stdin = 1;
2031 cp.dir = path;
6e3c1595 2032
218c8837 2033 prepare_submodule_repo_env(&cp.env_array);
c972bf4c 2034 strvec_pushl(&cp.args, "update-ref", "HEAD",
f6d8942b 2035 "--no-deref", new_head, NULL);
6e3c1595 2036
a17062cf 2037 if (run_command(&cp)) {
6e3c1595
SB
2038 ret = -1;
2039 goto out;
2040 }
2041 } else {
2042 struct strbuf sb = STRBUF_INIT;
2043
2044 strbuf_addf(&sb, "%s/.git", path);
2045 unlink_or_warn(sb.buf);
2046 strbuf_release(&sb);
2047
2048 if (is_empty_dir(path))
2049 rmdir_or_warn(path);
898c2e65
SB
2050
2051 submodule_unset_core_worktree(sub);
6e3c1595
SB
2052 }
2053 }
2054out:
2055 return ret;
2056}
2057
a8dee3ca
JS
2058int validate_submodule_git_dir(char *git_dir, const char *submodule_name)
2059{
2060 size_t len = strlen(git_dir), suffix_len = strlen(submodule_name);
2061 char *p;
2062 int ret = 0;
2063
2064 if (len <= suffix_len || (p = git_dir + len - suffix_len)[-1] != '/' ||
2065 strcmp(p, submodule_name))
2066 BUG("submodule name '%s' not a suffix of git dir '%s'",
2067 submodule_name, git_dir);
2068
2069 /*
2070 * We prevent the contents of sibling submodules' git directories to
2071 * clash.
2072 *
2073 * Example: having a submodule named `hippo` and another one named
2074 * `hippo/hooks` would result in the git directories
2075 * `.git/modules/hippo/` and `.git/modules/hippo/hooks/`, respectively,
2076 * but the latter directory is already designated to contain the hooks
2077 * of the former.
2078 */
2079 for (; *p; p++) {
2080 if (is_dir_sep(*p)) {
2081 char c = *p;
2082
2083 *p = '\0';
2084 if (is_git_directory(git_dir))
2085 ret = -1;
2086 *p = c;
2087
2088 if (ret < 0)
2089 return error(_("submodule git dir '%s' is "
2090 "inside git dir '%.*s'"),
2091 git_dir,
2092 (int)(p - git_dir), git_dir);
2093 }
2094 }
2095
2096 return 0;
2097}
2098
f6f85861
SB
2099/*
2100 * Embeds a single submodules git directory into the superprojects git dir,
2101 * non recursively.
2102 */
cf7a901a 2103static void relocate_single_git_dir_into_superproject(const char *path)
f6f85861
SB
2104{
2105 char *old_git_dir = NULL, *real_old_git_dir = NULL, *real_new_git_dir = NULL;
ce125d43 2106 struct strbuf new_gitdir = STRBUF_INIT;
f6f85861
SB
2107 const struct submodule *sub;
2108
2109 if (submodule_uses_worktrees(path))
2110 die(_("relocate_gitdir for submodule '%s' with "
2111 "more than one worktree not supported"), path);
2112
2113 old_git_dir = xstrfmt("%s/.git", path);
2114 if (read_gitfile(old_git_dir))
2115 /* If it is an actual gitfile, it doesn't need migration. */
2116 return;
2117
ce83eadd 2118 real_old_git_dir = real_pathdup(old_git_dir, 1);
f6f85861 2119
14228447 2120 sub = submodule_from_path(the_repository, null_oid(), path);
f6f85861
SB
2121 if (!sub)
2122 die(_("could not lookup name for submodule '%s'"), path);
2123
ce125d43
JT
2124 submodule_name_to_gitdir(&new_gitdir, the_repository, sub->name);
2125 if (validate_submodule_git_dir(new_gitdir.buf, sub->name) < 0)
a8dee3ca
JS
2126 die(_("refusing to move '%s' into an existing git dir"),
2127 real_old_git_dir);
ce125d43
JT
2128 if (safe_create_leading_directories_const(new_gitdir.buf) < 0)
2129 die(_("could not create directory '%s'"), new_gitdir.buf);
2130 real_new_git_dir = real_pathdup(new_gitdir.buf, 1);
f6f85861 2131
f6f85861 2132 fprintf(stderr, _("Migrating git directory of '%s%s' from\n'%s' to\n'%s'\n"),
202275b9 2133 get_super_prefix_or_empty(), path,
f6f85861
SB
2134 real_old_git_dir, real_new_git_dir);
2135
2136 relocate_gitdir(path, real_old_git_dir, real_new_git_dir);
2137
2138 free(old_git_dir);
2139 free(real_old_git_dir);
2140 free(real_new_git_dir);
ce125d43 2141 strbuf_release(&new_gitdir);
f6f85861
SB
2142}
2143
2144/*
2145 * Migrate the git directory of the submodule given by path from
2146 * having its git directory within the working tree to the git dir nested
2147 * in its superprojects git dir under modules/.
2148 */
cf7a901a 2149void absorb_git_dir_into_superproject(const char *path,
f6f85861
SB
2150 unsigned flags)
2151{
ec9629b3
SB
2152 int err_code;
2153 const char *sub_git_dir;
f6f85861 2154 struct strbuf gitdir = STRBUF_INIT;
f6f85861 2155 strbuf_addf(&gitdir, "%s/.git", path);
ec9629b3 2156 sub_git_dir = resolve_gitdir_gently(gitdir.buf, &err_code);
f6f85861
SB
2157
2158 /* Not populated? */
ec9629b3 2159 if (!sub_git_dir) {
ec9629b3 2160 const struct submodule *sub;
ce125d43 2161 struct strbuf sub_gitdir = STRBUF_INIT;
ec9629b3
SB
2162
2163 if (err_code == READ_GITFILE_ERR_STAT_FAILED) {
2164 /* unpopulated as expected */
2165 strbuf_release(&gitdir);
2166 return;
2167 }
2168
2169 if (err_code != READ_GITFILE_ERR_NOT_A_REPO)
2170 /* We don't know what broke here. */
2171 read_gitfile_error_die(err_code, path, NULL);
2172
2173 /*
2174 * Maybe populated, but no git directory was found?
2175 * This can happen if the superproject is a submodule
2176 * itself and was just absorbed. The absorption of the
2177 * superproject did not rewrite the git file links yet,
2178 * fix it now.
2179 */
14228447 2180 sub = submodule_from_path(the_repository, null_oid(), path);
ec9629b3
SB
2181 if (!sub)
2182 die(_("could not lookup name for submodule '%s'"), path);
ce125d43
JT
2183 submodule_name_to_gitdir(&sub_gitdir, the_repository, sub->name);
2184 connect_work_tree_and_git_dir(path, sub_gitdir.buf, 0);
2185 strbuf_release(&sub_gitdir);
ec9629b3
SB
2186 } else {
2187 /* Is it already absorbed into the superprojects git dir? */
ce83eadd
JS
2188 char *real_sub_git_dir = real_pathdup(sub_git_dir, 1);
2189 char *real_common_git_dir = real_pathdup(get_git_common_dir(), 1);
f6f85861 2190
ec9629b3 2191 if (!starts_with(real_sub_git_dir, real_common_git_dir))
cf7a901a 2192 relocate_single_git_dir_into_superproject(path);
ec9629b3
SB
2193
2194 free(real_sub_git_dir);
2195 free(real_common_git_dir);
2196 }
2197 strbuf_release(&gitdir);
f6f85861
SB
2198
2199 if (flags & ABSORB_GITDIR_RECURSE_SUBMODULES) {
2200 struct child_process cp = CHILD_PROCESS_INIT;
2201 struct strbuf sb = STRBUF_INIT;
2202
2203 if (flags & ~ABSORB_GITDIR_RECURSE_SUBMODULES)
033abf97 2204 BUG("we don't know how to pass the flags down?");
f6f85861 2205
202275b9 2206 strbuf_addstr(&sb, get_super_prefix_or_empty());
f6f85861
SB
2207 strbuf_addstr(&sb, path);
2208 strbuf_addch(&sb, '/');
2209
2210 cp.dir = path;
2211 cp.git_cmd = 1;
2212 cp.no_stdin = 1;
c972bf4c 2213 strvec_pushl(&cp.args, "--super-prefix", sb.buf,
f6d8942b
JK
2214 "submodule--helper",
2215 "absorb-git-dirs", NULL);
f6f85861
SB
2216 prepare_submodule_repo_env(&cp.env_array);
2217 if (run_command(&cp))
2218 die(_("could not recurse into submodule '%s'"), path);
2219
2220 strbuf_release(&sb);
2221 }
f6f85861 2222}
bf0231c6 2223
49d3c4b4 2224int get_superproject_working_tree(struct strbuf *buf)
bf0231c6
SB
2225{
2226 struct child_process cp = CHILD_PROCESS_INIT;
2227 struct strbuf sb = STRBUF_INIT;
4530a85b 2228 struct strbuf one_up = STRBUF_INIT;
bf0231c6 2229 const char *cwd = xgetcwd();
49d3c4b4 2230 int ret = 0;
bf0231c6
SB
2231 const char *subpath;
2232 int code;
2233 ssize_t len;
2234
2235 if (!is_inside_work_tree())
2236 /*
2237 * FIXME:
2238 * We might have a superproject, but it is harder
2239 * to determine.
2240 */
49d3c4b4 2241 return 0;
bf0231c6 2242
4530a85b 2243 if (!strbuf_realpath(&one_up, "../", 0))
49d3c4b4 2244 return 0;
bf0231c6 2245
4530a85b
AM
2246 subpath = relative_path(cwd, one_up.buf, &sb);
2247 strbuf_release(&one_up);
bf0231c6
SB
2248
2249 prepare_submodule_repo_env(&cp.env_array);
c972bf4c 2250 strvec_pop(&cp.env_array);
bf0231c6 2251
c972bf4c 2252 strvec_pushl(&cp.args, "--literal-pathspecs", "-C", "..",
f6d8942b
JK
2253 "ls-files", "-z", "--stage", "--full-name", "--",
2254 subpath, NULL);
bf0231c6
SB
2255 strbuf_reset(&sb);
2256
2257 cp.no_stdin = 1;
2258 cp.no_stderr = 1;
2259 cp.out = -1;
2260 cp.git_cmd = 1;
2261
2262 if (start_command(&cp))
2263 die(_("could not start ls-files in .."));
2264
2265 len = strbuf_read(&sb, cp.out, PATH_MAX);
2266 close(cp.out);
2267
2268 if (starts_with(sb.buf, "160000")) {
2269 int super_sub_len;
2270 int cwd_len = strlen(cwd);
2271 char *super_sub, *super_wt;
2272
2273 /*
2274 * There is a superproject having this repo as a submodule.
2275 * The format is <mode> SP <hash> SP <stage> TAB <full name> \0,
2276 * We're only interested in the name after the tab.
2277 */
2278 super_sub = strchr(sb.buf, '\t') + 1;
c5cbb27c 2279 super_sub_len = strlen(super_sub);
bf0231c6
SB
2280
2281 if (super_sub_len > cwd_len ||
2282 strcmp(&cwd[cwd_len - super_sub_len], super_sub))
c3c3486b 2283 BUG("returned path string doesn't match cwd?");
bf0231c6
SB
2284
2285 super_wt = xstrdup(cwd);
2286 super_wt[cwd_len - super_sub_len] = '\0';
2287
49d3c4b4
AM
2288 strbuf_realpath(buf, super_wt, 1);
2289 ret = 1;
bf0231c6
SB
2290 free(super_wt);
2291 }
2292 strbuf_release(&sb);
2293
2294 code = finish_command(&cp);
2295
2296 if (code == 128)
2297 /* '../' is not a git repository */
49d3c4b4 2298 return 0;
bf0231c6
SB
2299 if (code == 0 && len == 0)
2300 /* There is an unrelated git repository at '../' */
49d3c4b4 2301 return 0;
bf0231c6
SB
2302 if (code)
2303 die(_("ls-tree returned unexpected return code %d"), code);
2304
2305 return ret;
2306}
bbbb7de7 2307
3ce08548
HWN
2308/*
2309 * Put the gitdir for a submodule (given relative to the main
2310 * repository worktree) into `buf`, or return -1 on error.
2311 */
bbbb7de7
NTND
2312int submodule_to_gitdir(struct strbuf *buf, const char *submodule)
2313{
2314 const struct submodule *sub;
2315 const char *git_dir;
2316 int ret = 0;
2317
2318 strbuf_reset(buf);
2319 strbuf_addstr(buf, submodule);
2320 strbuf_complete(buf, '/');
2321 strbuf_addstr(buf, ".git");
2322
2323 git_dir = read_gitfile(buf->buf);
2324 if (git_dir) {
2325 strbuf_reset(buf);
2326 strbuf_addstr(buf, git_dir);
2327 }
2328 if (!is_git_directory(buf->buf)) {
14228447 2329 sub = submodule_from_path(the_repository, null_oid(),
2330 submodule);
bbbb7de7
NTND
2331 if (!sub) {
2332 ret = -1;
2333 goto cleanup;
2334 }
2335 strbuf_reset(buf);
ce125d43 2336 submodule_name_to_gitdir(buf, the_repository, sub->name);
bbbb7de7
NTND
2337 }
2338
2339cleanup:
2340 return ret;
2341}
ce125d43
JT
2342
2343void submodule_name_to_gitdir(struct strbuf *buf, struct repository *r,
2344 const char *submodule_name)
2345{
2346 /*
2347 * NEEDSWORK: The current way of mapping a submodule's name to
2348 * its location in .git/modules/ has problems with some naming
2349 * schemes. For example, if a submodule is named "foo" and
2350 * another is named "foo/bar" (whether present in the same
2351 * superproject commit or not - the problem will arise if both
2352 * superproject commits have been checked out at any point in
2353 * time), or if two submodule names only have different cases in
2354 * a case-insensitive filesystem.
2355 *
2356 * There are several solutions, including encoding the path in
2357 * some way, introducing a submodule.<name>.gitdir config in
2358 * .git/config (not .gitmodules) that allows overriding what the
2359 * gitdir of a submodule would be (and teach Git, upon noticing
2360 * a clash, to automatically determine a non-clashing name and
2361 * to write such a config), or introducing a
2362 * submodule.<name>.gitdir config in .gitmodules that repo
2363 * administrators can explicitly set. Nothing has been decided,
2364 * so for now, just append the name at the end of the path.
2365 */
2366 strbuf_repo_git_path(buf, r, "modules/");
2367 strbuf_addstr(buf, submodule_name);
2368}